[10/13] Move ptid.h to common-defs.h
Commit Message
This commit moves the inclusion of ptid.h to common-defs.h and removes
all other inclusions.
gdb/
2014-07-28 Gary Benson <gbenson@redhat.com>
* common/common-defs.h: Include ptid.h.
* defs.h: Do not include ptid.h.
* common/ptid.c: Likewise.
* inferior.h: Likewise.
* infrun.h: Likewise.
* nat/linux-btrace.h: Likewise.
* nat/linux-osdata.h: Likewise.
* target/waitstatus.h: Likewise.
gdb/gdbserver/
2014-07-28 Gary Benson <gbenson@redhat.com>
* server.h: Do not include ptid.h.
* notif.h: Likewise.
---
gdb/ChangeLog | 11 +++++++++++
gdb/common/common-defs.h | 1 +
gdb/common/ptid.c | 1 -
gdb/defs.h | 2 --
gdb/gdbserver/ChangeLog | 5 +++++
gdb/gdbserver/notif.h | 1 -
gdb/gdbserver/server.h | 1 -
gdb/inferior.h | 2 --
gdb/infrun.h | 1 -
gdb/nat/linux-btrace.h | 1 -
gdb/nat/linux-osdata.h | 2 --
gdb/target/waitstatus.h | 1 -
12 files changed, 17 insertions(+), 12 deletions(-)
Comments
Gary Benson wrote:
> This commit moves the inclusion of ptid.h to common-defs.h and
> removes all other inclusions.
>
> gdb/
> 2014-07-28 Gary Benson <gbenson@redhat.com>
>
> * common/common-defs.h: Include ptid.h.
> * defs.h: Do not include ptid.h.
> * common/ptid.c: Likewise.
As per:
Pedro Alves wrote [1]:
> It's a simpler rule if all .c files include their corresponding
> .h file.
I've updated my tree to reinstate '#include "ptid.h"' in ptid.c.
I won't post an updated patch. Please review this patch as though
the ptid.c change was not there.
Thanks,
Gary
--
[1] https://sourceware.org/ml/gdb-patches/2014-07/msg00745.html
@@ -36,5 +36,6 @@
#include "pathmax.h"
#include "gdb/signals.h"
#include "gdb_locale.h"
+#include "ptid.h"
#endif /* COMMON_DEFS_H */
@@ -22,7 +22,6 @@
#else
#include "defs.h"
#endif
-#include "ptid.h"
/* See ptid.h for these. */
@@ -113,8 +113,6 @@ typedef bfd_vma CORE_ADDR;
#define max(a, b) ((a) > (b) ? (a) : (b))
#endif
-#include "ptid.h"
-
/* * Enable xdb commands if set. */
extern int xdb_commands;
@@ -16,7 +16,6 @@
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>. */
-#include "ptid.h"
#include "server.h"
#include "target.h"
#include "queue.h"
@@ -71,7 +71,6 @@ int vsnprintf(char *str, size_t size, const char *format, va_list ap);
/* A type used for binary buffers. */
typedef unsigned char gdb_byte;
-#include "ptid.h"
#include "buffer.h"
#include "xml-utils.h"
@@ -31,8 +31,6 @@ struct ui_out;
struct terminal_info;
struct target_desc_info;
-#include "ptid.h"
-
/* For bpstat. */
#include "breakpoint.h"
@@ -18,7 +18,6 @@
#ifndef INFRUN_H
#define INFRUN_H 1
-#include "ptid.h"
#include "symtab.h"
struct target_waitstatus;
@@ -24,7 +24,6 @@
#include "btrace-common.h"
#include "vec.h"
-#include "ptid.h"
#include <stdint.h>
#if HAVE_LINUX_PERF_EVENT_H
@@ -20,8 +20,6 @@
#ifndef COMMON_LINUX_OSDATA_H
#define COMMON_LINUX_OSDATA_H
-#include "ptid.h"
-
extern int linux_common_core_of_thread (ptid_t ptid);
extern LONGEST linux_common_xfer_osdata (const char *annex, gdb_byte *readbuf,
ULONGEST offset, ULONGEST len);
@@ -21,7 +21,6 @@
#define WAITSTATUS_H
#include "common-utils.h"
-#include "ptid.h"
#include "gdb_signals.h"
/* Stuff for target_wait. */