diff mbox

Assign 'targerr' instead of 'targ' to gdb_stdtargerr.

Message ID 1404328417-28116-1-git-send-email-marc.khouzam@ericsson.com
State Committed
Headers

Commit Message

Marc Khouzam July 2, 2014, 7:13 p.m. UTC 
  Hi,

I noticed this what-seems-to-be-typo when browsing the code.
I'm not sure if the target can have two distinct streams or not 
but the code seems to think so.  I figure might as well fix it.
The original suspicious code was introduced at the same time as when
saved_output.targerr was added, so it really does look like a typo.
It was in commit 8d4d924b.

Is this ok?

Thanks


2014-07-02  Marc Khouzam  <marc.khouzam@ericsson.com>

    * cli/cli-logging.c (pop_output_files): Assign targerr to
    gdb_stdtargerr.

Comments

Tom Tromey July 3, 2014, 6:16 p.m. UTC | #1 
>>>>> "Marc" == Marc Khouzam <marc.khouzam@ericsson.com> writes:

Marc> 2014-07-02  Marc Khouzam  <marc.khouzam@ericsson.com>

Marc>     * cli/cli-logging.c (pop_output_files): Assign targerr to
Marc>     gdb_stdtargerr.

Ok.  Thanks for finding this.

Tom
Marc Khouzam July 3, 2014, 7:02 p.m. UTC | #2 
> -----Original Message-----
> From: Tom Tromey [mailto:tromey@redhat.com]
> Sent: Thursday, July 03, 2014 2:17 PM
> To: Marc Khouzam
> Cc: gdb-patches@sourceware.org
> Subject: Re: [PATCH] Assign 'targerr' instead of 'targ' to gdb_stdtargerr.
> 
> >>>>> "Marc" == Marc Khouzam <marc.khouzam@ericsson.com> writes:
> 
> Marc> 2014-07-02  Marc Khouzam  <marc.khouzam@ericsson.com>
> 
> Marc>     * cli/cli-logging.c (pop_output_files): Assign targerr to
> Marc>     gdb_stdtargerr.
> 
> Ok.  Thanks for finding this.

Thanks.  I committed it to master.

> 
> Tom
diff mbox

Patch

diff --git a/gdb/cli/cli-logging.c b/gdb/cli/cli-logging.c
index ca2d76e..aae0039 100644
--- a/gdb/cli/cli-logging.c
+++ b/gdb/cli/cli-logging.c
@@ -171,7 +171,7 @@  pop_output_files (void)
       gdb_stderr = saved_output.err;
       gdb_stdlog = saved_output.log;
       gdb_stdtarg = saved_output.targ;
-      gdb_stdtargerr = saved_output.targ;
+      gdb_stdtargerr = saved_output.targerr;
     }
 
   saved_output.out = NULL;