Message ID | cover.1704206350.git.aburgess@redhat.com |
---|---|
Headers |
Return-Path: <gdb-patches-bounces+patchwork=sourceware.org@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C669C385828B for <patchwork@sourceware.org>; Tue, 2 Jan 2024 14:43:53 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 594013858D32 for <gdb-patches@sourceware.org>; Tue, 2 Jan 2024 14:43:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 594013858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 594013858D32 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704206603; cv=none; b=aw+aY6N7ZUbVQw+ZeU4wcPRyLg1tUo4iW/g1C7ZRq4joDmxce8t8jlTMiyD+GeDCqyH4MH6/aivxHS9z7bM6CPDC5PR9xR5iAs3T4TzVGcUWMXtEJ47cD4pA0vCvtO8IZjkMABXnn3479sGzpsnP1QLWMpX8Ph2z2bIRJ3ckE0M= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704206603; c=relaxed/simple; bh=6fVsTKjlbo2sxvh3D0n7DWsjIto7A+Rj3MAVIQBKe6M=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=jCzWtqwUUql8VyDEfXXsXnnyjQwcGBuDtfZFsf4D7EACuNJgnM7YTg313TWaCKzqsuAvmVyXSAuOpeQjmVBFh2nQsI16ooVB1EnasatxUTD/GqFP23thTWcq5ZFZR+KD8GQ2ha1XQIcNlAGDAa1nZjvrsY4G/KZUkePY399WbB8= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1704206602; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WhdTpu1Gj/Rs/x1LOHxucotzzEaZClycuQxyUWEHmIg=; b=R0fwPFh5fYQFL3qZ43bpx8Id80z/vGklGvg6ISz25LZFCSw5DMpeQ7AXOXgRZEr3RKlMrE TWpNH7lSCAHxOFH756FcItVBHcQGNHf8RKvSFmocQvN/i7xGs3R5iSMpzlhJth1BuR4XBv 5K6xdqpPDmCcSFgvLoHVoqJXACMZyng= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-385-MX-l_vY7PAiNlbK13McamQ-1; Tue, 02 Jan 2024 09:43:20 -0500 X-MC-Unique: MX-l_vY7PAiNlbK13McamQ-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-336937af9e9so4300210f8f.0 for <gdb-patches@sourceware.org>; Tue, 02 Jan 2024 06:43:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704206599; x=1704811399; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WhdTpu1Gj/Rs/x1LOHxucotzzEaZClycuQxyUWEHmIg=; b=anNQRsoJRuilvYEUMwffKYJbJ8Z6Cx4KT/uCUk80ox8rX16bFkgpigc7UEluU+APNo OWSa2zKCFlf74D20mRfhXvSqDmaSa9VFIjH5RtNbzoKuDgEQWiUhoL7d0eFzRMRpl4Ab fhYKzaiefZHjqq7Lhoe5qFJrYi2WYCeY4tUp/GSkouYKSejpPtttfgIOo62G1vPViKMA lF0u0bP4v2JseAQ3eJSJE6uzhuAbHTmsdqdTTXXuSgo9IAi51sEIg8jUkGvlYNxckHh0 Fj8GLSpgNlVEu64z6tbZAx6/8Yag8u9zQZMPi2//k8hipzRzEJESQKuGHv/ggwoidRPb IBfw== X-Gm-Message-State: AOJu0YxaKPMyU9XE/PGI2qvF3SsqrVgYbsg5u7rOXKuVcbfDL0M13V42 a5DJREa0YTf2QXWFrP4QIv8hH0wN6fKw1LcvndBlApwaeAez+XaMtR9TxH8stTHHshc8++7Rtvs sJ4AEZ5kBUblsX5antw5FdF8JKOsijkb866yK1jNmV2kDj+MIFeMWdcidnWGGUlLHREOa2H1ZtN 1r2Z5VJ3mi/ULwLg== X-Received: by 2002:adf:e68e:0:b0:336:5b1e:ee66 with SMTP id r14-20020adfe68e000000b003365b1eee66mr9325222wrm.31.1704206598956; Tue, 02 Jan 2024 06:43:18 -0800 (PST) X-Google-Smtp-Source: AGHT+IF9nwht9ueuYtgvFth+E/fpElGorAS7XsTp1CcCsyuifykpxvZdrqCK62vziStjO6nWkZZ9XQ== X-Received: by 2002:adf:e68e:0:b0:336:5b1e:ee66 with SMTP id r14-20020adfe68e000000b003365b1eee66mr9325213wrm.31.1704206598648; Tue, 02 Jan 2024 06:43:18 -0800 (PST) Received: from localhost (185.223.159.143.dyn.plus.net. [143.159.223.185]) by smtp.gmail.com with ESMTPSA id z4-20020a5d4d04000000b00336a1f6ce7csm24106202wrt.19.2024.01.02.06.43.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Jan 2024 06:43:18 -0800 (PST) From: Andrew Burgess <aburgess@redhat.com> To: gdb-patches@sourceware.org Cc: Andrew Burgess <aburgess@redhat.com> Subject: [PATCHv2 0/3] Changes to error reporting from the expression parser Date: Tue, 2 Jan 2024 14:43:10 +0000 Message-Id: <cover.1704206350.git.aburgess@redhat.com> X-Mailer: git-send-email 2.25.4 In-Reply-To: <cover.1703361278.git.aburgess@redhat.com> References: <cover.1703361278.git.aburgess@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org> List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>, <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/gdb-patches/> List-Post: <mailto:gdb-patches@sourceware.org> List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help> List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>, <mailto:gdb-patches-request@sourceware.org?subject=subscribe> Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org |
Series |
Changes to error reporting from the expression parser
|
|
Message
Andrew Burgess
Jan. 2, 2024, 2:43 p.m. UTC
In V2: - Have split the "merging of error handling" into its own patch, adding the new error handling is in its own patch. - Reordered patches, the minor bug fix is now first, follow by the refactor, with the new functionality placed in the last patch. - Have dropped the whole <HERE> marker idea, and gone with the simpler 'error at end of ....' style message. This means that no tests need updating -- I have added a couple of new tests, but everything else should continue to pass as before. --- While working on another patch I wished that the error reporting from the expression parser was better. This series is my attempt to make it better. --- Andrew Burgess (3): gdb: don't try to style content in error calls gdb: merge error handling from different expression parsers gdb: improve error reporting from expression parser gdb/ada-exp.y | 2 +- gdb/c-exp.y | 5 +---- gdb/d-exp.y | 5 +---- gdb/f-exp.y | 5 +---- gdb/go-exp.y | 5 +---- gdb/m2-exp.y | 5 +---- gdb/p-exp.y | 5 +---- gdb/parse.c | 15 +++++++++++++++ gdb/parser-defs.h | 9 +++++++++ gdb/procfs.c | 6 ++---- gdb/testsuite/gdb.base/exprs.exp | 8 ++++++++ 11 files changed, 41 insertions(+), 29 deletions(-) base-commit: 90827b4eefb06f6e0ab6cbac9eb94922e2cc8aee
Comments
On 1/2/24 6:43 AM, Andrew Burgess wrote: > In V2: > > - Have split the "merging of error handling" into its own patch, > adding the new error handling is in its own patch. > > - Reordered patches, the minor bug fix is now first, follow by the > refactor, with the new functionality placed in the last patch. > > - Have dropped the whole <HERE> marker idea, and gone with the > simpler 'error at end of ....' style message. This means that no > tests need updating -- I have added a couple of new tests, but > everything else should continue to pass as before. > > --- > > While working on another patch I wished that the error reporting from > the expression parser was better. This series is my attempt to make > it better. > > --- > > Andrew Burgess (3): > gdb: don't try to style content in error calls > gdb: merge error handling from different expression parsers > gdb: improve error reporting from expression parser > > gdb/ada-exp.y | 2 +- > gdb/c-exp.y | 5 +---- > gdb/d-exp.y | 5 +---- > gdb/f-exp.y | 5 +---- > gdb/go-exp.y | 5 +---- > gdb/m2-exp.y | 5 +---- > gdb/p-exp.y | 5 +---- > gdb/parse.c | 15 +++++++++++++++ > gdb/parser-defs.h | 9 +++++++++ > gdb/procfs.c | 6 ++---- > gdb/testsuite/gdb.base/exprs.exp | 8 ++++++++ > 11 files changed, 41 insertions(+), 29 deletions(-) > > > base-commit: 90827b4eefb06f6e0ab6cbac9eb94922e2cc8aee Modulo the one nit I mentioned for the first patch, (and with the updated comment you noted in your reply to Lancelot SIX), these both look good to me. Approved-By: John Baldwin <jhb@FreeBSD.org>
John Baldwin <jhb@FreeBSD.org> writes: > On 1/2/24 6:43 AM, Andrew Burgess wrote: >> In V2: >> >> - Have split the "merging of error handling" into its own patch, >> adding the new error handling is in its own patch. >> >> - Reordered patches, the minor bug fix is now first, follow by the >> refactor, with the new functionality placed in the last patch. >> >> - Have dropped the whole <HERE> marker idea, and gone with the >> simpler 'error at end of ....' style message. This means that no >> tests need updating -- I have added a couple of new tests, but >> everything else should continue to pass as before. >> >> --- >> >> While working on another patch I wished that the error reporting from >> the expression parser was better. This series is my attempt to make >> it better. >> >> --- >> >> Andrew Burgess (3): >> gdb: don't try to style content in error calls >> gdb: merge error handling from different expression parsers >> gdb: improve error reporting from expression parser >> >> gdb/ada-exp.y | 2 +- >> gdb/c-exp.y | 5 +---- >> gdb/d-exp.y | 5 +---- >> gdb/f-exp.y | 5 +---- >> gdb/go-exp.y | 5 +---- >> gdb/m2-exp.y | 5 +---- >> gdb/p-exp.y | 5 +---- >> gdb/parse.c | 15 +++++++++++++++ >> gdb/parser-defs.h | 9 +++++++++ >> gdb/procfs.c | 6 ++---- >> gdb/testsuite/gdb.base/exprs.exp | 8 ++++++++ >> 11 files changed, 41 insertions(+), 29 deletions(-) >> >> >> base-commit: 90827b4eefb06f6e0ab6cbac9eb94922e2cc8aee > > Modulo the one nit I mentioned for the first patch, (and with the > updated comment you noted in your reply to Lancelot SIX), these both > look good to me. > > Approved-By: John Baldwin <jhb@FreeBSD.org> I took another look at patch #1, I would have sworn I found two places originally, but I can't find a second now .... not sure what happened there. Anyway, I updated the commit message to talk about a single problem case, and pushed this series. Thanks, Andrew