mbox series

[PATCHv2,0/8] Some vfork related fixes

Message ID cover.1688484032.git.aburgess@redhat.com
Headers
Series Some vfork related fixes |

Message

Andrew Burgess July 4, 2023, 3:22 p.m. UTC 
  Changes since v1:

  - Added an extra assert in patch #4, as suggested by Baris,

  - Updated some comments in patch #4 to better describe what's going
    on,

  - Added an extra debug printf in patch #8 which I found useful when
    checking what's actually going on (in order to change patch #4).

---

Andrew Burgess (7):
  gdb: catch more errors in gdb.base/foll-vfork.exp
  gdb: don't restart vfork parent while waiting for child to finish
  gdb: fix an issue with vfork in non-stop mode
  gdb: don't resume vfork parent while child is still running
  gdb/testsuite: expand gdb.base/foll-vfork.exp
  gdb/testsuite: remove use of sleep from gdb.base/foll-vfork.exp
  gdb: additional debug output in infrun.c and linux-nat.c

Mihails Strasuns (1):
  gdb, infrun: refactor part of `proceed` into separate function

 gdb/infrun.c                          | 189 ++++++---
 gdb/linux-nat.c                       |  32 +-
 gdb/testsuite/gdb.base/foll-vfork.exp | 588 ++++++++++++--------------
 3 files changed, 412 insertions(+), 397 deletions(-)


base-commit: bb2bd584f31a25ba1cfe5bdac4d07d8cffe87c3d

Comments

Terekhov, Mikhail via Gdb-patches July 5, 2023, 11:30 a.m. UTC | #1 
On Tuesday, July 4, 2023 5:23 PM, Andrew Burgess wrote:
> Changes since v1:
> 
>   - Added an extra assert in patch #4, as suggested by Baris,
> 
>   - Updated some comments in patch #4 to better describe what's going
>     on,
> 
>   - Added an extra debug printf in patch #8 which I found useful when
>     checking what's actually going on (in order to change patch #4).
> 
> ---

I looked at the patches in this series.  Thank you for the detailed
commit messages.  They were not only useful, but also educational.
I spotted only a few minor things and have already sent them.

Thanks
-Baris


Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
Andrew Burgess July 17, 2023, 8:53 a.m. UTC | #2 
"Aktemur, Tankut Baris" <tankut.baris.aktemur@intel.com> writes:

> On Tuesday, July 4, 2023 5:23 PM, Andrew Burgess wrote:
>> Changes since v1:
>> 
>>   - Added an extra assert in patch #4, as suggested by Baris,
>> 
>>   - Updated some comments in patch #4 to better describe what's going
>>     on,
>> 
>>   - Added an extra debug printf in patch #8 which I found useful when
>>     checking what's actually going on (in order to change patch #4).
>> 
>> ---
>
> I looked at the patches in this series.  Thank you for the detailed
> commit messages.  They were not only useful, but also educational.
> I spotted only a few minor things and have already sent them.

I've gone ahead and pushed this series.  If there is any additional
feedback I am, of course, happy to address it.  I have some additional
vfork related fixes that I'm hoping to post to the mailing list soon, so
having this series merged will help with that.

Thanks,
Andrew