mbox series

[0/2] New test for find_pc_sect_line

Message ID cover.1684398918.git.aburgess@redhat.com
Headers
Series New test for find_pc_sect_line |

Message

Andrew Burgess May 18, 2023, 8:37 a.m. UTC 
  Adds a new test to extend coverage of find_pc_sect_line, then adds
some asserts and safety checks to skip_prologue_using_sal.

---

Andrew Burgess (2):
  gdb/testsuite: test for a function with no line table
  gdb: safety checks in skip_prologue_using_sal

 gdb/symtab.c                                  |   8 +-
 gdb/testsuite/gdb.dwarf2/missing-line-table.c |  32 +++++
 .../gdb.dwarf2/missing-line-table.exp         | 122 ++++++++++++++++++
 3 files changed, 159 insertions(+), 3 deletions(-)
 create mode 100644 gdb/testsuite/gdb.dwarf2/missing-line-table.c
 create mode 100644 gdb/testsuite/gdb.dwarf2/missing-line-table.exp


base-commit: 66b8e6c7b8d3c137029f4f2ab8c5b798aa1cbdd7

Comments

Tom Tromey May 18, 2023, 5:22 p.m. UTC | #1 
>>>>> "Andrew" == Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org> writes:

Andrew> Adds a new test to extend coverage of find_pc_sect_line, then adds
Andrew> some asserts and safety checks to skip_prologue_using_sal.

These both seem fine to me.

Reviewed-By: Tom Tromey <tom@tromey.com>

Tom
Andrew Burgess May 19, 2023, 10:06 a.m. UTC | #2 
Tom Tromey <tom@tromey.com> writes:

>>>>>> "Andrew" == Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org> writes:
>
> Andrew> Adds a new test to extend coverage of find_pc_sect_line, then adds
> Andrew> some asserts and safety checks to skip_prologue_using_sal.
>
> These both seem fine to me.
>
> Reviewed-By: Tom Tromey <tom@tromey.com>

Pushed.

Thanks,
Andrew