mbox series

[PATCHv2,0/6] Inferior specific breakpoints

Message ID cover.1674207665.git.aburgess@redhat.com
Headers
Series Inferior specific breakpoints |

Message

Andrew Burgess Jan. 20, 2023, 9:46 a.m. UTC 
  Thanks for all the feedback on v1.

Changes in v2:

  - Biggest changes are in patch #3, as suggested by Baris, I've now
    removed the 'thread' and 'inferior' tags from the end of each
    location in the 'info breakpoints' output.  The information was
    already available in the condition line, so this removes some
    duplication.  For Ada task conditions I've added a condition line
    as this was missing.

  - Doc updates in #4 and #5 to fix the issues Eli pointed out.  These
    all seemed pretty minor so I don't think there should be anything
    too surprising there.

  - Updated patch #5 based on feedback from Baris, this was all pretty
    minor stuff though, formatting, and rewording some error messages,

  - Updated patch #6 based on feedback from Baris, this is a minor
    test cleanup.

Thanks,
Andrew

---

Andrew Burgess (6):
  gdb/remote: announce thread exit events for remote targets
  gdb/testsuite: don't try to set non-stop mode on a running target
  gdb: fix display of thread condition for multi-location breakpoints
  gdb: error if 'thread' or 'task' keywords are overused
  gdb: add inferior-specific breakpoints and watchpoints
  gdb: convert the 'start' breakpoint to use inferior keyword

 gdb/NEWS                                      |  16 ++
 gdb/breakpoint.c                              | 210 ++++++++++++++----
 gdb/breakpoint.h                              |  10 +-
 gdb/doc/gdb.texinfo                           |  74 +++++-
 gdb/doc/python.texi                           |  24 +-
 gdb/dummy-frame.c                             |   1 +
 gdb/elfread.c                                 |   5 +-
 gdb/guile/scm-breakpoint.c                    |   5 +
 gdb/infcmd.c                                  |  10 +-
 gdb/inferior.h                                |  11 +
 gdb/infrun.c                                  |   2 +
 gdb/linespec.c                                |   4 +-
 gdb/python/py-breakpoint.c                    |  77 +++++++
 gdb/remote.c                                  |   4 +
 gdb/testsuite/gdb.ada/tasks.exp               |  19 +-
 gdb/testsuite/gdb.base/save-bp.exp            |   2 +-
 .../gdb.base/start-inferior-specific-1.c      |  32 +++
 .../gdb.base/start-inferior-specific-2.c      |  22 ++
 .../gdb.base/start-inferior-specific.exp      |  55 +++++
 gdb/testsuite/gdb.base/thread-bp-multi-loc.c  |  44 ++++
 .../gdb.base/thread-bp-multi-loc.exp          |  72 ++++++
 gdb/testsuite/gdb.linespec/cpcompletion.exp   |   4 +-
 gdb/testsuite/gdb.linespec/explicit.exp       |   1 +
 gdb/testsuite/gdb.linespec/keywords.exp       |  10 +-
 .../gdb.multi/inferior-specific-bp-1.c        |  52 +++++
 .../gdb.multi/inferior-specific-bp-2.c        |  52 +++++
 .../gdb.multi/inferior-specific-bp.exp        | 182 +++++++++++++++
 gdb/testsuite/gdb.python/py-breakpoint.exp    |  43 ++++
 .../gdb.threads/thread-specific-bp.exp        | 142 ++++++------
 gdb/testsuite/gdb.threads/watchthreads2.exp   |   3 +
 gdb/testsuite/lib/completion-support.exp      |   2 +-
 31 files changed, 1041 insertions(+), 149 deletions(-)
 create mode 100644 gdb/testsuite/gdb.base/start-inferior-specific-1.c
 create mode 100644 gdb/testsuite/gdb.base/start-inferior-specific-2.c
 create mode 100644 gdb/testsuite/gdb.base/start-inferior-specific.exp
 create mode 100644 gdb/testsuite/gdb.base/thread-bp-multi-loc.c
 create mode 100644 gdb/testsuite/gdb.base/thread-bp-multi-loc.exp
 create mode 100644 gdb/testsuite/gdb.multi/inferior-specific-bp-1.c
 create mode 100644 gdb/testsuite/gdb.multi/inferior-specific-bp-2.c
 create mode 100644 gdb/testsuite/gdb.multi/inferior-specific-bp.exp


base-commit: 1a4cbc46d66812121ef359b1b0e954f4373ea8d0