mbox series

[0/2] New test for slow DWARF reader issue

Message ID cover.1670513780.git.aburgess@redhat.com
Headers
Series New test for slow DWARF reader issue |

Message

Andrew Burgess Dec. 8, 2022, 3:38 p.m. UTC 
  This series adds a test for PR gdb/gdb/29105, my motivation was to
better understand the commit that fixed this issue.

While writting the test in patch #2 I ran into a testsuite issue,
which is fixed in patch #1.

Thanks,
Andrew

---

Andrew Burgess (2):
  gdb/testsuite: fix readnow detection
  gdb/testsuite: new test for recent dwarf reader issue

 .../gdb.base/signed-builtin-types-lib.c       |  30 +++++
 gdb/testsuite/gdb.base/signed-builtin-types.c |  25 ++++
 .../gdb.base/signed-builtin-types.exp         | 112 ++++++++++++++++++
 gdb/testsuite/gdb.opt/break-on-_exit.exp      |   3 +-
 gdb/testsuite/gdb.rust/traits.exp             |   2 -
 gdb/testsuite/lib/gdb.exp                     |  30 +----
 gdb/testsuite/lib/mi-support.exp              |  28 +----
 7 files changed, 177 insertions(+), 53 deletions(-)
 create mode 100644 gdb/testsuite/gdb.base/signed-builtin-types-lib.c
 create mode 100644 gdb/testsuite/gdb.base/signed-builtin-types.c
 create mode 100644 gdb/testsuite/gdb.base/signed-builtin-types.exp


base-commit: 2d77a94ff17a81260b80997db476f87cba5f4b11

Comments

Tom Tromey Dec. 9, 2022, 6:18 p.m. UTC | #1 
>>>>> "Andrew" == Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org> writes:

Andrew> This series adds a test for PR gdb/gdb/29105, my motivation was to
Andrew> better understand the commit that fixed this issue.

Andrew> While writting the test in patch #2 I ran into a testsuite issue,
Andrew> which is fixed in patch #1.

Thank you for doing this.  These look good to me.

Tom
Andrew Burgess Dec. 14, 2022, 10:25 a.m. UTC | #2 
Tom Tromey <tom@tromey.com> writes:

>>>>>> "Andrew" == Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org> writes:
>
> Andrew> This series adds a test for PR gdb/gdb/29105, my motivation was to
> Andrew> better understand the commit that fixed this issue.
>
> Andrew> While writting the test in patch #2 I ran into a testsuite issue,
> Andrew> which is fixed in patch #1.
>
> Thank you for doing this.  These look good to me.

I fixed the demangle/canonicalization confusion in patch #2 and pushed
these patches.

Thanks,
Andrew