Message ID | 20240524154032.12652-1-abdul.b.ijaz@intel.com |
---|---|
Headers |
Return-Path: <gdb-patches-bounces+patchwork=sourceware.org@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3AC17386C583 for <patchwork@sourceware.org>; Fri, 24 May 2024 15:41:26 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) by sourceware.org (Postfix) with ESMTPS id A48D5384601F for <gdb-patches@sourceware.org>; Fri, 24 May 2024 15:40:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A48D5384601F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A48D5384601F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=198.175.65.18 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716565249; cv=none; b=ViEOUaUcjw6yhSPlclOIeGQHCeVlLiCXdGyqKH4FKFIXeuCpWoW1WNvNk7PcadsmDAQiPVNNMpFXUsAv5W30uP9R9Ozba5d1XmVnsRKSHDCvDXp2UAyqsR6ani/xItojW6A4WTpJI0tCcERkqBtlMxzMmrKduOwiZWc8bKyq7yE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716565249; c=relaxed/simple; bh=hi6evYsmvCVPKiAGr6v/mvIBlY0Q4t7ajDe2gbOY52E=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=j4v9HBP+gnXyOUSsMOu1M3v9cNPV78jU390G8DWAiL63aYt1p0+Q9g1v0Nut5Q3frFVtA6T8LPvnNE2hfs1UYHSeYK+0YwI3UNmTaC1eNDQmTH8fBDW+P3//yIcW8mQCO/tViREVdz/E4/+h21vzRjO0U/hRpkVdd87FRgdoplM= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1716565247; x=1748101247; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=hi6evYsmvCVPKiAGr6v/mvIBlY0Q4t7ajDe2gbOY52E=; b=LBVRsgFl23WGTExaJsvoAeDnENgppnsUQxxWoq8erEi4qZuWHKtOI9TZ SK39jGZL0zGNq3f+eesh3C31y80KsigDWKX/fDtK+gYI4wp0NM0zTSkAl dbDGC/uNjcAlJB2Ht5QR2qIBrM98luwlaPW8nbrAmLx+YQal/BY0wnOnx iE98hQmIIm7UCI1A0ijhc9XD4y0SpNhKz6j3j4gapByPkVhZnOOREikiL lhv376jUz0oBs8rYekticbNnFJZNOAkllksF4nvuYL+WqEwuc2GJ+NHsT i8vC2tpWxOwB9VJ6x0gsrVLbDiMPuBB+f/rg2MT8lITsBSyfPuWpPENCd g==; X-CSE-ConnectionGUID: 3nO+wmivQQylZ7GywqPo4A== X-CSE-MsgGUID: PTaZfkgTQZOh65LwDtM3cw== X-IronPort-AV: E=McAfee;i="6600,9927,11082"; a="13124014" X-IronPort-AV: E=Sophos;i="6.08,185,1712646000"; d="scan'208";a="13124014" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 May 2024 08:40:45 -0700 X-CSE-ConnectionGUID: jTO5UbJ2SROwUBV6vduLyA== X-CSE-MsgGUID: wwqbn+ZLRDa9803KTkfcFw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,185,1712646000"; d="scan'208";a="34650126" Received: from abijaz-mobl2.ger.corp.intel.com (HELO localhost) ([10.94.253.168]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 May 2024 08:40:44 -0700 From: Abdul Basit Ijaz <abdul.b.ijaz@intel.com> To: gdb-patches@sourceware.org Cc: abdul.b.ijaz@intel.com, JiniSusan.George@amd.com, tom@tromey.com, eliz@gnu.org Subject: [PATCH v8 00/10] GDB support for DW_AT_trampoline Date: Fri, 24 May 2024 17:40:22 +0200 Message-Id: <20240524154032.12652-1-abdul.b.ijaz@intel.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org> List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>, <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/gdb-patches/> List-Post: <mailto:gdb-patches@sourceware.org> List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help> List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>, <mailto:gdb-patches-request@sourceware.org?subject=subscribe> Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org |
Series |
GDB support for DW_AT_trampoline
|
|
Message
Ijaz, Abdul B
May 24, 2024, 3:40 p.m. UTC
From: "Ijaz, Abdul B" <abdul.b.ijaz@intel.com>
please find attached a series of patches that attempts to enable GDB to handle the DW_AT_trampoline attribute on functions and inlined functions.
DW_AT_trampoline can be emitted by the compiler for functions that are compiler generated trampolines (e.g. wrapping other function calls).
In doing so, the compiler can specify a target as the value of DW_AT_trampoline which the trampoline is wrapping.
This series enables GDB to recognize the DW_AT_trampoline and store the target for a given function. Patch 3 adapts GDB's stepping behavior when dealing with trampolines and attempts to - by default - hide these trampolines from the user. When about to step into a trampoline, instead, GDB will try and step through the trampoline and directly towards the target. For rest of the patches as the name of the patch indicates it implements skipping of trampolines for the command mentioned in the patch name.
A new setting has also been introduced in this change to turn off this modified stepping behavior or printing of stack for trampolines.
The motivation for these patches comes from ifx which emits the attribute for some of its compiler generated functions. As I do not know of any other compiler (especially gcc/gfortran) emitting DW_AT_trampoline, I added a gdb.dwarf2 test to this series in order to test the trampoline handling within GDB.
Changes since V7:
* Fix the documentation issues in 3rd & 9th patch according to https://sourceware.org/pipermail/gdb-patches/2024-May/209374.html
& https://sourceware.org/pipermail/gdb-patches/2024-May/209380.html.
V7 series of patches can be found here:
https://sourceware.org/pipermail/gdb-patches/2024-May/209360.html
Only documentation part is updated on top of patch 7. No regression seen on testing x64/(-m32)/x32 configurations.
Thanks & Best Regards
Abdul Basit
Ijaz, Abdul B (7):
gdb: Skip trampoline frames for the backtrace command.
gdb: Skip trampoline functions for the finish and reverse-finish
commands.
gdb: Skip trampoline functions for the up command.
gdb: Skip trampoline functions for the return command.
gdb, mi: Skip trampoline functions for the -stack-list-frames command.
gdb, mi: Skip trampoline functions for the -stack-list-arguments
command.
gdb: Filter trampoline frames in backtrace when using Python
frame-filters.
Nils-Christian Kempke (3):
gdb, dwarf: add support for DW_AT_trampoline in DWARF reader
gdb/symtab: add lookup for trampoline functions
gdb: handle stepping through functions with DW_AT_trampoline
gdb/NEWS | 13 +
gdb/doc/gdb.texinfo | 52 +++-
gdb/dwarf2/read.c | 39 ++-
gdb/gdbtypes.c | 34 ++-
gdb/gdbtypes.h | 113 +++++++-
gdb/infcmd.c | 12 +
gdb/infrun.c | 95 ++++++-
gdb/infrun.h | 16 ++
gdb/mi/mi-cmd-stack.c | 14 +
gdb/python/py-frame.c | 11 +
gdb/stack.c | 26 ++
gdb/symtab.c | 81 ++++++
gdb/symtab.h | 19 ++
.../gdb.dwarf2/dw2-function-trampolines.c | 80 ++++++
.../gdb.dwarf2/dw2-function-trampolines.exp | 245 ++++++++++++++++++
gdb/testsuite/gdb.fortran/func-trampoline.exp | 102 ++++++++
gdb/testsuite/gdb.fortran/func-trampoline.f90 | 39 +++
.../gdb.fortran/mixed-lang-stack.exp | 10 +-
gdb/testsuite/gdb.mi/mi-func-trampoline.exp | 75 ++++++
.../gdb.python/py-framefilter-trampoline.exp | 77 ++++++
.../gdb.python/py-framefilter-trampoline.py | 31 +++
.../gdb.reverse/finish-reverse-trampoline.exp | 56 ++++
22 files changed, 1225 insertions(+), 15 deletions(-)
create mode 100644 gdb/testsuite/gdb.dwarf2/dw2-function-trampolines.c
create mode 100644 gdb/testsuite/gdb.dwarf2/dw2-function-trampolines.exp
create mode 100644 gdb/testsuite/gdb.fortran/func-trampoline.exp
create mode 100644 gdb/testsuite/gdb.fortran/func-trampoline.f90
create mode 100644 gdb/testsuite/gdb.mi/mi-func-trampoline.exp
create mode 100644 gdb/testsuite/gdb.python/py-framefilter-trampoline.exp
create mode 100644 gdb/testsuite/gdb.python/py-framefilter-trampoline.py
create mode 100644 gdb/testsuite/gdb.reverse/finish-reverse-trampoline.exp