mbox series

[0/7] More cleanup of defs.h

Message ID 20240423132517.2625632-1-simon.marchi@polymtl.ca
Headers
Series More cleanup of defs.h |

Message

Simon Marchi April 23, 2024, 1:22 p.m. UTC 
  Some more cleanup of defs.h.  I tested this on the buildbot, but it's
very possible that it breaks the build on untested platforms.  If this
happens, the fix should be one include away.

Simon Marchi (7):
  gdb: move declarations of check_quit_flag and set_quit_flag to
    extension.h
  gdb: change return type of check_quit_flag to bool
  gdb: change type of quit_flag to bool
  gdb: move a bunch of quit-related things to event-top.{c,h}
  gdb: move annotation_level declaration/definition to annotate.{h,c}
  gdb: remove enum precision_type
  gdb: move symbol_file_command declaration to symfile.h

 gdb/ada-lang.c              |  1 +
 gdb/ada-typeprint.c         |  1 +
 gdb/ada-valprint.c          |  1 +
 gdb/addrmap.c               |  1 +
 gdb/amd64-windows-tdep.c    |  1 +
 gdb/annotate.c              |  4 ++
 gdb/annotate.h              |  8 ++++
 gdb/breakpoint.c            |  1 +
 gdb/c-typeprint.c           |  1 +
 gdb/cli/cli-script.c        |  1 +
 gdb/coffread.c              |  1 +
 gdb/corefile.c              |  1 +
 gdb/cp-valprint.c           |  1 +
 gdb/dbxread.c               |  1 +
 gdb/defs.h                  | 80 -------------------------------------
 gdb/disasm.c                |  1 +
 gdb/dwarf2/cooked-index.c   |  1 +
 gdb/dwarf2/expr.c           |  1 +
 gdb/dwarf2/loc.c            |  1 +
 gdb/dwarf2/read-gdb-index.c |  1 +
 gdb/dwarf2/read.c           |  1 +
 gdb/event-top.c             | 52 +++++++++++++++++++++---
 gdb/event-top.h             | 52 ++++++++++++++++++++++++
 gdb/extension-priv.h        |  4 +-
 gdb/extension.c             | 33 ++++++---------
 gdb/extension.h             | 30 ++++++++++++++
 gdb/f-typeprint.c           |  1 +
 gdb/findvar.c               |  1 +
 gdb/frame.c                 |  1 +
 gdb/gdb_bfd.c               |  1 +
 gdb/linux-fork.c            |  1 +
 gdb/m2-lang.c               |  1 +
 gdb/m2-typeprint.c          |  1 +
 gdb/main.c                  |  1 +
 gdb/mi/mi-cmd-stack.c       |  1 +
 gdb/objc-lang.c             |  1 +
 gdb/p-lang.c                |  1 +
 gdb/p-typeprint.c           |  1 +
 gdb/printcmd.c              |  1 +
 gdb/psymtab.c               |  1 +
 gdb/python/python.c         |  6 +--
 gdb/remote-fileio.c         |  3 +-
 gdb/remote-sim.c            |  1 +
 gdb/rust-lang.c             |  1 +
 gdb/ser-base.c              |  1 +
 gdb/skip.c                  |  1 +
 gdb/solib-rocm.c            |  1 +
 gdb/sparc64-tdep.c          |  1 +
 gdb/stabsread.c             |  1 +
 gdb/stack.c                 |  9 +----
 gdb/symfile.c               | 14 +------
 gdb/symfile.h               | 16 ++++++++
 gdb/symmisc.c               |  1 +
 gdb/symtab.c                |  1 +
 gdb/tracepoint.c            |  1 +
 gdb/tui/tui.c               |  1 +
 gdb/utils.c                 | 41 -------------------
 gdb/valops.c                |  1 +
 gdb/valprint.c              |  1 +
 gdb/xcoffread.c             |  1 +
 60 files changed, 224 insertions(+), 174 deletions(-)


base-commit: 6a7d971a8a95d35310388959acfa82bc9d63aba6

Comments

Tom Tromey April 23, 2024, 3 p.m. UTC | #1 
>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:

Simon> Some more cleanup of defs.h.  I tested this on the buildbot, but it's
Simon> very possible that it breaks the build on untested platforms.  If this
Simon> happens, the fix should be one include away.

This all looks good to me.  Thank you.

Approved-By: Tom Tromey <tom@tromey.com>

Simon>  gdb/utils.c                 | 41 -------------------

Shrinking utils.[ch] is always good as well.

Tom