mbox series

[0/7] First cleanup of defs.h

Message ID 20240422201157.46375-1-simon.marchi@efficios.com
Headers
Series First cleanup of defs.h |

Message

Simon Marchi April 22, 2024, 8:10 p.m. UTC 
  Here is a first batch of patches that remove things from defs.h, trying
to sort them in more appropriate places.

Simon Marchi (7):
  gdb: move two declarations out of defs.h
  gdb: move `enum compile_i_scope_types` to compile/compile.h
  gdb: remove extract_long_unsigned_integer
  gdb: move store/extract integer functions to
    extract-store-integer.{c,h}
  gdb: move RequireLongest to gdbsupport/traits.h
  gdb: don't include hashtab.h in defs.h
  gdb: don't include gdbsupport/array-view.h in defs.h

 gdb/Makefile.in                     |   2 +
 gdb/aarch64-fbsd-tdep.c             |   1 +
 gdb/aarch64-linux-tdep.c            |   1 +
 gdb/aarch64-tdep.c                  |   1 +
 gdb/ada-lang.c                      |   1 +
 gdb/ada-tasks.c                     |   1 +
 gdb/ada-valprint.c                  |   1 +
 gdb/alpha-tdep.c                    |   1 +
 gdb/amd64-darwin-tdep.c             |   1 +
 gdb/amd64-linux-tdep.c              |   1 +
 gdb/amd64-obsd-tdep.c               |   1 +
 gdb/amd64-tdep.c                    |   1 +
 gdb/amd64-windows-tdep.c            |   1 +
 gdb/arc-tdep.c                      |   1 +
 gdb/arch-utils.c                    |   1 +
 gdb/arm-linux-tdep.c                |   1 +
 gdb/arm-none-tdep.c                 |   1 +
 gdb/arm-tdep.c                      |   1 +
 gdb/auxv.c                          |   1 +
 gdb/avr-tdep.c                      |   1 +
 gdb/bfin-linux-tdep.c               |   1 +
 gdb/bfin-tdep.c                     |   1 +
 gdb/bsd-uthread.c                   |   1 +
 gdb/c-lang.c                        |   1 +
 gdb/c-valprint.c                    |   1 +
 gdb/cli/cli-script.h                |   1 +
 gdb/compile/compile-object-load.h   |   1 +
 gdb/compile/compile.h               |  28 +++
 gdb/corefile.c                      |   1 +
 gdb/cp-valprint.c                   |   1 +
 gdb/cris-tdep.c                     |   1 +
 gdb/csky-tdep.c                     |   1 +
 gdb/darwin-nat.c                    |   1 +
 gdb/defs.h                          | 132 ------------
 gdb/dtrace-probe.c                  |   1 +
 gdb/dwarf2/die.h                    |   1 +
 gdb/dwarf2/index-common.h           |   3 +
 gdb/elfread.c                       |   1 +
 gdb/extension.h                     |   1 +
 gdb/extract-store-integer.c         | 308 ++++++++++++++++++++++++++++
 gdb/extract-store-integer.h         | 113 ++++++++++
 gdb/fbsd-tdep.c                     |   1 +
 gdb/findvar.c                       | 292 +-------------------------
 gdb/frame-unwind.c                  |   1 +
 gdb/frame.c                         |   1 +
 gdb/frv-linux-tdep.c                |   1 +
 gdb/frv-tdep.c                      |   1 +
 gdb/ft32-tdep.c                     |   1 +
 gdb/gnu-v3-abi.c                    |   1 +
 gdb/h8300-tdep.c                    |   1 +
 gdb/hppa-bsd-tdep.c                 |   1 +
 gdb/hppa-linux-tdep.c               |   1 +
 gdb/hppa-tdep.c                     |   1 +
 gdb/i386-bsd-tdep.c                 |   1 +
 gdb/i386-darwin-tdep.c              |   1 +
 gdb/i386-gnu-tdep.c                 |   1 +
 gdb/i386-linux-tdep.c               |   1 +
 gdb/i386-nto-tdep.c                 |   1 +
 gdb/i386-obsd-tdep.c                |   1 +
 gdb/i386-tdep.c                     |   1 +
 gdb/i387-tdep.c                     |   1 +
 gdb/ia64-linux-tdep.c               |   1 +
 gdb/ia64-tdep.c                     |   1 +
 gdb/inferior.c                      |   4 +-
 gdb/inferior.h                      |   3 +
 gdb/iq2000-tdep.c                   |   1 +
 gdb/jit.c                           |   1 +
 gdb/linux-nat-trad.c                |   1 +
 gdb/linux-record.c                  |   1 +
 gdb/lm32-tdep.c                     |   1 +
 gdb/loongarch-linux-tdep.c          |   1 +
 gdb/loongarch-tdep.c                |   1 +
 gdb/m32c-tdep.c                     |   1 +
 gdb/m32r-linux-tdep.c               |   1 +
 gdb/m32r-tdep.c                     |   1 +
 gdb/m68hc11-tdep.c                  |   1 +
 gdb/m68k-linux-tdep.c               |   1 +
 gdb/m68k-tdep.c                     |   1 +
 gdb/mep-tdep.c                      |   1 +
 gdb/mi/mi-main.c                    |   1 +
 gdb/microblaze-tdep.c               |   1 +
 gdb/mips-fbsd-tdep.c                |   1 +
 gdb/mips-linux-tdep.c               |   1 +
 gdb/mips-netbsd-tdep.c              |   1 +
 gdb/mips-tdep.c                     |   1 +
 gdb/mn10300-tdep.c                  |   1 +
 gdb/moxie-tdep.c                    |   1 +
 gdb/msp430-tdep.c                   |   1 +
 gdb/nds32-tdep.c                    |   1 +
 gdb/nios2-tdep.c                    |   1 +
 gdb/nto-tdep.c                      |   1 +
 gdb/or1k-tdep.c                     |   1 +
 gdb/p-lang.c                        |   1 +
 gdb/p-valprint.c                    |   1 +
 gdb/ppc-fbsd-tdep.c                 |   1 +
 gdb/ppc-linux-nat.c                 |   1 +
 gdb/ppc-linux-tdep.c                |   1 +
 gdb/ppc-obsd-tdep.c                 |   1 +
 gdb/ppc-sysv-tdep.c                 |   1 +
 gdb/ppc64-tdep.c                    |   1 +
 gdb/printcmd.c                      |   1 +
 gdb/procfs.c                        |   1 +
 gdb/progspace.c                     |   4 +-
 gdb/progspace.h                     |   3 +
 gdb/ravenscar-thread.c              |   1 +
 gdb/record-full.c                   |   1 +
 gdb/regcache.c                      |   1 +
 gdb/regcache.h                      |   1 +
 gdb/remote-fileio.c                 |   1 +
 gdb/riscv-fbsd-tdep.c               |   1 +
 gdb/riscv-tdep.c                    |   1 +
 gdb/rl78-tdep.c                     |   1 +
 gdb/rs6000-aix-tdep.c               |   1 +
 gdb/rs6000-lynx178-tdep.c           |   1 +
 gdb/rs6000-tdep.c                   |   1 +
 gdb/rx-tdep.c                       |   1 +
 gdb/s390-linux-nat.c                |   1 +
 gdb/s390-tdep.c                     |   1 +
 gdb/sh-tdep.c                       |   1 +
 gdb/solib-darwin.c                  |   1 +
 gdb/solib-dsbt.c                    |   1 +
 gdb/solib-frv.c                     |   1 +
 gdb/solib-svr4.c                    |   1 +
 gdb/solib.c                         |   1 +
 gdb/sparc-linux-tdep.c              |   1 +
 gdb/sparc-obsd-tdep.c               |   1 +
 gdb/sparc-tdep.c                    |   1 +
 gdb/sparc64-linux-tdep.c            |   1 +
 gdb/sparc64-obsd-tdep.c             |   1 +
 gdb/sparc64-tdep.c                  |   1 +
 gdb/stack.c                         |   1 +
 gdb/stap-probe.c                    |   1 +
 gdb/symfile.c                       |   1 +
 gdb/target.c                        |   1 +
 gdb/tic6x-tdep.c                    |   1 +
 gdb/tilegx-tdep.c                   |   1 +
 gdb/tracefile-tfile.c               |   1 +
 gdb/tracefile.c                     |   1 +
 gdb/trad-frame.c                    |   1 +
 gdb/tramp-frame.c                   |   1 +
 gdb/unittests/gmp-utils-selftests.c |   1 +
 gdb/v850-tdep.c                     |   1 +
 gdb/valarith.c                      |   1 +
 gdb/valops.c                        |   1 +
 gdb/valprint.c                      |   1 +
 gdb/value.c                         |   1 +
 gdb/vax-tdep.c                      |   1 +
 gdb/windows-tdep.c                  |   1 +
 gdb/xstormy16-tdep.c                |   1 +
 gdb/xtensa-tdep.c                   |   1 +
 gdb/z80-tdep.c                      |   1 +
 gdbsupport/traits.h                 |   4 +
 152 files changed, 609 insertions(+), 427 deletions(-)
 create mode 100644 gdb/extract-store-integer.c
 create mode 100644 gdb/extract-store-integer.h


base-commit: fdaa4939e5024ea809c0d4d1aa6043a60b37d9b5

Comments

John Baldwin April 22, 2024, 10:55 p.m. UTC | #1 
On 4/22/24 1:10 PM, Simon Marchi wrote:
> Here is a first batch of patches that remove things from defs.h, trying
> to sort them in more appropriate places.
> 
> Simon Marchi (7):
>    gdb: move two declarations out of defs.h
>    gdb: move `enum compile_i_scope_types` to compile/compile.h
>    gdb: remove extract_long_unsigned_integer
>    gdb: move store/extract integer functions to
>      extract-store-integer.{c,h}
>    gdb: move RequireLongest to gdbsupport/traits.h
>    gdb: don't include hashtab.h in defs.h
>    gdb: don't include gdbsupport/array-view.h in defs.h

These all look ok to me.

Approved-By: John Baldwin <jhb@FreeBSD.org>
Simon Marchi April 23, 2024, 1:38 a.m. UTC | #2 
On 2024-04-22 18:55, John Baldwin wrote:
> On 4/22/24 1:10 PM, Simon Marchi wrote:
>> Here is a first batch of patches that remove things from defs.h, trying
>> to sort them in more appropriate places.
>>
>> Simon Marchi (7):
>>    gdb: move two declarations out of defs.h
>>    gdb: move `enum compile_i_scope_types` to compile/compile.h
>>    gdb: remove extract_long_unsigned_integer
>>    gdb: move store/extract integer functions to
>>      extract-store-integer.{c,h}
>>    gdb: move RequireLongest to gdbsupport/traits.h
>>    gdb: don't include hashtab.h in defs.h
>>    gdb: don't include gdbsupport/array-view.h in defs.h
> 
> These all look ok to me.
> 
> Approved-By: John Baldwin <jhb@FreeBSD.org>
> 

Thanks, pushed.

Simon