mbox series

[v4,0/3] Dynamic properties of pointers

Message ID 20240104123520.7706-1-abdul.b.ijaz@intel.com
Headers
Series Dynamic properties of pointers |

Message

Abdul Basit Ijaz Jan. 4, 2024, 12:35 p.m. UTC 
  From: "Ijaz, Abdul B" <abdul.b.ijaz@intel.com>

Hi!

Please find the attached v4 of this series where now majorly dropped
icc/ifort special dwarf handling related changes.  This is because
ifx/icpx compilers does not need such handling and they may be used
instead.  Also fix the copyrights and indentation issue as per the
feedback on V3 series.

V3 can be found here:
https://sourceware.org/pipermail/gdb-patches/2023-September/202143.html

V2 patch 2 was approved by Tom already in this discussion but there are
minor changes since then:
https://sourceware.org/pipermail/gdb-patches/2023-January/195353.html

V2 can be found here:
https://sourceware.org/pipermail/gdb-patches/2022-October/192389.html

V1 with feedback can be found here:
https://sourceware.org/pipermail/gdb-patches/2022-September/191934.html

Changes since v3:

  * Patch 1 : ICC/Ifort changes are dropped and instead it contains now
  only new indentation issue fixes for gdb.dwarf2/dynarr-ptr.exp.

  * Patch 2:
  Fix Tom and Thiago feedback related to copyrights and identation in test
  files.

  * Patch 3:
  Original patch 3 for handling of icc/ifort dwarf is dropped and now
  this is replaced by patch#4 of V3 series.  Ifort related comments are
  removed.  As this change is general for Fortran pointers.

Following test configurations are tested on Ubuntu22.04 and no
regression is seen:
gcc64/gcc32/native-gdbserver/native-extended-gdbserver(-m32)

I'm looking forward to comments.

Thanks & Best Regards,
Abdul Basit

Bernhard Heckel (1):
  gdb, types: Resolve pointer types dynamically

Ijaz, Abdul B (1):
  gdb/testsuite: Fix indentation issues in gdb.dwarf2/dynarr-ptr.exp

Nils-Christian Kempke (1):
  gdb, testsuite, fortran: Fix sizeof intrinsic for Fortran pointers

 gdb/eval.c                                    |   7 +
 gdb/gdbtypes.c                                |   7 +-
 gdb/testsuite/gdb.cp/vla-cxx.cc               |   4 +
 gdb/testsuite/gdb.cp/vla-cxx.exp              |  15 ++
 gdb/testsuite/gdb.dwarf2/dynarr-ptr.exp       | 138 +++++++++---------
 .../gdb.fortran/pointer-to-pointer.exp        |   2 +-
 gdb/testsuite/gdb.fortran/pointers.exp        | 115 +++++++++++++++
 gdb/testsuite/gdb.fortran/pointers.f90        |  29 ++++
 gdb/testsuite/gdb.fortran/sizeof.exp          | 115 +++++++++++++++
 gdb/testsuite/gdb.fortran/sizeof.f90          | 108 ++++++++++++++
 gdb/valprint.c                                |   6 -
 11 files changed, 468 insertions(+), 78 deletions(-)
 create mode 100644 gdb/testsuite/gdb.fortran/pointers.exp
 create mode 100644 gdb/testsuite/gdb.fortran/sizeof.exp
 create mode 100644 gdb/testsuite/gdb.fortran/sizeof.f90

Comments

Tom Tromey Jan. 11, 2024, 5:51 p.m. UTC | #1 
>>>>> "Abdul" == Abdul Basit Ijaz <abdul.b.ijaz@intel.com> writes:

Abdul> Please find the attached v4 of this series where now majorly dropped
Abdul> icc/ifort special dwarf handling related changes.  This is because
Abdul> ifx/icpx compilers does not need such handling and they may be used
Abdul> instead.  Also fix the copyrights and indentation issue as per the
Abdul> feedback on V3 series.

I sent a few notes.  Nothing very serious, this is looking good to me.

Tom