mbox series

[0/6] Several DAP fixes for VSCode

Message ID 20230725-dap-bt-path-v1-0-bb015b0d8e54@adacore.com
Headers
Series Several DAP fixes for VSCode |

Message

Tom Tromey July 25, 2023, 1:49 p.m. UTC 
  Vladimir Makaev tried the gdb DAP implementation with VSCode and found
a few bugs.  This series fixes these.  It also adds a new DAP launch
parameter -- I thought I was going to need this, and while I didn't,
it still seemed like a good idea to add.

I'm not completely happy with this series.  See the "full paths" patch
for some discussion.  Essentially I think the FrameDecorator API is
not very well thought out, and once again this is an area where it
would be very nice if we could add new methods to the spec.

I wonder whether we should.  One difference between pretty-printers
and frame decorators is that my sense is that there are many more of
the former, so the smaller for the latter.

Another idea I had for that patch is to just change the base behavior
of FrameDecorator, based on a global flag -- that would only be set by
DAP.

---
Tom Tromey (6):
      Rename private member of FrameDecorator
      Refactor dap_launch
      Add "cwd" parameter to DAP launch request
      Full paths in DAP stackTrace responses
      Move DAP breakpoint event code to breakpoint.py
      Do not send "new breakpoint" event when breakpoint is set

 gdb/doc/gdb.texinfo                    |   8 +++
 gdb/python/lib/gdb/FrameDecorator.py   | 119 ++++++++++++++++++++-------------
 gdb/python/lib/gdb/dap/breakpoint.py   |  64 +++++++++++++++++-
 gdb/python/lib/gdb/dap/events.py       |  37 ----------
 gdb/python/lib/gdb/dap/launch.py       |  34 +++++-----
 gdb/python/lib/gdb/frames.py           |  14 +++-
 gdb/testsuite/gdb.dap/args-env.exp     |   2 +-
 gdb/testsuite/gdb.dap/basic-dap.exp    |  11 +--
 gdb/testsuite/gdb.dap/cwd.exp          |  40 +++++++++++
 gdb/testsuite/gdb.dap/stop-at-main.exp |   2 +-
 gdb/testsuite/lib/dap-support.exp      |  72 +++++++++++++-------
 11 files changed, 262 insertions(+), 141 deletions(-)
---
base-commit: 695776dc2f43c56dd2ae2f7036fb7cf74e19b46b
change-id: 20230725-dap-bt-path-32e910a3ee36

Best regards,