mbox series

[0/8] Minor C++-ification and cleanup in trace targets

Message ID 20230709-trace-cleanups-v1-0-c410e1072fab@tromey.com
Headers
Series Minor C++-ification and cleanup in trace targets |

Message

Tom Tromey July 9, 2023, 5:01 p.m. UTC 
  This series applies some minor C++-ification and cleanups to the trace
targets.

Regression tested on x86-64 Fedora 38.

---
Tom Tromey (8):
      Remove a use of xfree
      Replace use of xfree with byte_vector
      Use unique_ptr for trace_filename
      Use unique_ptr for trace_dirname
      Use function_view in traceframe_walk_blocks
      Constify tfile_interp_line
      Move definition of ctf_target type
      Change 'handle_id' to be a local variable

 gdb/tracectf.c        | 77 ++++++++++++++++++++++-------------------------
 gdb/tracefile-tfile.c | 82 ++++++++++++++++++++-------------------------------
 2 files changed, 68 insertions(+), 91 deletions(-)
---
base-commit: 4fb2abb59d16f6395162f2e8d9494cde4a37e4a1
change-id: 20230709-trace-cleanups-3aa3911e56cd

Best regards,

Comments

Keith Seitz July 9, 2023, 8:52 p.m. UTC | #1 
On 7/9/23 10:01, Tom Tromey wrote:
> This series applies some minor C++-ification and cleanups to the trace
> targets.
> 
> Regression tested on x86-64 Fedora 38.

I've read through the series, and I don't see anything concerning here.

Only ~340 more uses of xfree left. :-)

Reviewed-by: Keith Seitz <keiths@redhat.com>

Keith
Tom Tromey July 10, 2023, 7:02 p.m. UTC | #2 
> I've read through the series, and I don't see anything concerning here.
> Only ~340 more uses of xfree left. :-)

> Reviewed-by: Keith Seitz <keiths@redhat.com>

Thanks, I'm going to check it in.

Tom