[v3,00/16] SME support for AArch64 gdb/gdbserver on Linux

Message ID 20230630134616.1238105-1-luis.machado@arm.com
Headers
Series SME support for AArch64 gdb/gdbserver on Linux |

Message

Luis Machado June 30, 2023, 1:46 p.m. UTC
  The following series enables SME 1 (Scalable Matrix Extension) support for
AArch64 gdb and gdbserver.

SME expands on SVE by having a variable-sized matrix (ZA) of dimensions
SVL x SVL bytes.

The first few patches and some intermediate ones refactor the code and fix
issues prior to enabling SME support, and thus could go in independently.

I've kept them in the series as they are closely/logically related.

--

Luis Machado (16):
  [gdb/aarch64] Fix register fetch/store order for native AArch64 Linux
  [gdb/aarch64] refactor: Rename SVE-specific files
  [gdb/gdbserver] refactor: Simplify SVE interface to read/write
    registers
  [gdb/aarch64] sve: Fix return command when using V registers in a
    SVE-enabled target
  [gdb/aarch64] sme: Enable SME registers and pseudo-registers
  [gdbserver/aarch64] refactor: Adjust expedited registers dynamically
  [gdbserver/aarch64] sme: Add support for SME
  [gdb/aarch64] sve: Fix signal frame z/v register restore
  [gdb/aarch64] sme: Signal frame support
  [gdb/aarch64] sme: Fixup sigframe gdbarch when vg/svg changes
  [gdb/aarch64] sme: Support TPIDR2 signal frame context
  [gdb/generic] corefile/bug: Use thread-specific gdbarch when dumping
    register state to core files
  [gdb/generic] corefile/bug: Fixup (gcore) core file target description
    reading order
  [gdb/aarch64] sme: Core file support for Linux
  [gdb/testsuite] sme: Add SVE/SME testcases
  [gdb/docs] sme: Document SME registers and features

 gdb/Makefile.in                               |   6 +-
 gdb/NEWS                                      |  11 +
 gdb/aarch64-linux-nat.c                       | 179 ++--
 gdb/aarch64-linux-tdep.c                      | 951 ++++++++++++++---
 gdb/aarch64-tdep.c                            | 724 ++++++++++++-
 gdb/aarch64-tdep.h                            |  47 +
 gdb/arch/aarch64-scalable-linux.c             |  55 +
 gdb/arch/aarch64-scalable-linux.h             |  53 +
 gdb/arch/aarch64.c                            |   5 +
 gdb/arch/aarch64.h                            |  57 +-
 gdb/configure.nat                             |   2 +-
 gdb/configure.tgt                             |   1 +
 gdb/corelow.c                                 |  24 +-
 gdb/doc/gdb.texinfo                           | 249 +++++
 gdb/features/aarch64-sme.c                    |  63 ++
 gdb/linux-tdep.c                              |  18 +-
 gdb/nat/aarch64-scalable-linux-ptrace.c       | 993 ++++++++++++++++++
 gdb/nat/aarch64-scalable-linux-ptrace.h       | 156 +++
 ....h => aarch64-scalable-linux-sigcontext.h} |  73 +-
 gdb/nat/aarch64-sve-linux-ptrace.c            | 392 -------
 gdb/nat/aarch64-sve-linux-ptrace.h            |  72 --
 gdb/testsuite/gdb.arch/aarch64-sme-core-0.exp |  18 +
 gdb/testsuite/gdb.arch/aarch64-sme-core-1.exp |  18 +
 gdb/testsuite/gdb.arch/aarch64-sme-core-2.exp |  18 +
 gdb/testsuite/gdb.arch/aarch64-sme-core-3.exp |  18 +
 gdb/testsuite/gdb.arch/aarch64-sme-core-4.exp |  18 +
 gdb/testsuite/gdb.arch/aarch64-sme-core.c     | 372 +++++++
 .../gdb.arch/aarch64-sme-core.exp.tcl         | 187 ++++
 .../gdb.arch/aarch64-sme-regs-available-0.exp |  18 +
 .../gdb.arch/aarch64-sme-regs-available-1.exp |  18 +
 .../gdb.arch/aarch64-sme-regs-available-2.exp |  18 +
 .../gdb.arch/aarch64-sme-regs-available-3.exp |  18 +
 .../gdb.arch/aarch64-sme-regs-available-4.exp |  18 +
 .../gdb.arch/aarch64-sme-regs-available.c     | 178 ++++
 .../aarch64-sme-regs-available.exp.tcl        | 245 +++++
 .../gdb.arch/aarch64-sme-regs-sigframe-0.exp  |  18 +
 .../gdb.arch/aarch64-sme-regs-sigframe-1.exp  |  18 +
 .../gdb.arch/aarch64-sme-regs-sigframe-2.exp  |  18 +
 .../gdb.arch/aarch64-sme-regs-sigframe-3.exp  |  18 +
 .../gdb.arch/aarch64-sme-regs-sigframe-4.exp  |  18 +
 .../gdb.arch/aarch64-sme-regs-sigframe.c      | 366 +++++++
 .../aarch64-sme-regs-sigframe.exp.tcl         | 179 ++++
 .../aarch64-sme-regs-unavailable-0.exp        |  18 +
 .../aarch64-sme-regs-unavailable-1.exp        |  18 +
 .../aarch64-sme-regs-unavailable-2.exp        |  18 +
 .../aarch64-sme-regs-unavailable-3.exp        |  18 +
 .../aarch64-sme-regs-unavailable-4.exp        |  18 +
 .../gdb.arch/aarch64-sme-regs-unavailable.c   | 152 +++
 .../aarch64-sme-regs-unavailable.exp.tcl      | 212 ++++
 gdb/testsuite/gdb.arch/aarch64-sme-sanity.c   | 249 +++++
 gdb/testsuite/gdb.arch/aarch64-sme-sanity.exp |  72 ++
 gdb/testsuite/lib/aarch64-test-sme.c          |  90 ++
 gdb/testsuite/lib/aarch64-test-sve.c          |  90 ++
 gdb/testsuite/lib/aarch64.exp                 | 372 +++++++
 gdb/testsuite/lib/gdb.exp                     | 249 +++++
 gdb/tramp-frame.c                             |   1 +
 gdb/tramp-frame.h                             |  12 +
 gdbserver/Makefile.in                         |   2 +-
 gdbserver/configure.srv                       |   3 +-
 gdbserver/linux-aarch64-low.cc                | 100 +-
 gdbserver/linux-aarch64-tdesc.cc              |  28 +-
 gdbserver/server.h                            |   2 +-
 62 files changed, 6958 insertions(+), 694 deletions(-)
 create mode 100644 gdb/arch/aarch64-scalable-linux.c
 create mode 100644 gdb/arch/aarch64-scalable-linux.h
 create mode 100644 gdb/features/aarch64-sme.c
 create mode 100644 gdb/nat/aarch64-scalable-linux-ptrace.c
 create mode 100644 gdb/nat/aarch64-scalable-linux-ptrace.h
 rename gdb/nat/{aarch64-sve-linux-sigcontext.h => aarch64-scalable-linux-sigcontext.h} (78%)
 delete mode 100644 gdb/nat/aarch64-sve-linux-ptrace.c
 delete mode 100644 gdb/nat/aarch64-sve-linux-ptrace.h
 create mode 100644 gdb/testsuite/gdb.arch/aarch64-sme-core-0.exp
 create mode 100644 gdb/testsuite/gdb.arch/aarch64-sme-core-1.exp
 create mode 100644 gdb/testsuite/gdb.arch/aarch64-sme-core-2.exp
 create mode 100644 gdb/testsuite/gdb.arch/aarch64-sme-core-3.exp
 create mode 100644 gdb/testsuite/gdb.arch/aarch64-sme-core-4.exp
 create mode 100644 gdb/testsuite/gdb.arch/aarch64-sme-core.c
 create mode 100644 gdb/testsuite/gdb.arch/aarch64-sme-core.exp.tcl
 create mode 100644 gdb/testsuite/gdb.arch/aarch64-sme-regs-available-0.exp
 create mode 100644 gdb/testsuite/gdb.arch/aarch64-sme-regs-available-1.exp
 create mode 100644 gdb/testsuite/gdb.arch/aarch64-sme-regs-available-2.exp
 create mode 100644 gdb/testsuite/gdb.arch/aarch64-sme-regs-available-3.exp
 create mode 100644 gdb/testsuite/gdb.arch/aarch64-sme-regs-available-4.exp
 create mode 100644 gdb/testsuite/gdb.arch/aarch64-sme-regs-available.c
 create mode 100644 gdb/testsuite/gdb.arch/aarch64-sme-regs-available.exp.tcl
 create mode 100644 gdb/testsuite/gdb.arch/aarch64-sme-regs-sigframe-0.exp
 create mode 100644 gdb/testsuite/gdb.arch/aarch64-sme-regs-sigframe-1.exp
 create mode 100644 gdb/testsuite/gdb.arch/aarch64-sme-regs-sigframe-2.exp
 create mode 100644 gdb/testsuite/gdb.arch/aarch64-sme-regs-sigframe-3.exp
 create mode 100644 gdb/testsuite/gdb.arch/aarch64-sme-regs-sigframe-4.exp
 create mode 100644 gdb/testsuite/gdb.arch/aarch64-sme-regs-sigframe.c
 create mode 100644 gdb/testsuite/gdb.arch/aarch64-sme-regs-sigframe.exp.tcl
 create mode 100644 gdb/testsuite/gdb.arch/aarch64-sme-regs-unavailable-0.exp
 create mode 100644 gdb/testsuite/gdb.arch/aarch64-sme-regs-unavailable-1.exp
 create mode 100644 gdb/testsuite/gdb.arch/aarch64-sme-regs-unavailable-2.exp
 create mode 100644 gdb/testsuite/gdb.arch/aarch64-sme-regs-unavailable-3.exp
 create mode 100644 gdb/testsuite/gdb.arch/aarch64-sme-regs-unavailable-4.exp
 create mode 100644 gdb/testsuite/gdb.arch/aarch64-sme-regs-unavailable.c
 create mode 100644 gdb/testsuite/gdb.arch/aarch64-sme-regs-unavailable.exp.tcl
 create mode 100644 gdb/testsuite/gdb.arch/aarch64-sme-sanity.c
 create mode 100644 gdb/testsuite/gdb.arch/aarch64-sme-sanity.exp
 create mode 100644 gdb/testsuite/lib/aarch64-test-sme.c
 create mode 100644 gdb/testsuite/lib/aarch64-test-sve.c
 create mode 100644 gdb/testsuite/lib/aarch64.exp
  

Comments

Luis Machado July 24, 2023, 8:15 a.m. UTC | #1
Hi,

I'm considering pushing some of the arch-specific fixes/refactors, as those should be 
reasonably simple.

On 6/30/23 14:46, Luis Machado via Gdb-patches wrote:
> The following series enables SME 1 (Scalable Matrix Extension) support for
> AArch64 gdb and gdbserver.
> 
> SME expands on SVE by having a variable-sized matrix (ZA) of dimensions
> SVL x SVL bytes.
> 
> The first few patches and some intermediate ones refactor the code and fix
> issues prior to enabling SME support, and thus could go in independently.
> 
> I've kept them in the series as they are closely/logically related.
> 
> --
> 
> Luis Machado (16):
>   [gdb/aarch64] Fix register fetch/store order for native AArch64 Linux
>   [gdb/aarch64] refactor: Rename SVE-specific files
>   [gdb/gdbserver] refactor: Simplify SVE interface to read/write
>     registers
>   [gdb/aarch64] sve: Fix return command when using V registers in a
>     SVE-enabled target
>   [gdb/aarch64] sme: Enable SME registers and pseudo-registers
>   [gdbserver/aarch64] refactor: Adjust expedited registers dynamically
>   [gdbserver/aarch64] sme: Add support for SME
>   [gdb/aarch64] sve: Fix signal frame z/v register restore
>   [gdb/aarch64] sme: Signal frame support
>   [gdb/aarch64] sme: Fixup sigframe gdbarch when vg/svg changes
>   [gdb/aarch64] sme: Support TPIDR2 signal frame context
>   [gdb/generic] corefile/bug: Use thread-specific gdbarch when dumping
>     register state to core files
>   [gdb/generic] corefile/bug: Fixup (gcore) core file target description
>     reading order
>   [gdb/aarch64] sme: Core file support for Linux
>   [gdb/testsuite] sme: Add SVE/SME testcases
>   [gdb/docs] sme: Document SME registers and features
> 
>  gdb/Makefile.in                               |   6 +-
>  gdb/NEWS                                      |  11 +
>  gdb/aarch64-linux-nat.c                       | 179 ++--
>  gdb/aarch64-linux-tdep.c                      | 951 ++++++++++++++---
>  gdb/aarch64-tdep.c                            | 724 ++++++++++++-
>  gdb/aarch64-tdep.h                            |  47 +
>  gdb/arch/aarch64-scalable-linux.c             |  55 +
>  gdb/arch/aarch64-scalable-linux.h             |  53 +
>  gdb/arch/aarch64.c                            |   5 +
>  gdb/arch/aarch64.h                            |  57 +-
>  gdb/configure.nat                             |   2 +-
>  gdb/configure.tgt                             |   1 +
>  gdb/corelow.c                                 |  24 +-
>  gdb/doc/gdb.texinfo                           | 249 +++++
>  gdb/features/aarch64-sme.c                    |  63 ++
>  gdb/linux-tdep.c                              |  18 +-
>  gdb/nat/aarch64-scalable-linux-ptrace.c       | 993 ++++++++++++++++++
>  gdb/nat/aarch64-scalable-linux-ptrace.h       | 156 +++
>  ....h => aarch64-scalable-linux-sigcontext.h} |  73 +-
>  gdb/nat/aarch64-sve-linux-ptrace.c            | 392 -------
>  gdb/nat/aarch64-sve-linux-ptrace.h            |  72 --
>  gdb/testsuite/gdb.arch/aarch64-sme-core-0.exp |  18 +
>  gdb/testsuite/gdb.arch/aarch64-sme-core-1.exp |  18 +
>  gdb/testsuite/gdb.arch/aarch64-sme-core-2.exp |  18 +
>  gdb/testsuite/gdb.arch/aarch64-sme-core-3.exp |  18 +
>  gdb/testsuite/gdb.arch/aarch64-sme-core-4.exp |  18 +
>  gdb/testsuite/gdb.arch/aarch64-sme-core.c     | 372 +++++++
>  .../gdb.arch/aarch64-sme-core.exp.tcl         | 187 ++++
>  .../gdb.arch/aarch64-sme-regs-available-0.exp |  18 +
>  .../gdb.arch/aarch64-sme-regs-available-1.exp |  18 +
>  .../gdb.arch/aarch64-sme-regs-available-2.exp |  18 +
>  .../gdb.arch/aarch64-sme-regs-available-3.exp |  18 +
>  .../gdb.arch/aarch64-sme-regs-available-4.exp |  18 +
>  .../gdb.arch/aarch64-sme-regs-available.c     | 178 ++++
>  .../aarch64-sme-regs-available.exp.tcl        | 245 +++++
>  .../gdb.arch/aarch64-sme-regs-sigframe-0.exp  |  18 +
>  .../gdb.arch/aarch64-sme-regs-sigframe-1.exp  |  18 +
>  .../gdb.arch/aarch64-sme-regs-sigframe-2.exp  |  18 +
>  .../gdb.arch/aarch64-sme-regs-sigframe-3.exp  |  18 +
>  .../gdb.arch/aarch64-sme-regs-sigframe-4.exp  |  18 +
>  .../gdb.arch/aarch64-sme-regs-sigframe.c      | 366 +++++++
>  .../aarch64-sme-regs-sigframe.exp.tcl         | 179 ++++
>  .../aarch64-sme-regs-unavailable-0.exp        |  18 +
>  .../aarch64-sme-regs-unavailable-1.exp        |  18 +
>  .../aarch64-sme-regs-unavailable-2.exp        |  18 +
>  .../aarch64-sme-regs-unavailable-3.exp        |  18 +
>  .../aarch64-sme-regs-unavailable-4.exp        |  18 +
>  .../gdb.arch/aarch64-sme-regs-unavailable.c   | 152 +++
>  .../aarch64-sme-regs-unavailable.exp.tcl      | 212 ++++
>  gdb/testsuite/gdb.arch/aarch64-sme-sanity.c   | 249 +++++
>  gdb/testsuite/gdb.arch/aarch64-sme-sanity.exp |  72 ++
>  gdb/testsuite/lib/aarch64-test-sme.c          |  90 ++
>  gdb/testsuite/lib/aarch64-test-sve.c          |  90 ++
>  gdb/testsuite/lib/aarch64.exp                 | 372 +++++++
>  gdb/testsuite/lib/gdb.exp                     | 249 +++++
>  gdb/tramp-frame.c                             |   1 +
>  gdb/tramp-frame.h                             |  12 +
>  gdbserver/Makefile.in                         |   2 +-
>  gdbserver/configure.srv                       |   3 +-
>  gdbserver/linux-aarch64-low.cc                | 100 +-
>  gdbserver/linux-aarch64-tdesc.cc              |  28 +-
>  gdbserver/server.h                            |   2 +-
>  62 files changed, 6958 insertions(+), 694 deletions(-)
>  create mode 100644 gdb/arch/aarch64-scalable-linux.c
>  create mode 100644 gdb/arch/aarch64-scalable-linux.h
>  create mode 100644 gdb/features/aarch64-sme.c
>  create mode 100644 gdb/nat/aarch64-scalable-linux-ptrace.c
>  create mode 100644 gdb/nat/aarch64-scalable-linux-ptrace.h
>  rename gdb/nat/{aarch64-sve-linux-sigcontext.h => aarch64-scalable-linux-sigcontext.h} (78%)
>  delete mode 100644 gdb/nat/aarch64-sve-linux-ptrace.c
>  delete mode 100644 gdb/nat/aarch64-sve-linux-ptrace.h
>  create mode 100644 gdb/testsuite/gdb.arch/aarch64-sme-core-0.exp
>  create mode 100644 gdb/testsuite/gdb.arch/aarch64-sme-core-1.exp
>  create mode 100644 gdb/testsuite/gdb.arch/aarch64-sme-core-2.exp
>  create mode 100644 gdb/testsuite/gdb.arch/aarch64-sme-core-3.exp
>  create mode 100644 gdb/testsuite/gdb.arch/aarch64-sme-core-4.exp
>  create mode 100644 gdb/testsuite/gdb.arch/aarch64-sme-core.c
>  create mode 100644 gdb/testsuite/gdb.arch/aarch64-sme-core.exp.tcl
>  create mode 100644 gdb/testsuite/gdb.arch/aarch64-sme-regs-available-0.exp
>  create mode 100644 gdb/testsuite/gdb.arch/aarch64-sme-regs-available-1.exp
>  create mode 100644 gdb/testsuite/gdb.arch/aarch64-sme-regs-available-2.exp
>  create mode 100644 gdb/testsuite/gdb.arch/aarch64-sme-regs-available-3.exp
>  create mode 100644 gdb/testsuite/gdb.arch/aarch64-sme-regs-available-4.exp
>  create mode 100644 gdb/testsuite/gdb.arch/aarch64-sme-regs-available.c
>  create mode 100644 gdb/testsuite/gdb.arch/aarch64-sme-regs-available.exp.tcl
>  create mode 100644 gdb/testsuite/gdb.arch/aarch64-sme-regs-sigframe-0.exp
>  create mode 100644 gdb/testsuite/gdb.arch/aarch64-sme-regs-sigframe-1.exp
>  create mode 100644 gdb/testsuite/gdb.arch/aarch64-sme-regs-sigframe-2.exp
>  create mode 100644 gdb/testsuite/gdb.arch/aarch64-sme-regs-sigframe-3.exp
>  create mode 100644 gdb/testsuite/gdb.arch/aarch64-sme-regs-sigframe-4.exp
>  create mode 100644 gdb/testsuite/gdb.arch/aarch64-sme-regs-sigframe.c
>  create mode 100644 gdb/testsuite/gdb.arch/aarch64-sme-regs-sigframe.exp.tcl
>  create mode 100644 gdb/testsuite/gdb.arch/aarch64-sme-regs-unavailable-0.exp
>  create mode 100644 gdb/testsuite/gdb.arch/aarch64-sme-regs-unavailable-1.exp
>  create mode 100644 gdb/testsuite/gdb.arch/aarch64-sme-regs-unavailable-2.exp
>  create mode 100644 gdb/testsuite/gdb.arch/aarch64-sme-regs-unavailable-3.exp
>  create mode 100644 gdb/testsuite/gdb.arch/aarch64-sme-regs-unavailable-4.exp
>  create mode 100644 gdb/testsuite/gdb.arch/aarch64-sme-regs-unavailable.c
>  create mode 100644 gdb/testsuite/gdb.arch/aarch64-sme-regs-unavailable.exp.tcl
>  create mode 100644 gdb/testsuite/gdb.arch/aarch64-sme-sanity.c
>  create mode 100644 gdb/testsuite/gdb.arch/aarch64-sme-sanity.exp
>  create mode 100644 gdb/testsuite/lib/aarch64-test-sme.c
>  create mode 100644 gdb/testsuite/lib/aarch64-test-sve.c
>  create mode 100644 gdb/testsuite/lib/aarch64.exp
>
  
Thiago Jung Bauermann Aug. 4, 2023, 9:24 p.m. UTC | #2
Luis Machado via Gdb-patches <gdb-patches@sourceware.org> writes:

> The following series enables SME 1 (Scalable Matrix Extension) support for
> AArch64 gdb and gdbserver.
>
> SME expands on SVE by having a variable-sized matrix (ZA) of dimensions
> SVL x SVL bytes.
>
> The first few patches and some intermediate ones refactor the code and fix
> issues prior to enabling SME support, and thus could go in independently.
>
> I've kept them in the series as they are closely/logically related.
>
> --
>
> Luis Machado (16):
>   [gdb/aarch64] Fix register fetch/store order for native AArch64 Linux
>   [gdb/aarch64] refactor: Rename SVE-specific files
>   [gdb/gdbserver] refactor: Simplify SVE interface to read/write
>     registers
>   [gdb/aarch64] sve: Fix return command when using V registers in a
>     SVE-enabled target
>   [gdb/aarch64] sme: Enable SME registers and pseudo-registers
>   [gdbserver/aarch64] refactor: Adjust expedited registers dynamically
>   [gdbserver/aarch64] sme: Add support for SME
>   [gdb/aarch64] sve: Fix signal frame z/v register restore
>   [gdb/aarch64] sme: Signal frame support
>   [gdb/aarch64] sme: Fixup sigframe gdbarch when vg/svg changes
>   [gdb/aarch64] sme: Support TPIDR2 signal frame context
>   [gdb/generic] corefile/bug: Use thread-specific gdbarch when dumping
>     register state to core files
>   [gdb/generic] corefile/bug: Fixup (gcore) core file target description
>     reading order
>   [gdb/aarch64] sme: Core file support for Linux
>   [gdb/testsuite] sme: Add SVE/SME testcases
>   [gdb/docs] sme: Document SME registers and features

Thank you for these patches!

I finished reviewing them. I don't have comments on the patches I
haven't replied to.

Reviewed-by: Thiago Jung Bauermann <thiago.bauermann@linaro.org>