Message ID | 20230511144832.17974-1-simon.marchi@efficios.com |
---|---|
Headers |
Return-Path: <gdb-patches-bounces+patchwork=sourceware.org@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 26EDE3856275 for <patchwork@sourceware.org>; Thu, 11 May 2023 14:49:00 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 26EDE3856275 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1683816540; bh=Pn/2aAK/HbTefWiJOgDTDNjytA8N3C5tARYRUbE13b0=; h=To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=Zsr8laxqOONlC12D65r7EWE3Nj+7Cq+37gY5wAl3kia2jetpQwJ11NdeEWjkkgzaT zuResKkhxvwkHSYWaU4poe4+vEA/R1rek9HHTFcvPR++R4OLGgkUkGS9ts2XdQrHyE KlveF79JlPNvILDvDPh+TcdgjLbw1bpvltknyF5c= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 0EC583858C5F for <gdb-patches@sourceware.org>; Thu, 11 May 2023 14:48:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0EC583858C5F Received: from smarchi-efficios.internal.efficios.com (192-222-143-198.qc.cable.ebox.net [192.222.143.198]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 9539B1E114; Thu, 11 May 2023 10:48:33 -0400 (EDT) To: gdb-patches@sourceware.org Cc: Simon Marchi <simon.marchi@efficios.com> Subject: [PATCH 00/12] Use intrusive_list for breakpoints and breakpoint locations Date: Thu, 11 May 2023 10:48:20 -0400 Message-Id: <20230511144832.17974-1-simon.marchi@efficios.com> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3491.2 required=5.0 tests=BAYES_00, KAM_DMARC_NONE, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_SOFTFAIL, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org> List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>, <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/gdb-patches/> List-Post: <mailto:gdb-patches@sourceware.org> List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help> List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>, <mailto:gdb-patches-request@sourceware.org?subject=subscribe> From: Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> Reply-To: Simon Marchi <simon.marchi@efficios.com> Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" <gdb-patches-bounces+patchwork=sourceware.org@sourceware.org> |
Series |
Use intrusive_list for breakpoints and breakpoint locations
|
|
Message
Simon Marchi
May 11, 2023, 2:48 p.m. UTC
This series changes two linked lists to use intrusive_list. There are some cleanups before that, and some small fixes that needed to be made to some of our iterator wrappers. Simon Marchi (12): gdb: get gdbarch from syscall_catchpoint instead of location gdb: make some breakpoint methods use `this` gdb: constify breakpoint::print_it parameter gdb: add breakpoint "has locations" methods gdb: add breakpoint::first_loc methods gdbsupport: add missing increment/decrement operators to reference_to_pointer_iterator gdb: link breakpoint locations with intrusive_list gdb: remove bp_location_pointer_iterator gdb: link breakpoints with intrusive_list gdbsupport: make basic_safe_iterator::operator* return the same thing as underlying iterator gdbsupport: make filtered_iterator::operator* return the same thing as underlying iterator gdb: remove breakpoint_pointer_iterator gdb/ada-lang.c | 20 +- gdb/break-catch-exec.c | 4 +- gdb/break-catch-fork.c | 4 +- gdb/break-catch-load.c | 25 +- gdb/break-catch-sig.c | 4 +- gdb/break-catch-syscall.c | 21 +- gdb/break-catch-throw.c | 10 +- gdb/breakpoint.c | 1225 ++++++++++---------- gdb/breakpoint.h | 104 +- gdb/dummy-frame.c | 4 +- gdb/elfread.c | 8 +- gdb/guile/scm-breakpoint.c | 4 +- gdb/infrun.c | 11 +- gdb/jit.c | 6 +- gdb/python/py-breakpoint.c | 8 +- gdb/python/py-finishbreakpoint.c | 8 +- gdb/remote.c | 4 +- gdb/solib-svr4.c | 10 +- gdb/tracectf.c | 4 +- gdb/tracefile-tfile.c | 4 +- gdb/tracefile.c | 6 +- gdb/tracepoint.c | 108 +- gdb/tui/tui-winsource.c | 16 +- gdbsupport/filtered-iterator.h | 7 +- gdbsupport/reference-to-pointer-iterator.h | 18 + gdbsupport/safe-iterator.h | 6 +- 26 files changed, 848 insertions(+), 801 deletions(-)
Comments
Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes: > This series changes two linked lists to use intrusive_list. There are > some cleanups before that, and some small fixes that needed to be made > to some of our iterator wrappers. I took a look through and left a few comments, but otherwise, this looks great. I also ran the testsuite locally, and saw no regressions. Reviewed-By: Andrew Burgess <aburgess@redhat.com> Thanks, Andrew > > Simon Marchi (12): > gdb: get gdbarch from syscall_catchpoint instead of location > gdb: make some breakpoint methods use `this` > gdb: constify breakpoint::print_it parameter > gdb: add breakpoint "has locations" methods > gdb: add breakpoint::first_loc methods > gdbsupport: add missing increment/decrement operators to > reference_to_pointer_iterator > gdb: link breakpoint locations with intrusive_list > gdb: remove bp_location_pointer_iterator > gdb: link breakpoints with intrusive_list > gdbsupport: make basic_safe_iterator::operator* return the same thing > as underlying iterator > gdbsupport: make filtered_iterator::operator* return the same thing as > underlying iterator > gdb: remove breakpoint_pointer_iterator > > gdb/ada-lang.c | 20 +- > gdb/break-catch-exec.c | 4 +- > gdb/break-catch-fork.c | 4 +- > gdb/break-catch-load.c | 25 +- > gdb/break-catch-sig.c | 4 +- > gdb/break-catch-syscall.c | 21 +- > gdb/break-catch-throw.c | 10 +- > gdb/breakpoint.c | 1225 ++++++++++---------- > gdb/breakpoint.h | 104 +- > gdb/dummy-frame.c | 4 +- > gdb/elfread.c | 8 +- > gdb/guile/scm-breakpoint.c | 4 +- > gdb/infrun.c | 11 +- > gdb/jit.c | 6 +- > gdb/python/py-breakpoint.c | 8 +- > gdb/python/py-finishbreakpoint.c | 8 +- > gdb/remote.c | 4 +- > gdb/solib-svr4.c | 10 +- > gdb/tracectf.c | 4 +- > gdb/tracefile-tfile.c | 4 +- > gdb/tracefile.c | 6 +- > gdb/tracepoint.c | 108 +- > gdb/tui/tui-winsource.c | 16 +- > gdbsupport/filtered-iterator.h | 7 +- > gdbsupport/reference-to-pointer-iterator.h | 18 + > gdbsupport/safe-iterator.h | 6 +- > 26 files changed, 848 insertions(+), 801 deletions(-) > > -- > 2.40.1
On 5/18/23 11:54, Andrew Burgess via Gdb-patches wrote: > Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes: > >> This series changes two linked lists to use intrusive_list. There are >> some cleanups before that, and some small fixes that needed to be made >> to some of our iterator wrappers. > > I took a look through and left a few comments, but otherwise, this looks > great. > > I also ran the testsuite locally, and saw no regressions. > > Reviewed-By: Andrew Burgess <aburgess@redhat.com> Thanks for reviewing. Since the adjustments were mostly trivial, I will push the modified version of this series once the checked_static_cast for references patches (or an equivalent) is in. Simon
On 5/18/23 17:01, Simon Marchi via Gdb-patches wrote: > On 5/18/23 11:54, Andrew Burgess via Gdb-patches wrote: >> Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes: >> >>> This series changes two linked lists to use intrusive_list. There are >>> some cleanups before that, and some small fixes that needed to be made >>> to some of our iterator wrappers. >> >> I took a look through and left a few comments, but otherwise, this looks >> great. >> >> I also ran the testsuite locally, and saw no regressions. >> >> Reviewed-By: Andrew Burgess <aburgess@redhat.com> > > Thanks for reviewing. Since the adjustments were mostly trivial, I will > push the modified version of this series once the checked_static_cast > for references patches (or an equivalent) is in. I pushed this. Simon