mbox series

[0/3] Minor expression cleanups

Message ID 20230428-minor-expr-cleanuups-v1-0-0a634e8d5c25@adacore.com
Headers
Series Minor expression cleanups |

Message

Tom Tromey April 28, 2023, 4:02 p.m. UTC 
  While looking at some parser-related changes for DAP, I found a few
things that could be cleaned up independently.

Regression tested on x86-64 Fedora 36.

---
Tom Tromey (3):
      Remove op_name
      Remove evaluate_expression
      Remove evaluate_type

 gdb/ada-lang.c        |  4 ++--
 gdb/arc-tdep.c        |  2 +-
 gdb/breakpoint.c      |  2 +-
 gdb/cli/cli-script.c  |  4 ++--
 gdb/darwin-nat-info.c |  2 +-
 gdb/dtrace-probe.c    |  4 ++--
 gdb/eval.c            | 25 ++++---------------------
 gdb/expprint.c        | 41 +++++++++++++++++------------------------
 gdb/expression.h      | 12 +++++++-----
 gdb/gnu-v3-abi.c      |  2 +-
 gdb/linux-thread-db.c |  2 +-
 gdb/mi/mi-main.c      |  6 +++---
 gdb/objc-lang.c       |  4 +---
 gdb/printcmd.c        | 12 ++++++------
 gdb/stack.c           |  2 +-
 gdb/stap-probe.c      |  2 +-
 gdb/tracepoint.c      |  2 +-
 gdb/typeprint.c       |  4 ++--
 gdb/value.c           |  2 +-
 gdb/value.h           | 11 -----------
 gdb/varobj.c          | 14 +++++++-------
 21 files changed, 62 insertions(+), 97 deletions(-)
---
base-commit: 1f7f972f59470104734ec705c985ab319eb580db
change-id: 20230428-minor-expr-cleanuups-77d8f8d15594

Best regards,

Comments

Keith Seitz April 28, 2023, 4:14 p.m. UTC | #1 
On 4/28/23 09:02, Tom Tromey via Gdb-patches wrote:
> While looking at some parser-related changes for DAP, I found a few
> things that could be cleaned up independently.
> 
> Regression tested on x86-64 Fedora 36.

[Very] Nice cleanups. I've looked over the series, and it LGTM.

Keith

> ---
> Tom Tromey (3):
>        Remove op_name
>        Remove evaluate_expression
>        Remove evaluate_type
> 
>   gdb/ada-lang.c        |  4 ++--
>   gdb/arc-tdep.c        |  2 +-
>   gdb/breakpoint.c      |  2 +-
>   gdb/cli/cli-script.c  |  4 ++--
>   gdb/darwin-nat-info.c |  2 +-
>   gdb/dtrace-probe.c    |  4 ++--
>   gdb/eval.c            | 25 ++++---------------------
>   gdb/expprint.c        | 41 +++++++++++++++++------------------------
>   gdb/expression.h      | 12 +++++++-----
>   gdb/gnu-v3-abi.c      |  2 +-
>   gdb/linux-thread-db.c |  2 +-
>   gdb/mi/mi-main.c      |  6 +++---
>   gdb/objc-lang.c       |  4 +---
>   gdb/printcmd.c        | 12 ++++++------
>   gdb/stack.c           |  2 +-
>   gdb/stap-probe.c      |  2 +-
>   gdb/tracepoint.c      |  2 +-
>   gdb/typeprint.c       |  4 ++--
>   gdb/value.c           |  2 +-
>   gdb/value.h           | 11 -----------
>   gdb/varobj.c          | 14 +++++++-------
>   21 files changed, 62 insertions(+), 97 deletions(-)
> ---
> base-commit: 1f7f972f59470104734ec705c985ab319eb580db
> change-id: 20230428-minor-expr-cleanuups-77d8f8d15594
> 
> Best regards,
Tom Tromey May 1, 2023, 5:04 p.m. UTC | #2 
>> While looking at some parser-related changes for DAP, I found a few
>> things that could be cleaned up independently.
>> Regression tested on x86-64 Fedora 36.

Keith> [Very] Nice cleanups. I've looked over the series, and it LGTM.

Thanks, I'm going to check this in.

Tom