mbox series

[0/8,gdb/testsuite] Fix timeouts in TUI tests

Message ID 20230413140827.19412-1-tdevries@suse.de
Headers
Series Fix timeouts in TUI tests |

Message

Tom de Vries April 13, 2023, 2:08 p.m. UTC 
  Add a warning for timeout in accept_gdb_output.

With the current state, that gives the following warnings:
...
Running gdb.tui/regs.exp ...
Running gdb.tui/resize.exp ...
Running gdb.tui/tui-nl-filtered-output.exp ...
Running gdb.python/tui-window-factory.exp ...
Running gdb.tui/break.exp ...
Running gdb.tui/new-layout.exp ...
WARNING: timeout in accept_gdb_output
Running gdb.tui/winwidth.exp ...
Running gdb.tui/tui-focus.exp ...
Running gdb.tui/info-win.exp ...
Running gdb.python/tui-window-names.exp ...
Running gdb.tui/tuiterm.exp ...
Running gdb.tui/basic.exp ...
Running gdb.tui/completion.exp ...
WARNING: timeout in accept_gdb_output
Running gdb.tui/tui-layout-asm.exp ...
Running gdb.tui/corefile-run.exp ...
WARNING: timeout in accept_gdb_output
Running gdb.python/tui-window-disabled.exp ...
Running gdb.tui/list-before.exp ...
Running gdb.tui/list.exp ...
Running gdb.tui/tui-layout.exp ...
Running gdb.tui/tui-layout-asm-short-prog.exp ...
Running gdb.tui/tui-disasm-long-lines.exp ...
Running gdb.tui/main.exp ...
WARNING: timeout in accept_gdb_output
Running gdb.tui/tui-missing-src.exp ...
Running gdb.python/tui-window.exp ...
Running gdb.tui/winheight.exp ...
Running gdb.tui/scroll.exp ...
Running gdb.tui/empty.exp ...
WARNING: timeout in accept_gdb_output
...

This series fixes all the timeouts.

The series also proposes a fix for PR tui/30337, a problem I ran into while
fixing the timeout in gdb.tui/empty.exp.

The patches fixing gdb.tui/empty.exp and PR30337 could be merged, but I prefer
to keep them seperate, to allow the former to be backported without the latter.

Tested on x86_64-linux.

Tom de Vries (8):
  [gdb/testsuite] Add warning for timeout in accept_gdb_output
  [gdb/testsuite] Add debug prints in Term::wait_for
  [gdb/testsuite] Fix timeout in gdb.tui/corefile-run.exp
  [gdb/testsuite] Fix timeout in gdb.tui/main.exp
  [gdb/testsuite] Fix timeout in gdb.tui/new-layout.exp
  [gdb/testsuite] Fix timeout in gdb.tui/completion.exp
  [gdb/testsuite] Fix timeout in gdb.tui/empty.exp
  [gdb/tui] Fix TUI for TERM=ansi

 gdb/testsuite/gdb.tui/completion.exp   |  2 +-
 gdb/testsuite/gdb.tui/corefile-run.exp |  3 ++-
 gdb/testsuite/gdb.tui/main.exp         |  3 ++-
 gdb/testsuite/lib/tuiterm.exp          | 35 +++++++++++++++++++-------
 gdb/tui/tui-win.c                      |  3 +++
 gdb/utils.c                            |  9 +++++++
 gdb/utils.h                            |  7 ++++++
 7 files changed, 50 insertions(+), 12 deletions(-)


base-commit: 546c7898dccb204eb56c8ed7c5b707c75de31b53

Comments

Tom de Vries April 25, 2023, 6:35 a.m. UTC | #1 
On 4/13/23 16:08, Tom de Vries via Gdb-patches wrote:
>    [gdb/testsuite] Add warning for timeout in accept_gdb_output
>    [gdb/testsuite] Add debug prints in Term::wait_for
>    [gdb/testsuite] Fix timeout in gdb.tui/corefile-run.exp
>    [gdb/testsuite] Fix timeout in gdb.tui/main.exp
>    [gdb/testsuite] Fix timeout in gdb.tui/new-layout.exp
>    [gdb/testsuite] Fix timeout in gdb.tui/completion.exp
>    [gdb/testsuite] Fix timeout in gdb.tui/empty.exp
>    [gdb/tui] Fix TUI for TERM=ansi

I've committed all but the last, I'll do resubmission of that one.

Thanks,
- Tom