mbox series

[0/2] Two minor dynamic property fixes

Message ID 20230301-submit-baton-stuff-v1-0-567d536a8245@adacore.com
Headers
Series Two minor dynamic property fixes |

Message

Tom Tromey March 1, 2023, 3:18 p.m. UTC 
  I noticed that dynamic properties were not type-safe or const-correct.
These two patches fix this.  Tested by rebuilding.

Tom

---
Tom Tromey (2):
      Make gdb property batons type-safe
      Use const for dwarf2_property_baton

 gdb/dwarf2/loc.c | 14 +++++---------
 gdb/dwarf2/loc.h |  2 +-
 gdb/gdbtypes.h   | 11 ++++++-----
 3 files changed, 12 insertions(+), 15 deletions(-)
---
base-commit: 2c29b1ed19711fa2a16558015e5a6b46a09aefeb
change-id: 20230301-submit-baton-stuff-70d3db0cd50b

Best regards,

Comments

Simon Marchi March 1, 2023, 6:45 p.m. UTC | #1 
On 3/1/23 10:18, Tom Tromey via Gdb-patches wrote:
> I noticed that dynamic properties were not type-safe or const-correct.
> These two patches fix this.  Tested by rebuilding.
> 
> Tom
> 
> ---
> Tom Tromey (2):
>       Make gdb property batons type-safe
>       Use const for dwarf2_property_baton
> 
>  gdb/dwarf2/loc.c | 14 +++++---------
>  gdb/dwarf2/loc.h |  2 +-
>  gdb/gdbtypes.h   | 11 ++++++-----
>  3 files changed, 12 insertions(+), 15 deletions(-)
> ---
> base-commit: 2c29b1ed19711fa2a16558015e5a6b46a09aefeb
> change-id: 20230301-submit-baton-stuff-70d3db0cd50b
> 
> Best regards,
> -- 
> Tom Tromey <tromey@adacore.com>
> 

I sent a general design question on patch 1, but otherwise:

Approved-By: Simon Marchi <simon.marchi@efficios.com>

Simon