mbox series

[0/5] Some target_desc_info cleanups

Message ID 20230203142126.286866-1-simon.marchi@polymtl.ca
Headers
Series Some target_desc_info cleanups |

Message

Simon Marchi Feb. 3, 2023, 2:21 p.m. UTC 
  While reviewing another series, I noticed some things about
target_desc_info that could be cleanup or simplified.

Simon Marchi (5):
  gdb: move target_desc_info to inferior.h
  gdb: change inferior::tdesc_info to non-pointer
  gdb: remove get_tdesc_info
  gdb: remove copy_inferior_target_desc_info
  gdb: make target_desc_info_from_user_p a method of target_desc_info

 gdb/inferior.c            |  7 +---
 gdb/inferior.h            | 30 ++++++++++++++-
 gdb/infrun.c              |  4 +-
 gdb/target-descriptions.c | 81 ++++-----------------------------------
 gdb/target-descriptions.h | 19 ---------
 5 files changed, 41 insertions(+), 100 deletions(-)


base-commit: e3ee979c1f24984eb93b32822338aa425afbc2af

Comments

Andrew Burgess Feb. 3, 2023, 3:56 p.m. UTC | #1 
Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:

> While reviewing another series, I noticed some things about
> target_desc_info that could be cleanup or simplified.

Took a look through the series.  Everything looks like a good cleanup to
me.

Thanks,
Andrew

>
> Simon Marchi (5):
>   gdb: move target_desc_info to inferior.h
>   gdb: change inferior::tdesc_info to non-pointer
>   gdb: remove get_tdesc_info
>   gdb: remove copy_inferior_target_desc_info
>   gdb: make target_desc_info_from_user_p a method of target_desc_info
>
>  gdb/inferior.c            |  7 +---
>  gdb/inferior.h            | 30 ++++++++++++++-
>  gdb/infrun.c              |  4 +-
>  gdb/target-descriptions.c | 81 ++++-----------------------------------
>  gdb/target-descriptions.h | 19 ---------
>  5 files changed, 41 insertions(+), 100 deletions(-)
>
>
> base-commit: e3ee979c1f24984eb93b32822338aa425afbc2af
> -- 
> 2.39.1
Simon Marchi Feb. 3, 2023, 4:07 p.m. UTC | #2 
On 2/3/23 10:56, Andrew Burgess wrote:
> Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:
> 
>> While reviewing another series, I noticed some things about
>> target_desc_info that could be cleanup or simplified.
> 
> Took a look through the series.  Everything looks like a good cleanup to
> me.

Thanks, will push.

Simon