Message ID | 20221107161333.16999-1-tdevries@suse.de |
---|---|
Headers |
Return-Path: <gdb-patches-bounces+patchwork=sourceware.org@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B1C843858295 for <patchwork@sourceware.org>; Mon, 7 Nov 2022 16:14:00 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B1C843858295 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1667837640; bh=2G2t/8NY8moCp2b7a+liEjT7pE0Uo81EaNP508mIXxQ=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=ACIlPwu7xC2wHymgiJ/9YALyHSmqKafn7NX5mpGDrDpQfO1uZ+Wu+J59HyCLD4/FY vCuqAUlonMEyi9OYXuycZ8RAZjhTkFxiNUIu1qQxkvD1hoAEvNQMIRCuyQio+hGJS5 G6wMq/fxE9c4nTiXHNtyl/vvmr+WVTTDtrXR/UDQ= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id A94F23858D20 for <gdb-patches@sourceware.org>; Mon, 7 Nov 2022 16:13:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A94F23858D20 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id DAD051F383 for <gdb-patches@sourceware.org>; Mon, 7 Nov 2022 16:13:33 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C772513494 for <gdb-patches@sourceware.org>; Mon, 7 Nov 2022 16:13:33 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id CiF1L60uaWPsTwAAMHmgww (envelope-from <tdevries@suse.de>) for <gdb-patches@sourceware.org>; Mon, 07 Nov 2022 16:13:33 +0000 To: gdb-patches@sourceware.org Subject: [PATCH 0/9] [gdb/testsuite] Fix remote target test fails Date: Mon, 7 Nov 2022 17:13:24 +0100 Message-Id: <20221107161333.16999-1-tdevries@suse.de> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org> List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>, <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/gdb-patches/> List-Post: <mailto:gdb-patches@sourceware.org> List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help> List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>, <mailto:gdb-patches-request@sourceware.org?subject=subscribe> From: Tom de Vries via Gdb-patches <gdb-patches@sourceware.org> Reply-To: Tom de Vries <tdevries@suse.de> Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" <gdb-patches-bounces+patchwork=sourceware.org@sourceware.org> |
Series |
Fix remote target test fails
|
|
Message
Tom de Vries
Nov. 7, 2022, 4:13 p.m. UTC
Fix testsuite failures with target board remote-gdbserver-on-localhost. This is a follow-up on the proposed patch series https://sourceware.org/pipermail/gdb-patches/2022-October/193147.html by Ivan Tetyushkin. I started from scratch, but borrowed from the original series, so I've marked that by using co-authored-by. This patch series takes a different approach than the original proposal: rather than trying to construct absolute file names that will work on the remote target, make things work with the names as returned by remote_download. One of the fixes is to add a REMOTE_TARGET_USERNAME parameter to the target board, such that we can limit file permissions to get a more realistic emulation of an actual remote target, and this allows us to reproduce the failures reported by Ivan. Tested on x86_64-linux, using target board remote-gdbserver-on-localhost. Tom de Vries (9): [gdb/testsuite] Fix gdb.base/foll-exec.exp for remote target [gdb/testsuite] Fix gdb.base/info_sources_2.exp for remote target [gdb/testsuite] Add REMOTE_TARGET_USERNAME in remote-gdbserver-on-localhost.exp [gdb/testsuite] Fix gdb.base/print-file-var.exp for remote target [gdb/testsuite] Fix gdb.base/infcall-exec.exp for remote target [gdb/testsuite] Fix gdb.base/solib-vanish.exp for remote target [gdb/testsuite] Fix gdb.base/info-shared.exp for remote target [gdb/testsuite] Fix gdb.base/jit-reader-exec.exp for remote target [gdb/testsuite] Fix gdb.base/jit-elf-so.exp for remote target .../boards/remote-gdbserver-on-localhost.exp | 30 +++++++++++- .../gdb.base/exec-invalid-sysroot.exp | 4 ++ gdb/testsuite/gdb.base/foll-exec.exp | 4 ++ gdb/testsuite/gdb.base/foll-vfork.exp | 4 ++ gdb/testsuite/gdb.base/infcall-exec.c | 48 ++++++++++++++++++- gdb/testsuite/gdb.base/infcall-exec.exp | 10 +++- gdb/testsuite/gdb.base/info-shared.exp | 11 ++++- gdb/testsuite/gdb.base/info_sources_2.exp | 12 +++++ gdb/testsuite/gdb.base/jit-elf-so.exp | 11 +++-- gdb/testsuite/gdb.base/jit-reader-exec.exp | 14 ++++-- gdb/testsuite/gdb.base/print-file-var.exp | 6 ++- gdb/testsuite/gdb.base/solib-vanish.exp | 17 +++++-- gdb/testsuite/lib/gdb.exp | 40 ++++++++++------ 13 files changed, 174 insertions(+), 37 deletions(-) base-commit: 8bfb6941c358ee2da8320125644c59bf90842f6b
Comments
On 11/7/22 17:13, Tom de Vries via Gdb-patches wrote: > Fix testsuite failures with target board remote-gdbserver-on-localhost. > > This is a follow-up on the proposed patch series > https://sourceware.org/pipermail/gdb-patches/2022-October/193147.html by > Ivan Tetyushkin. I started from scratch, but borrowed from the original > series, so I've marked that by using co-authored-by. > > This patch series takes a different approach than the original proposal: > rather than trying to construct absolute file names that will work on the > remote target, make things work with the names as returned by remote_download. > > One of the fixes is to add a REMOTE_TARGET_USERNAME parameter to the target > board, such that we can limit file permissions to get a more realistic > emulation of an actual remote target, and this allows us to reproduce the > failures reported by Ivan. > > Tested on x86_64-linux, using target board remote-gdbserver-on-localhost. > Pushed. Thanks, - Tom > Tom de Vries (9): > [gdb/testsuite] Fix gdb.base/foll-exec.exp for remote target > [gdb/testsuite] Fix gdb.base/info_sources_2.exp for remote target > [gdb/testsuite] Add REMOTE_TARGET_USERNAME in > remote-gdbserver-on-localhost.exp > [gdb/testsuite] Fix gdb.base/print-file-var.exp for remote target > [gdb/testsuite] Fix gdb.base/infcall-exec.exp for remote target > [gdb/testsuite] Fix gdb.base/solib-vanish.exp for remote target > [gdb/testsuite] Fix gdb.base/info-shared.exp for remote target > [gdb/testsuite] Fix gdb.base/jit-reader-exec.exp for remote target > [gdb/testsuite] Fix gdb.base/jit-elf-so.exp for remote target > > .../boards/remote-gdbserver-on-localhost.exp | 30 +++++++++++- > .../gdb.base/exec-invalid-sysroot.exp | 4 ++ > gdb/testsuite/gdb.base/foll-exec.exp | 4 ++ > gdb/testsuite/gdb.base/foll-vfork.exp | 4 ++ > gdb/testsuite/gdb.base/infcall-exec.c | 48 ++++++++++++++++++- > gdb/testsuite/gdb.base/infcall-exec.exp | 10 +++- > gdb/testsuite/gdb.base/info-shared.exp | 11 ++++- > gdb/testsuite/gdb.base/info_sources_2.exp | 12 +++++ > gdb/testsuite/gdb.base/jit-elf-so.exp | 11 +++-- > gdb/testsuite/gdb.base/jit-reader-exec.exp | 14 ++++-- > gdb/testsuite/gdb.base/print-file-var.exp | 6 ++- > gdb/testsuite/gdb.base/solib-vanish.exp | 17 +++++-- > gdb/testsuite/lib/gdb.exp | 40 ++++++++++------ > 13 files changed, 174 insertions(+), 37 deletions(-) > > > base-commit: 8bfb6941c358ee2da8320125644c59bf90842f6b