[0/9,gdb/testsuite] Fix remote target test fails

Message ID 20221107161333.16999-1-tdevries@suse.de
Headers
Series Fix remote target test fails |

Message

Tom de Vries Nov. 7, 2022, 4:13 p.m. UTC
  Fix testsuite failures with target board remote-gdbserver-on-localhost.

This is a follow-up on the proposed patch series
https://sourceware.org/pipermail/gdb-patches/2022-October/193147.html by
Ivan Tetyushkin.  I started from scratch, but borrowed from the original
series, so I've marked that by using co-authored-by.

This patch series takes a different approach than the original proposal:
rather than trying to construct absolute file names that will work on the
remote target, make things work with the names as returned by remote_download.

One of the fixes is to add a REMOTE_TARGET_USERNAME parameter to the target
board, such that we can limit file permissions to get a more realistic
emulation of an actual remote target, and this allows us to reproduce the
failures reported by Ivan.

Tested on x86_64-linux, using target board remote-gdbserver-on-localhost.

Tom de Vries (9):
  [gdb/testsuite] Fix gdb.base/foll-exec.exp for remote target
  [gdb/testsuite] Fix gdb.base/info_sources_2.exp for remote target
  [gdb/testsuite] Add REMOTE_TARGET_USERNAME in
    remote-gdbserver-on-localhost.exp
  [gdb/testsuite] Fix gdb.base/print-file-var.exp for remote target
  [gdb/testsuite] Fix gdb.base/infcall-exec.exp for remote target
  [gdb/testsuite] Fix gdb.base/solib-vanish.exp for remote target
  [gdb/testsuite] Fix gdb.base/info-shared.exp for remote target
  [gdb/testsuite] Fix gdb.base/jit-reader-exec.exp for remote target
  [gdb/testsuite] Fix gdb.base/jit-elf-so.exp for remote target

 .../boards/remote-gdbserver-on-localhost.exp  | 30 +++++++++++-
 .../gdb.base/exec-invalid-sysroot.exp         |  4 ++
 gdb/testsuite/gdb.base/foll-exec.exp          |  4 ++
 gdb/testsuite/gdb.base/foll-vfork.exp         |  4 ++
 gdb/testsuite/gdb.base/infcall-exec.c         | 48 ++++++++++++++++++-
 gdb/testsuite/gdb.base/infcall-exec.exp       | 10 +++-
 gdb/testsuite/gdb.base/info-shared.exp        | 11 ++++-
 gdb/testsuite/gdb.base/info_sources_2.exp     | 12 +++++
 gdb/testsuite/gdb.base/jit-elf-so.exp         | 11 +++--
 gdb/testsuite/gdb.base/jit-reader-exec.exp    | 14 ++++--
 gdb/testsuite/gdb.base/print-file-var.exp     |  6 ++-
 gdb/testsuite/gdb.base/solib-vanish.exp       | 17 +++++--
 gdb/testsuite/lib/gdb.exp                     | 40 ++++++++++------
 13 files changed, 174 insertions(+), 37 deletions(-)


base-commit: 8bfb6941c358ee2da8320125644c59bf90842f6b
  

Comments

Tom de Vries Nov. 15, 2022, 2:30 p.m. UTC | #1
On 11/7/22 17:13, Tom de Vries via Gdb-patches wrote:
> Fix testsuite failures with target board remote-gdbserver-on-localhost.
> 
> This is a follow-up on the proposed patch series
> https://sourceware.org/pipermail/gdb-patches/2022-October/193147.html by
> Ivan Tetyushkin.  I started from scratch, but borrowed from the original
> series, so I've marked that by using co-authored-by.
> 
> This patch series takes a different approach than the original proposal:
> rather than trying to construct absolute file names that will work on the
> remote target, make things work with the names as returned by remote_download.
> 
> One of the fixes is to add a REMOTE_TARGET_USERNAME parameter to the target
> board, such that we can limit file permissions to get a more realistic
> emulation of an actual remote target, and this allows us to reproduce the
> failures reported by Ivan.
> 
> Tested on x86_64-linux, using target board remote-gdbserver-on-localhost.
> 

Pushed.

Thanks,
- Tom

> Tom de Vries (9):
>    [gdb/testsuite] Fix gdb.base/foll-exec.exp for remote target
>    [gdb/testsuite] Fix gdb.base/info_sources_2.exp for remote target
>    [gdb/testsuite] Add REMOTE_TARGET_USERNAME in
>      remote-gdbserver-on-localhost.exp
>    [gdb/testsuite] Fix gdb.base/print-file-var.exp for remote target
>    [gdb/testsuite] Fix gdb.base/infcall-exec.exp for remote target
>    [gdb/testsuite] Fix gdb.base/solib-vanish.exp for remote target
>    [gdb/testsuite] Fix gdb.base/info-shared.exp for remote target
>    [gdb/testsuite] Fix gdb.base/jit-reader-exec.exp for remote target
>    [gdb/testsuite] Fix gdb.base/jit-elf-so.exp for remote target
> 
>   .../boards/remote-gdbserver-on-localhost.exp  | 30 +++++++++++-
>   .../gdb.base/exec-invalid-sysroot.exp         |  4 ++
>   gdb/testsuite/gdb.base/foll-exec.exp          |  4 ++
>   gdb/testsuite/gdb.base/foll-vfork.exp         |  4 ++
>   gdb/testsuite/gdb.base/infcall-exec.c         | 48 ++++++++++++++++++-
>   gdb/testsuite/gdb.base/infcall-exec.exp       | 10 +++-
>   gdb/testsuite/gdb.base/info-shared.exp        | 11 ++++-
>   gdb/testsuite/gdb.base/info_sources_2.exp     | 12 +++++
>   gdb/testsuite/gdb.base/jit-elf-so.exp         | 11 +++--
>   gdb/testsuite/gdb.base/jit-reader-exec.exp    | 14 ++++--
>   gdb/testsuite/gdb.base/print-file-var.exp     |  6 ++-
>   gdb/testsuite/gdb.base/solib-vanish.exp       | 17 +++++--
>   gdb/testsuite/lib/gdb.exp                     | 40 ++++++++++------
>   13 files changed, 174 insertions(+), 37 deletions(-)
> 
> 
> base-commit: 8bfb6941c358ee2da8320125644c59bf90842f6b