sra: Fix the fix for PR 102505 (PR 102886)

Message ID
State Committed
Commit f217e87972a2a207e793101fc05cfc9dd095c678
Series sra: Fix the fix for PR 102505 (PR 102886) |

Commit Message

Martin Jambor Oct. 22, 2021, 5:50 p.m. UTC

I was not careful with the fix for PR 102505 and did not craft the
check to satisfy the verifier carefully, which lead to PR 102886.
(The verifier has the test structured differently and somewhat
redundantly, so I could not just copy it).

This patch fixes it.  I hope it is quite obvious correction of an
oversight and so will commit it if survives bootstrap and testing on
x86_64-linux and ppc64le-linux.

Testcase for this bug is gcc.dg/tree-ssa/sra-18.c (but only on
platforms with constant pools).  I will backport the two fixes
to the release branches squashed.

Sorry for the stupid mistake,



2021-10-22  Martin Jambor  <>

	PR tree-optimization/102886
	* tree-sra.c (totally_scalarize_subtree): Fix the out of
 gcc/tree-sra.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


diff --git a/gcc/tree-sra.c b/gcc/tree-sra.c
index f561e1a2133..76e3aae405c 100644
--- a/gcc/tree-sra.c
+++ b/gcc/tree-sra.c
@@ -3288,7 +3288,7 @@  totally_scalarize_subtree (struct access *root)
 	    HOST_WIDE_INT pos = root->offset + int_bit_position (fld);
-	    if (pos + fsize > root->size)
+	    if (pos + fsize > root->offset + root->size)
 	      return false;
 	    enum total_sra_field_state
 	      state = total_should_skip_creating_access (root,