Message ID | orlevp91zp.fsf@lxoliva.fsfla.org |
---|---|
State | Committed |
Commit | 404edfce683cb1801b052ee7c8d45d603c392e08 |
Headers |
Return-Path: <gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 182743857831 for <patchwork@sourceware.org>; Thu, 28 Apr 2022 06:06:13 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 182743857831 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1651125973; bh=65CxgVaLGWllMwXM4fbZsVdfhkZk3r9QUE4kxkjEqDU=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=afZMCZEDKyeTI0Y5ONlMGdqvw1BeeJ67Q+BQj10bYf2tawY/Htv2zchPSONWdVv+A 5pQo9KKMC7rCjiFbmXFaG4O3BwqRR0+eNhoH6LROO/Vnka9ZJiKc0yZKLfMI8HV2QH m9TQiofcoReVcWdBFlH3zuYR/3J4Geif5+YR4CyA= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from rock.gnat.com (rock.gnat.com [IPv6:2620:20:4000:0:a9e:1ff:fe9b:1d1]) by sourceware.org (Postfix) with ESMTPS id 5C0403858D1E for <gcc-patches@gcc.gnu.org>; Thu, 28 Apr 2022 06:05:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5C0403858D1E Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 6B02911621C; Thu, 28 Apr 2022 02:05:42 -0400 (EDT) X-Virus-Scanned: Debian amavisd-new at gnat.com X-Amavis-Alert: BAD HEADER SECTION, Duplicate header field: "Cc" Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id BWjqmcNOIPwZ; Thu, 28 Apr 2022 02:05:42 -0400 (EDT) Received: from free.home (tron.gnat.com [IPv6:2620:20:4000:0:46a8:42ff:fe0e:e294]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by rock.gnat.com (Postfix) with ESMTPS id 2ACC9116109; Thu, 28 Apr 2022 02:05:40 -0400 (EDT) Received: from livre (livre.home [172.31.160.2]) by free.home (8.15.2/8.15.2) with ESMTPS id 23S65Uq92550274 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 28 Apr 2022 03:05:31 -0300 To: gcc-patches@gcc.gnu.org Subject: [PATCH] testsuite: vect: update unaligned message Organization: Free thinker, does not speak for AdaCore Date: Thu, 28 Apr 2022 03:05:30 -0300 Message-ID: <orlevp91zp.fsf@lxoliva.fsfla.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.84 X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org> List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe> List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/> List-Post: <mailto:gcc-patches@gcc.gnu.org> List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help> List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe> From: Alexandre Oliva via Gcc-patches <gcc-patches@gcc.gnu.org> Reply-To: Alexandre Oliva <oliva@adacore.com> Cc: Richard Biener <rguenther@suse.de>, Zdenek Dvorak <ook@ucw.cz>, David Edelsohn <dje.gcc@gmail.com>, Segher Boessenkool <segher@kernel.crashing.org> Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" <gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org> |
Series |
testsuite: vect: update unaligned message
|
|
Commit Message
Alexandre Oliva
April 28, 2022, 6:05 a.m. UTC
gcc.dg/vect/costmodel/ppc/costmodel-vect-31a.c covers ppc variants that accept and reject misaligned accesses. The message that it expects for rejection was removed in the gcc-11 development cycle by commit r11-1969. The patch adjusted multiple tests to use the message introduced in r11-1945, but missed this one. Regstrapped on powerpc64el-linux-gnu. Ok to install? Also tested on x86_64-linux-gnu-x-ppc64-vx7r2 with gcc-11. Ok for gcc-11? for gcc/testsuite/ChangeLog * gcc.dg/vect/costmodel/ppc/costmodel-vect-31a.c: Update the expected message for the case in which unaligned accesses are not allowed. --- .../gcc.dg/vect/costmodel/ppc/costmodel-vect-31a.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On Thu, 28 Apr 2022, Alexandre Oliva wrote: > > gcc.dg/vect/costmodel/ppc/costmodel-vect-31a.c covers ppc variants > that accept and reject misaligned accesses. The message that it > expects for rejection was removed in the gcc-11 development cycle by > commit r11-1969. The patch adjusted multiple tests to use the message > introduced in r11-1945, but missed this one. > > Regstrapped on powerpc64el-linux-gnu. Ok to install? > > Also tested on x86_64-linux-gnu-x-ppc64-vx7r2 with gcc-11. Ok for > gcc-11? OK. > > for gcc/testsuite/ChangeLog > > * gcc.dg/vect/costmodel/ppc/costmodel-vect-31a.c: Update > the expected message for the case in which unaligned accesses > are not allowed. > --- > .../gcc.dg/vect/costmodel/ppc/costmodel-vect-31a.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gcc/testsuite/gcc.dg/vect/costmodel/ppc/costmodel-vect-31a.c b/gcc/testsuite/gcc.dg/vect/costmodel/ppc/costmodel-vect-31a.c > index 72b4930d9bbbe..c57f065cccdd6 100644 > --- a/gcc/testsuite/gcc.dg/vect/costmodel/ppc/costmodel-vect-31a.c > +++ b/gcc/testsuite/gcc.dg/vect/costmodel/ppc/costmodel-vect-31a.c > @@ -46,5 +46,5 @@ int main (void) > return main1 (); > } > > -/* { dg-final { scan-tree-dump-times "not vectorized: unsupported unaligned store" 1 "vect" { target { ! vect_hw_misalign } } } } */ > +/* { dg-final { scan-tree-dump-times "unsupported unaligned access" 1 "vect" { target { ! vect_hw_misalign } } } } */ > /* { dg-final { scan-tree-dump-times "vectorized 1 loops" 0 "vect" { target { ! vect_hw_misalign } } } } */ > >
On Apr 28, 2022, Richard Biener <rguenther@suse.de> wrote: > On Thu, 28 Apr 2022, Alexandre Oliva wrote: >> >> gcc.dg/vect/costmodel/ppc/costmodel-vect-31a.c covers ppc variants >> that accept and reject misaligned accesses. The message that it >> expects for rejection was removed in the gcc-11 development cycle by >> commit r11-1969. The patch adjusted multiple tests to use the message >> introduced in r11-1945, but missed this one. >> >> Regstrapped on powerpc64el-linux-gnu. Ok to install? >> >> Also tested on x86_64-linux-gnu-x-ppc64-vx7r2 with gcc-11. Ok for >> gcc-11? > OK. I checked it in the trunk so far, but I missed the gcc-12 branching. This is surely not critical for gcc-12, but it's so trivial that I wonder if I could install it in both gcc-12 and gcc-11 branches and forget about it, or wait until 12.1 is final. WDYT? >> for gcc/testsuite/ChangeLog >> >> * gcc.dg/vect/costmodel/ppc/costmodel-vect-31a.c: Update >> the expected message for the case in which unaligned accesses >> are not allowed. >> -/* { dg-final { scan-tree-dump-times "not vectorized: unsupported unaligned store" 1 "vect" { target { ! vect_hw_misalign } } } } */ >> +/* { dg-final { scan-tree-dump-times "unsupported unaligned access" 1 "vect" { target { ! vect_hw_misalign } } } } */
On Mon, 2 May 2022, Alexandre Oliva wrote: > On Apr 28, 2022, Richard Biener <rguenther@suse.de> wrote: > > > On Thu, 28 Apr 2022, Alexandre Oliva wrote: > >> > >> gcc.dg/vect/costmodel/ppc/costmodel-vect-31a.c covers ppc variants > >> that accept and reject misaligned accesses. The message that it > >> expects for rejection was removed in the gcc-11 development cycle by > >> commit r11-1969. The patch adjusted multiple tests to use the message > >> introduced in r11-1945, but missed this one. > >> > >> Regstrapped on powerpc64el-linux-gnu. Ok to install? > >> > >> Also tested on x86_64-linux-gnu-x-ppc64-vx7r2 with gcc-11. Ok for > >> gcc-11? > > > OK. > > I checked it in the trunk so far, but I missed the gcc-12 branching. > This is surely not critical for gcc-12, but it's so trivial that I > wonder if I could install it in both gcc-12 and gcc-11 branches and > forget about it, or wait until 12.1 is final. WDYT? It's OK for the 12 branch now. Richard. > >> for gcc/testsuite/ChangeLog > >> > >> * gcc.dg/vect/costmodel/ppc/costmodel-vect-31a.c: Update > >> the expected message for the case in which unaligned accesses > >> are not allowed. > > >> -/* { dg-final { scan-tree-dump-times "not vectorized: unsupported unaligned store" 1 "vect" { target { ! vect_hw_misalign } } } } */ > >> +/* { dg-final { scan-tree-dump-times "unsupported unaligned access" 1 "vect" { target { ! vect_hw_misalign } } } } */ > > >
diff --git a/gcc/testsuite/gcc.dg/vect/costmodel/ppc/costmodel-vect-31a.c b/gcc/testsuite/gcc.dg/vect/costmodel/ppc/costmodel-vect-31a.c index 72b4930d9bbbe..c57f065cccdd6 100644 --- a/gcc/testsuite/gcc.dg/vect/costmodel/ppc/costmodel-vect-31a.c +++ b/gcc/testsuite/gcc.dg/vect/costmodel/ppc/costmodel-vect-31a.c @@ -46,5 +46,5 @@ int main (void) return main1 (); } -/* { dg-final { scan-tree-dump-times "not vectorized: unsupported unaligned store" 1 "vect" { target { ! vect_hw_misalign } } } } */ +/* { dg-final { scan-tree-dump-times "unsupported unaligned access" 1 "vect" { target { ! vect_hw_misalign } } } } */ /* { dg-final { scan-tree-dump-times "vectorized 1 loops" 0 "vect" { target { ! vect_hw_misalign } } } } */