Add OPTIONS_H_EXTRA to GTFILES

Message ID mpt35ccvwem.fsf@arm.com
State New
Headers
Series Add OPTIONS_H_EXTRA to GTFILES |

Commit Message

Richard Sandiford Sept. 28, 2022, 6:35 a.m. UTC
  I have a patch that adds a typedef to aarch64's <cpu>-opts.h.
The typedef is used for a TargetVariable in the .opt file,
which means that it is covered by PCH and so needs to be
visible to gengtype.

<cpu>-opts.h is not included directly in tm.h, but indirectly
by target headers (in this case aarch64.h).  There was therefore
nothing that caused it to be added to GTFILES.

Tested on aarch64-linux-gnu and x86_64-linux-gnu.  OK to install?

Richard


gcc/
	* Makefile.in (GTFILES): Add OPTIONS_H_EXTRA.
---
 gcc/Makefile.in | 1 +
 1 file changed, 1 insertion(+)
  

Comments

Jeff Law Sept. 28, 2022, 5:26 p.m. UTC | #1
On 9/28/22 00:35, Richard Sandiford via Gcc-patches wrote:
> I have a patch that adds a typedef to aarch64's <cpu>-opts.h.
> The typedef is used for a TargetVariable in the .opt file,
> which means that it is covered by PCH and so needs to be
> visible to gengtype.
>
> <cpu>-opts.h is not included directly in tm.h, but indirectly
> by target headers (in this case aarch64.h).  There was therefore
> nothing that caused it to be added to GTFILES.
>
> Tested on aarch64-linux-gnu and x86_64-linux-gnu.  OK to install?
>
> Richard
>
>
> gcc/
> 	* Makefile.in (GTFILES): Add OPTIONS_H_EXTRA.

OK

jeff
  

Patch

diff --git a/gcc/Makefile.in b/gcc/Makefile.in
index 59b67d99441..c1d04384399 100644
--- a/gcc/Makefile.in
+++ b/gcc/Makefile.in
@@ -2661,6 +2661,7 @@  s-match: build/genmatch$(build_exeext) $(srcdir)/match.pd cfn-operators.pd
 
 GTFILES = $(CPPLIB_H) $(srcdir)/input.h $(srcdir)/coretypes.h \
   $(host_xm_file_list) \
+  $(OPTIONS_H_EXTRA) \
   $(tm_file_list) $(HASHTAB_H) $(SPLAY_TREE_H) $(srcdir)/bitmap.h \
   $(srcdir)/wide-int.h $(srcdir)/alias.h \
   $(srcdir)/coverage.cc  $(srcdir)/rtl.h \