diff mbox series

gcc.c-torture/compile/103818.c: enable for llp64 too

Message ID f4ec9808-7f52-659f-7859-72573bb76263@gmail.com
State New
Headers
Series gcc.c-torture/compile/103818.c: enable for llp64 too |

Commit Message

Jonathan Yong Feb. 26, 2023, 6:38 a.m. UTC 
  Patch OK for master branch? I did not see any obvious issues to exclude 
LLP64 specifically.

Comments

Hans-Peter Nilsson Feb. 28, 2023, 2:10 a.m. UTC | #1 
On Sun, 26 Feb 2023, Jonathan Yong via Gcc-patches wrote:

> Patch OK for master branch? I did not see any obvious issues to exclude LLP64
> specifically.

I see "lp64 || lp64" in that patch (which should preferably have 
been sent inline, as it's harder to quote an attached patch, 
QED).  Sending the wrong version?  Don't forget to test it.

brgds, H-P
Jonathan Yong Feb. 28, 2023, 7:23 a.m. UTC | #2 
On 2/28/23 02:10, Hans-Peter Nilsson wrote:
> On Sun, 26 Feb 2023, Jonathan Yong via Gcc-patches wrote:
> 
>> Patch OK for master branch? I did not see any obvious issues to exclude LLP64
>> specifically.
> 
> I see "lp64 || lp64" in that patch (which should preferably have
> been sent inline, as it's harder to quote an attached patch,
> QED).  Sending the wrong version?  Don't forget to test it.
> 
> brgds, H-P

Corrected, previous patch was manually applied from a corrupted patch file.
Jeff Law March 11, 2023, 4:18 p.m. UTC | #3 
On 2/28/23 00:23, Jonathan Yong via Gcc-patches wrote:
> On 2/28/23 02:10, Hans-Peter Nilsson wrote:
>> On Sun, 26 Feb 2023, Jonathan Yong via Gcc-patches wrote:
>>
>>> Patch OK for master branch? I did not see any obvious issues to 
>>> exclude LLP64
>>> specifically.
>>
>> I see "lp64 || lp64" in that patch (which should preferably have
>> been sent inline, as it's harder to quote an attached patch,
>> QED).  Sending the wrong version?  Don't forget to test it.
>>
>> brgds, H-P
> 
> Corrected, previous patch was manually applied from a corrupted patch file.
> 
> 0004-gcc.c-torture-compile-103818.c-enable-for-llp64-too.patch
> 
>  From 52b1209193260a624f90c3ca759a83b975c2e8e0 Mon Sep 17 00:00:00 2001
> From: Jonathan Yong<10walls@gmail.com>
> Date: Sun, 26 Feb 2023 06:34:04 +0000
> Subject: [PATCH 4/7] gcc.c-torture/compile/103818.c: enable for llp64 too
> 
> gcc/testsuite/ChangeLog:
> 
> 	* gcc.c-torture/compile/103818.c: enable test for llp64.
This version is fine for the trunk.
jeff
diff mbox series

Patch

From 9c770936c4c6ffb59d15e5c1ce331494ba102250 Mon Sep 17 00:00:00 2001
From: Jonathan Yong <10walls@gmail.com>
Date: Sun, 26 Feb 2023 06:34:04 +0000
Subject: [PATCH] gcc.c-torture/compile/103818.c: enable for llp64 too

gcc/testsuite/ChangeLog:

	* gcc.c-torture/compile/103818.c: enable test for llp64.

Signed-off-by: Jonathan Yong <10walls@gmail.com>
---
 gcc/testsuite/gcc.c-torture/compile/103818.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gcc/testsuite/gcc.c-torture/compile/103818.c b/gcc/testsuite/gcc.c-torture/compile/103818.c
index e6cbe7860cf..63090534f4c 100644
--- a/gcc/testsuite/gcc.c-torture/compile/103818.c
+++ b/gcc/testsuite/gcc.c-torture/compile/103818.c
@@ -1,4 +1,4 @@ 
-/* { dg-do compile { target lp64 } } */
+/* { dg-do compile { target { lp64 || lp64 } } } */
 struct A { int b[1]; };
 
 void
-- 
2.39.2