Message ID | ZfsJeqtXuqMwmv8O@tucnak |
---|---|
State | New |
Headers |
Return-Path: <gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3C63F3857C6F for <patchwork@sourceware.org>; Wed, 20 Mar 2024 16:07:49 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id C42563858D1E for <gcc-patches@gcc.gnu.org>; Wed, 20 Mar 2024 16:06:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C42563858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C42563858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710950793; cv=none; b=Fjf0bYmquXPez5Hfj2cFAQNBDEKLUdzpOeM326Or6XgIYWOT8twZ/t2k/T+/gAHdcDWL1I892GLoTbPLP0fgi9scfDnVzdqyFf4tKoqWtvX/eQ7i8u+oW8NqJs77wW3mx0Ox1BONv921qqnSDkGzrx5cEV0PTAauvwjG0/0wigY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710950793; c=relaxed/simple; bh=m1UtkaaD91ebv6TFxzi/voK82r2cA6Ur0FmrP1ohDbg=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=XGC2l9rxx1Dqop4dVROuURxhTBqeQb2/4RH3v3uwLdC/fclBk1mLlGc3FzemSF101B6WBOwE6CcMoV3xrgkBc4jdHhVWkVZDsAU/y7ec8jZhK8HVCh1ONHpjxVYfsgUCBF1iPGpZpm74aO0xDbW5lzsempXwbNCHSmvcAfivQM4= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1710950787; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type; bh=6SiJLYccjr6iFrIq+4Rc4PvO206E6xM9iWAYwnpdrug=; b=T6e7G0g2hP8Nvq68PJ51oLrfNRYyjaOpS3lH04kGsNmdaSTVjm5Q50IwEKdDNaoKCCZgNT GNo+8U7aus4El/lFDg2QK/j2gfc2UxrM/NOlwottvEm5pznYCdfhDcsHhcM/lf3GS3rZnT LUpglzkC6RF2/BjoCTzGi1ciMhGwMY0= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-526-7UVlOT_7P2K_9h5lw8BsMw-1; Wed, 20 Mar 2024 12:06:25 -0400 X-MC-Unique: 7UVlOT_7P2K_9h5lw8BsMw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 73C7F2802279 for <gcc-patches@gcc.gnu.org>; Wed, 20 Mar 2024 16:06:25 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.57]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 35E6E112131D for <gcc-patches@gcc.gnu.org>; Wed, 20 Mar 2024 16:06:25 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 42KG6INx1166346 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT) for <gcc-patches@gcc.gnu.org>; Wed, 20 Mar 2024 17:06:19 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 42KG6InV1166345 for gcc-patches@gcc.gnu.org; Wed, 20 Mar 2024 17:06:18 +0100 Date: Wed, 20 Mar 2024 17:06:18 +0100 From: Jakub Jelinek <jakub@redhat.com> To: gcc-patches@gcc.gnu.org Subject: [committed] m32r: Fix up m32r_setup_incoming_varargs [PR114175] Message-ID: <ZfsJeqtXuqMwmv8O@tucnak> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org> List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe> List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/> List-Post: <mailto:gcc-patches@gcc.gnu.org> List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help> List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe> Reply-To: Jakub Jelinek <jakub@redhat.com> Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org |
Series |
[committed] m32r: Fix up m32r_setup_incoming_varargs [PR114175]
|
|
Checks
Context | Check | Description |
---|---|---|
linaro-tcwg-bot/tcwg_gcc_build--master-arm | fail | Patch failed to apply |
linaro-tcwg-bot/tcwg_gcc_build--master-aarch64 | fail | Patch failed to apply |
Commit Message
Jakub Jelinek
March 20, 2024, 4:06 p.m. UTC
Hi! Like for x86-64, alpha or rs6000, m32r seems to be affected too. Just visually checked differences in c23-stdarg-9.c assembly in a cross without/with the patch, committed to trunk. 2024-03-20 Jakub Jelinek <jakub@redhat.com> PR target/114175 * config/m32r/m32r.cc (m32r_setup_incoming_varargs): Only skip function arg advance for TYPE_NO_NAMED_ARGS_STDARG_P functions if arg.type is NULL. Jakub
Comments
On 3/20/24 10:06 AM, Jakub Jelinek wrote: > Hi! > > Like for x86-64, alpha or rs6000, m32r seems to be affected too. > > Just visually checked differences in c23-stdarg-9.c assembly in a cross > without/with the patch, committed to trunk. > That fixed c23-stdarg-{6,8,9} execution tests. jeff
On Wed, Mar 20, 2024 at 10:58:05AM -0600, Jeff Law wrote: > On 3/20/24 10:06 AM, Jakub Jelinek wrote: > > Like for x86-64, alpha or rs6000, m32r seems to be affected too. > > > > Just visually checked differences in c23-stdarg-9.c assembly in a cross > > without/with the patch, committed to trunk. > > > That fixed c23-stdarg-{6,8,9} execution tests. Thanks for these checks. All I've done with the remaining targets today (csky-linux epiphany-elf fr30-elf frv-linux ft32-elf m32r-elf mcore-elf mmix-knuth-mmixware nds32-linux nios2-linux sh-linux visium-elf) was build crosses (without binutils, so stopped shortly after building cc1), make a copy of cc1, try expected tweaks in config/*/*.cc around the TYPE_NO_NAMED_ARGS_STDARG_P uses unless it was clearly unnecessary, make cc1 again and compare if the c23-stdarg-9.c assembly is any different, if yes, try to eyeball it if the changes are desired, if the assembly is unmodified, throw away the changes. With the changes by others (loongarch, mips, riscv) I hope we are good on the c23-stdarg-*.c tests on all arches. Jakub
On 3/20/24 11:29 AM, Jakub Jelinek wrote: > On Wed, Mar 20, 2024 at 10:58:05AM -0600, Jeff Law wrote: >> On 3/20/24 10:06 AM, Jakub Jelinek wrote: >>> Like for x86-64, alpha or rs6000, m32r seems to be affected too. >>> >>> Just visually checked differences in c23-stdarg-9.c assembly in a cross >>> without/with the patch, committed to trunk. >>> >> That fixed c23-stdarg-{6,8,9} execution tests. > > Thanks for these checks. All I've done with the remaining targets > today (csky-linux epiphany-elf fr30-elf frv-linux ft32-elf m32r-elf mcore-elf > mmix-knuth-mmixware nds32-linux nios2-linux sh-linux visium-elf) was > build crosses (without binutils, so stopped shortly after building cc1), > make a copy of cc1, try expected tweaks in config/*/*.cc around the > TYPE_NO_NAMED_ARGS_STDARG_P uses unless it was clearly unnecessary, > make cc1 again and compare if the c23-stdarg-9.c assembly is any different, > if yes, try to eyeball it if the changes are desired, if the assembly is > unmodified, throw away the changes. > > With the changes by others (loongarch, mips, riscv) I hope we are good on > the c23-stdarg-*.c tests on all arches. Forgot to note, arc-elf started passing c23-stdarg-9.c yesterday. Started an off-cycle run of the alpha, so figure this time tomorrow we'll have confirmation it's working. Jeff
--- gcc/config/m32r/m32r.cc.jj 2024-01-03 11:51:50.204472028 +0100 +++ gcc/config/m32r/m32r.cc 2024-03-20 16:12:15.841512952 +0100 @@ -1287,7 +1287,8 @@ m32r_setup_incoming_varargs (cumulative_ if (!TYPE_NO_NAMED_ARGS_STDARG_P (TREE_TYPE (current_function_decl))) gcc_assert (arg.mode != BLKmode); - if (!TYPE_NO_NAMED_ARGS_STDARG_P (TREE_TYPE (current_function_decl))) + if (!TYPE_NO_NAMED_ARGS_STDARG_P (TREE_TYPE (current_function_decl)) + || arg.type != NULL_TREE) first_anon_arg = (ROUND_ADVANCE_CUM (*get_cumulative_args (cum), arg.mode, arg.type) + ROUND_ADVANCE_ARG (arg.mode, arg.type));