Message ID | ZWeChQalHyNSI+zw@tucnak |
---|---|
State | New |
Headers |
Return-Path: <gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 50D1D3881D05 for <patchwork@sourceware.org>; Wed, 29 Nov 2023 18:33:14 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 2D79C383F5FB for <gcc-patches@gcc.gnu.org>; Wed, 29 Nov 2023 18:32:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2D79C383F5FB Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2D79C383F5FB Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701282779; cv=none; b=tN24k2GcJDo9zaaf++iG+9BFnt31+xJh9nyYBFlZlEWpU+vV7ekjyNGkD74gFd2wYRhhXB3hy9TVygHi8eepnmx0hWRuJXnO/E155MpqshiJRTQjrkyHEvFeh+es45Dvdudie317LZgU3T2dPYR5VD5b0qd8hYdFVbs4UTtnoh0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701282779; c=relaxed/simple; bh=jmsLOkuMf6RwNVrI4aS1up7gA25KnaHkwSH8SrvXVEU=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=AVnGHsnbU0+g0A4qK2YEG/t4AxFBP+TohjkSJl4wNbWwVTScVJLjliHTDj4e0tdivrwKwoS5F9Qi9pgmpJxcWkODpR1ZjZ4rzXKlQItNxeHoG5PkFamnTkGOtAmGpFy5Sjx4H1Vuf+xzwF+/x1qywCozcnycmUWArxmsJaLTWyI= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701282777; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-to:resent-from:resent-message-id; bh=7IMaQCoTx9tzYt14KjxNRa9/qlfKZDqhaI5PvbjVIIc=; b=KiQK/78VIjJqVGsfLEXC/yJOnZreqpjn5M2x63FwDQEo2xMFULb8GcvbtdurdrVknezqID q1s9YO3qw8MZFrXaBGYttrFbh7z9XfKLcqYtPkNPnBEzP+rO1eqhMTngO/z2RBf4JhK8l4 WjTqyYvtpKaOISLXpyrYX/E0PvYXhGo= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-303-m2aKYyKWN1CC0EDn4DROAw-1; Wed, 29 Nov 2023 13:32:54 -0500 X-MC-Unique: m2aKYyKWN1CC0EDn4DROAw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4B49F101A550; Wed, 29 Nov 2023 18:32:54 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.195.157]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0EC1B1C060AE; Wed, 29 Nov 2023 18:32:53 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 3ATIWptV3335124 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 29 Nov 2023 19:32:51 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 3ATIWoHW3335123; Wed, 29 Nov 2023 19:32:50 +0100 Resent-From: Jakub Jelinek <jakub@redhat.com> Resent-Date: Wed, 29 Nov 2023 19:32:49 +0100 Resent-Message-ID: <ZWeD0ftTyKUHscym@tucnak> Resent-To: Ulrich Weigand <uweigand@de.ibm.com>, Andreas Krebbel <krebbel@linux.ibm.com>, gcc-patches@gcc.gnu.org Date: Wed, 29 Nov 2023 19:27:20 +0100 From: Jakub Jelinek <jakub@redhat.com> To: Ulrich Weigand <uweigand@de.ibm.com>, Andreas Krebbel <krebbel@linux.ibm.com> Cc: gcc-patches@gcc.gnu.org Subject: [PATCH] s390: Fix builtin-classify-type-1.c on s390 too [PR112725] Message-ID: <ZWeChQalHyNSI+zw@tucnak> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org> List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe> List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/> List-Post: <mailto:gcc-patches@gcc.gnu.org> List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help> List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe> Reply-To: Jakub Jelinek <jakub@redhat.com> Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org |
Series |
s390: Fix builtin-classify-type-1.c on s390 too [PR112725]
|
|
Checks
Context | Check | Description |
---|---|---|
linaro-tcwg-bot/tcwg_gcc_build--master-arm | fail | Patch failed to apply |
linaro-tcwg-bot/tcwg_gcc_build--master-aarch64 | fail | Patch failed to apply |
Commit Message
Jakub Jelinek
Nov. 29, 2023, 6:27 p.m. UTC
Hi! Given that the s390 backend defines pretty much the same target hook as rs6000, I believe it suffers (at least when using -mvx?) the same problem as rs6000, though admittedly this is so far completely untested. Ok for trunk if it passes bootstrap/regtest there? 2023-11-29 Jakub Jelinek <jakub@redhat.com> PR target/112725 * config/s390/s390.cc (s390_invalid_arg_for_unprototyped_fn): Return NULL for __builtin_classify_type calls with vector arguments. Jakub
Comments
On Wed, Nov 29, 2023 at 07:27:20PM +0100, Jakub Jelinek wrote: > Given that the s390 backend defines pretty much the same target hook > as rs6000, I believe it suffers (at least when using -mvx?) the same > problem as rs6000, though admittedly this is so far completely > untested. > > Ok for trunk if it passes bootstrap/regtest there? Now successfully bootstrapped/regtested on s390x-linux and indeed it fixes -FAIL: c-c++-common/builtin-classify-type-1.c -Wc++-compat (test for excess errors) -UNRESOLVED: c-c++-common/builtin-classify-type-1.c -Wc++-compat compilation failed to produce executable there as well. > 2023-11-29 Jakub Jelinek <jakub@redhat.com> > > PR target/112725 > * config/s390/s390.cc (s390_invalid_arg_for_unprototyped_fn): Return > NULL for __builtin_classify_type calls with vector arguments. > > --- gcc/config/s390/s390.cc.jj 2023-11-27 17:34:25.684287136 +0100 > +++ gcc/config/s390/s390.cc 2023-11-29 09:41:08.569491077 +0100 > @@ -12650,7 +12650,8 @@ s390_invalid_arg_for_unprototyped_fn (co > && VECTOR_TYPE_P (TREE_TYPE (val)) > && (funcdecl == NULL_TREE > || (TREE_CODE (funcdecl) == FUNCTION_DECL > - && DECL_BUILT_IN_CLASS (funcdecl) != BUILT_IN_MD))) > + && DECL_BUILT_IN_CLASS (funcdecl) != BUILT_IN_MD > + && !fndecl_built_in_p (funcdecl, BUILT_IN_CLASSIFY_TYPE)))) > ? N_("vector argument passed to unprototyped function") > : NULL); > } Jakub
On 11/30/23 17:34, Jakub Jelinek wrote: > On Wed, Nov 29, 2023 at 07:27:20PM +0100, Jakub Jelinek wrote: >> Given that the s390 backend defines pretty much the same target hook >> as rs6000, I believe it suffers (at least when using -mvx?) the same >> problem as rs6000, though admittedly this is so far completely >> untested. >> >> Ok for trunk if it passes bootstrap/regtest there? > > Now successfully bootstrapped/regtested on s390x-linux and indeed it > fixes > -FAIL: c-c++-common/builtin-classify-type-1.c -Wc++-compat (test for excess errors) > -UNRESOLVED: c-c++-common/builtin-classify-type-1.c -Wc++-compat compilation failed to produce executable > there as well. > >> 2023-11-29 Jakub Jelinek <jakub@redhat.com> >> >> PR target/112725 >> * config/s390/s390.cc (s390_invalid_arg_for_unprototyped_fn): Return >> NULL for __builtin_classify_type calls with vector arguments. Ok. Thank you, Jakub! Andreas
--- gcc/config/s390/s390.cc.jj 2023-11-27 17:34:25.684287136 +0100 +++ gcc/config/s390/s390.cc 2023-11-29 09:41:08.569491077 +0100 @@ -12650,7 +12650,8 @@ s390_invalid_arg_for_unprototyped_fn (co && VECTOR_TYPE_P (TREE_TYPE (val)) && (funcdecl == NULL_TREE || (TREE_CODE (funcdecl) == FUNCTION_DECL - && DECL_BUILT_IN_CLASS (funcdecl) != BUILT_IN_MD))) + && DECL_BUILT_IN_CLASS (funcdecl) != BUILT_IN_MD + && !fndecl_built_in_p (funcdecl, BUILT_IN_CLASSIFY_TYPE)))) ? N_("vector argument passed to unprototyped function") : NULL); }