Skip a number of C++ "split files" test cases for '-fno-exceptions' testing (was: Skip a number of C++ test cases for '-fno-exceptions' testing (was: Support in the GCC(/C++) test suites for '-fno-exceptions'))
Checks
Commit Message
Hi!
On 2023-06-15T17:15:54+0200, I wrote:
> On 2023-06-06T20:31:21+0100, Jonathan Wakely <jwakely@redhat.com> wrote:
>> On Tue, 6 Jun 2023 at 20:14, Thomas Schwinge <thomas@codesourcery.com> wrote:
>>> This issue comes up in context of me working on C++ support for GCN and
>>> nvptx target. Those targets shall default to '-fno-exceptions' -- or,
>>> "in other words", '-fexceptions' is not supported. (Details omitted
>>> here.)
>>>
>>> It did seem clear to me that with such a configuration it'll be hard to
>>> get clean test results. Then I found code in
>>> 'gcc/testsuite/lib/gcc-dg.exp:gcc-dg-prune':
>>>
>>> # If exceptions are disabled, mark tests expecting exceptions to be enabled
>>> # as unsupported.
>>> if { ![check_effective_target_exceptions_enabled] } {
>>> if [regexp "(^|\n)\[^\n\]*: error: exception handling disabled" $text] {
>>> return "::unsupported::exception handling disabled"
>>> }
>>>
>>> ..., which, in a way, sounds as if the test suite generally is meant to
>>> produce useful results for '-fno-exceptions', nice surprise!
>>>
>>> Running x86_64-pc-linux-gnu (not yet GCN, nvptx) 'make check' with:
>>>
>>> RUNTESTFLAGS='--target_board=unix/-fno-exceptions\{,-m32\}'
>>>
>>> ..., I find that indeed this does work for a lot of test cases, where we
>>> then get (random example):
>>>
>>> PASS: g++.dg/coroutines/pr99710.C (test for errors, line 23)
>>> -PASS: g++.dg/coroutines/pr99710.C (test for excess errors)
>>> +UNSUPPORTED: g++.dg/coroutines/pr99710.C: exception handling disabled
>>>
>>> ..., due to:
>>>
>>> [...]/g++.dg/coroutines/pr99710.C: In function 'task my_coro()':
>>> +[...]/g++.dg/coroutines/pr99710.C:18:10: error: exception handling
>>> disabled, use '-fexceptions' to enable
>>> [...]/g++.dg/coroutines/pr99710.C:23:7: error: await expressions are
>>> not permitted in handlers
>>> compiler exited with status 1
>>>
>>> But, we're nowhere near clean test results: PASS -> FAIL as well as
>>> XFAIL -> XPASS regressions, due to 'error: exception handling disabled'
>>> precluding other diagnostics seems to be one major issue.
>>>
>>> Is there interest in me producing the obvious (?) changes to those test
>>> cases, such that compiler g++ as well as target library libstdc++ test
>>> results are reasonably clean? (If you think that's all "wasted effort",
>>> then I suppose I'll just locally ignore any FAILs/XPASSes/UNRESOLVEDs
>>> that appear in combination with
>>> 'UNSUPPORTED: [...]: exception handling disabled'.)
>>
>> I would welcome that for libstdc++. [...]
> Not having heard anything contrary regarding the compiler side of things,
> I've now been working on that, see below.
>>> Otherwise, a number of test cases need DejaGnu directives
>>> conditionalized on 'target exceptions_enabled'.
>
> Before I get to such things, even simpler: OK to push the attached
> "Skip a number of C++ test cases for '-fno-exceptions' testing"?
Similarly, OK to push the attached
"Skip a number of C++ "split files" test cases for '-fno-exceptions' testing"?
Grüße
Thomas
>>> (Or,
>>> 'error: exception handling disabled' made a "really late" diagnostic, so
>>> that it doesn't preclude other diagnostics? I'll have a look. Well,
>>> maybe something like: in fact do not default to '-fno-exceptions', but
>>> instead emit 'error: exception handling disabled' only if in a "really
>>> late" pass we run into exceptions-related constructs that we cannot
>>> support. That'd also avoid PASS -> UNSUPPORTED "regressions" when
>>> exception handling in fact gets optimized away, for example. I like that
>>> idea, conceptually -- but is it feasible to implement..?)
>>
>> IMHO just [...] using [an effective target keyword] in test
>> selectors seems simpler, and doesn't require changes to the compiler, just
>> the tests.
>
> I still like the idea, but yes, I've mentally put it on file "for later"
> (ha, ha, ha...) -- it doesn't seem obvious to implement.
>
>
> Grüße
> Thomas
-----------------
Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955
From ff03a142dcdb8e2225a57f62bbc7679c384e88e5 Mon Sep 17 00:00:00 2001
From: Thomas Schwinge <thomas@codesourcery.com>
Date: Wed, 7 Jun 2023 16:11:11 +0200
Subject: [PATCH] Skip a number of C++ "split files" test cases for
'-fno-exceptions' testing
Running 'make check' with: 'RUNTESTFLAGS=--target_board=unix/-fno-exceptions',
'error: exception handling disabled' is triggered for C++ 'throw' etc. usage,
and per 'gcc/testsuite/lib/gcc-dg.exp:gcc-dg-prune':
# If exceptions are disabled, mark tests expecting exceptions to be enabled
# as unsupported.
if { ![check_effective_target_exceptions_enabled] } {
if [regexp "(^|\n)\[^\n\]*: error: exception handling disabled" $text] {
return "::unsupported::exception handling disabled"
}
..., which generally means:
-PASS: [...] (test for excess errors)
+UNSUPPORTED: [...]: exception handling disabled
However, this doesn't work for "split files" test cases. For example:
PASS: g++.dg/compat/eh/ctor1 cp_compat_main_tst.o compile
[-PASS:-]{+UNSUPPORTED:+} g++.dg/compat/eh/ctor1 cp_compat_x_tst.o [-compile-]{+compile: exception handling disabled+}
[-PASS:-]{+UNSUPPORTED:+} g++.dg/compat/eh/ctor1 cp_compat_y_tst.o [-compile-]{+compile: exception handling disabled+}
[-PASS:-]{+UNRESOLVED:+} g++.dg/compat/eh/ctor1 cp_compat_x_tst.o-cp_compat_y_tst.o link
[-PASS:-]{+UNRESOLVED:+} g++.dg/compat/eh/ctor1 cp_compat_x_tst.o-cp_compat_y_tst.o execute
..., or:
[-PASS:-]{+UNSUPPORTED:+} g++.dg/lto/20081109-1 cp_lto_20081109-1_0.o [-assemble,-]{+assemble: exception handling disabled+}
{+UNRESOLVED: g++.dg/lto/20081109-1 cp_lto_20081109-1_0.o-cp_lto_20081109-1_0.o execute+} -fPIC -flto -flto-partition=1to1
[-PASS:-]{+UNRESOLVED:+} g++.dg/lto/20081109-1 cp_lto_20081109-1_0.o-cp_lto_20081109-1_0.o [-link,-]{+link+} -fPIC -flto -flto-partition=1to1
The "compile"/"assemble" ones (either continue to work, or) result in the
expected 'UNSUPPORTED: [...] compile: exception handling disabled', but
"link" and "execute" ones then turn UNRESOLVED.
Specify 'dg-require-effective-target exceptions_enabled' for those test cases.
gcc/testsuite/
* g++.dg/compat/eh/ctor1_main.C: Specify
'dg-require-effective-target exceptions_enabled'.
* g++.dg/compat/eh/ctor2_main.C: Likewise.
* g++.dg/compat/eh/dtor1_main.C: Likewise.
* g++.dg/compat/eh/filter1_main.C: Likewise.
* g++.dg/compat/eh/filter2_main.C: Likewise.
* g++.dg/compat/eh/new1_main.C: Likewise.
* g++.dg/compat/eh/nrv1_main.C: Likewise.
* g++.dg/compat/eh/spec3_main.C: Likewise.
* g++.dg/compat/eh/template1_main.C: Likewise.
* g++.dg/compat/eh/unexpected1_main.C: Likewise.
* g++.dg/compat/init/array5_main.C: Likewise.
* g++.dg/lto/20081109-1_0.C: Likewise.
* g++.dg/lto/20081109_0.C: Likewise.
* g++.dg/lto/20091026-1_0.C: Likewise.
* g++.dg/lto/pr87906_0.C: Likewise.
* g++.dg/lto/pr88046_0.C: Likewise.
---
gcc/testsuite/g++.dg/compat/eh/ctor1_main.C | 2 ++
gcc/testsuite/g++.dg/compat/eh/ctor2_main.C | 2 ++
gcc/testsuite/g++.dg/compat/eh/dtor1_main.C | 2 ++
gcc/testsuite/g++.dg/compat/eh/filter1_main.C | 2 ++
gcc/testsuite/g++.dg/compat/eh/filter2_main.C | 2 ++
gcc/testsuite/g++.dg/compat/eh/new1_main.C | 2 ++
gcc/testsuite/g++.dg/compat/eh/nrv1_main.C | 2 ++
gcc/testsuite/g++.dg/compat/eh/spec3_main.C | 2 ++
gcc/testsuite/g++.dg/compat/eh/template1_main.C | 2 ++
gcc/testsuite/g++.dg/compat/eh/unexpected1_main.C | 2 ++
gcc/testsuite/g++.dg/compat/init/array5_main.C | 2 ++
gcc/testsuite/g++.dg/lto/20081109-1_0.C | 1 +
gcc/testsuite/g++.dg/lto/20081109_0.C | 2 ++
gcc/testsuite/g++.dg/lto/20091026-1_0.C | 1 +
gcc/testsuite/g++.dg/lto/pr87906_0.C | 1 +
gcc/testsuite/g++.dg/lto/pr88046_0.C | 1 +
16 files changed, 28 insertions(+)
@@ -4,6 +4,8 @@
// Split into pieces for binary compatibility testing October 2002
+// { dg-require-effective-target exceptions_enabled }
+
extern void ctor1_x (void);
int
@@ -4,6 +4,8 @@
// Split into pieces for binary compatibility testing October 2002
+// { dg-require-effective-target exceptions_enabled }
+
extern void ctor2_x (void);
int main ()
@@ -5,6 +5,8 @@
// Split into pieces for binary compatibility testing October 2002
+// { dg-require-effective-target exceptions_enabled }
+
extern void dtor1_x (void);
int
@@ -2,6 +2,8 @@
// Split into pieces for binary compatibility testing October 2002
+// { dg-require-effective-target exceptions_enabled }
+
extern void filter1_x (void);
int
@@ -3,6 +3,8 @@
// Split into pieces for binary compatibility testing October 2002
+// { dg-require-effective-target exceptions_enabled }
+
extern void filter2_x (void);
int
@@ -4,6 +4,8 @@
// Split into pieces for binary compatibility testing October 2002
+// { dg-require-effective-target exceptions_enabled }
+
extern void new1_x (void);
int
@@ -3,6 +3,8 @@
// Split into pieces for binary compatibility testing October 2002
+// { dg-require-effective-target exceptions_enabled }
+
extern void nrv1_x (void);
int
@@ -3,6 +3,8 @@
// Split into pieces for binary compatibility testing October 2002
+// { dg-require-effective-target exceptions_enabled }
+
extern void spec3_x (void);
int
@@ -3,6 +3,8 @@
// Split into pieces for binary compatibility testing October 2002
+// { dg-require-effective-target exceptions_enabled }
+
extern void template1_x (void);
int
@@ -3,6 +3,8 @@
// Split into pieces for binary compatibility testing October 2002
+// { dg-require-effective-target exceptions_enabled }
+
extern void unexpected1_x ();
int
@@ -5,6 +5,8 @@
// Incorrect construction and destruction of multi-dimensional
// array of class.
+// { dg-require-effective-target exceptions_enabled }
+
extern void array5_x (void);
int
@@ -1,4 +1,5 @@
// { dg-lto-do link }
+// { dg-require-effective-target exceptions_enabled }
// { dg-require-effective-target fpic }
// { dg-lto-options {{-fPIC -flto -flto-partition=1to1}} }
// { dg-extra-ld-options "-fPIC -flto -flto-partition=1to1 -r -fno-exceptions -flinker-output=nolto-rel" }
@@ -1,3 +1,5 @@
+// { dg-require-effective-target exceptions_enabled }
+
extern "C" { void abort (void);}
int foo (int);
@@ -1,4 +1,5 @@
// { dg-lto-do link }
+// { dg-require-effective-target exceptions_enabled }
// { dg-extra-ld-options "-r -nostdlib -flinker-output=nolto-rel" }
#include "20091026-1_a.h"
@@ -1,4 +1,5 @@
// { dg-lto-do link }
+// { dg-require-effective-target exceptions_enabled }
// { dg-require-effective-target fpic }
// { dg-require-effective-target shared }
// { dg-lto-options { { -O -fPIC -flto } } }
@@ -1,5 +1,6 @@
// { dg-lto-do link }
// { dg-lto-options { { -O2 -fPIC -flto } } }
+// { dg-require-effective-target exceptions_enabled }
// { dg-require-effective-target shared }
// { dg-require-effective-target fpic }
// { dg-extra-ld-options "-shared -g" }
--
2.34.1