diff mbox series

RISC-V: Fix a typo in zce to zcf implication

Message ID 20250119150611.3506447-1-ykolerov@synopsys.com
State Superseded
Delegated to: Robin Dapp
Headers
Series RISC-V: Fix a typo in zce to zcf implication |

Checks

Context Check Description
rivoscibot/toolchain-ci-rivos-apply-patch success Patch applied
rivoscibot/toolchain-ci-rivos-lint success Lint passed
rivoscibot/toolchain-ci-rivos-build--newlib-rv64gcv-lp64d-multilib success Build passed
rivoscibot/toolchain-ci-rivos-build--linux-rv64gc_zba_zbb_zbc_zbs-lp64d-multilib success Build passed
rivoscibot/toolchain-ci-rivos-build--linux-rv64gcv-lp64d-multilib success Build passed
linaro-tcwg-bot/tcwg_gcc_build--master-aarch64 success Build passed
rivoscibot/toolchain-ci-rivos-test success Testing passed
linaro-tcwg-bot/tcwg_gcc_check--master-aarch64 success Test passed
linaro-tcwg-bot/tcwg_gcc_build--master-arm success Build passed
linaro-tcwg-bot/tcwg_gcc_check--master-arm success Test passed

Commit Message

Yuriy Kolerov Jan. 19, 2025, 3:06 p.m. UTC 
  zce must imply zcf but this rule was corrupted after
refactoring in this commit:

9e12010b5e724277ea44c300630802f464407d8d

gcc/ChangeLog:

	* common/config/riscv/riscv-common.cc: fix zce to zcf
	implication.

Signed-off-by: Yuriy Kolerov <ykolerov@synopsys.com>
---
 gcc/common/config/riscv/riscv-common.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Robin Dapp Jan. 20, 2025, 2:02 p.m. UTC | #1 
> zce must imply zcf but this rule was corrupted after
> refactoring in this commit:
>
> 9e12010b5e724277ea44c300630802f464407d8d
>
> gcc/ChangeLog:
>
> 	* common/config/riscv/riscv-common.cc: fix zce to zcf
> 	implication.

Thanks, looks reasonable but please add a test case as it's clearly a
regression. Ideally open a bug as well and reference the PR.  Also, please
specify how and what you tested.
Yuriy Kolerov Jan. 20, 2025, 4:16 p.m. UTC | #2 
Hi Robin,

Sure, I will do everything you listed shortly, and I will apply a second version of the patch.

Regards,
Yuriy Kolerov

Regards,
Yuriy Kolerov
diff mbox series

Patch

diff --git a/gcc/common/config/riscv/riscv-common.cc b/gcc/common/config/riscv/riscv-common.cc
index 5038f0eb959..b34409adf39 100644
--- a/gcc/common/config/riscv/riscv-common.cc
+++ b/gcc/common/config/riscv/riscv-common.cc
@@ -213,7 +213,7 @@  static const riscv_implied_info_t riscv_implied_info[] =
   {"zcmp", "zca"},
   {"zcmt", "zca"},
   {"zcmt", "zicsr"},
-  {"zcf", "f",
+  {"zce", "zcf",
    [] (const riscv_subset_list *subset_list) -> bool
    {
      return subset_list->xlen () == 32 && subset_list->lookup ("f");