diff mbox series

fixincludes: add AC_CONFIG_MACRO_DIRS to configure.ac

Message ID 20240430022420.114397-1-simon.marchi@polymtl.ca
State New
Headers
Series fixincludes: add AC_CONFIG_MACRO_DIRS to configure.ac |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_gcc_build--master-arm success Testing passed
linaro-tcwg-bot/tcwg_gcc_build--master-aarch64 success Testing passed
linaro-tcwg-bot/tcwg_gcc_check--master-arm success Testing passed
linaro-tcwg-bot/tcwg_gcc_check--master-aarch64 success Testing passed

Commit Message

Simon Marchi April 30, 2024, 2:24 a.m. UTC 
  Add an "AC_CONFIG_MACRO_DIRS" call in configure.ac, with the same
directories as specified in "ACLOCAL_AMFLAGS", in Makefile.in.

This makes it possible to re-generate aclocal.m4 using "autoreconf".
---
 fixincludes/configure    | 1 +
 fixincludes/configure.ac | 1 +
 2 files changed, 2 insertions(+)


base-commit: 22b20ac6c6aead2d3f36c413a77dd0b80adfec39

Comments

Christophe Lyon April 30, 2024, 8:54 a.m. UTC | #1 
On Tue, 30 Apr 2024 at 04:25, Simon Marchi <simon.marchi@polymtl.ca> wrote:
>
> Add an "AC_CONFIG_MACRO_DIRS" call in configure.ac, with the same
> directories as specified in "ACLOCAL_AMFLAGS", in Makefile.in.
>
> This makes it possible to re-generate aclocal.m4 using "autoreconf".

Thanks, this LGTM, although like in your other patch, we need a
ChangeLog entry in the commit message.

Christophe

> ---
>  fixincludes/configure    | 1 +
>  fixincludes/configure.ac | 1 +
>  2 files changed, 2 insertions(+)
>
> diff --git a/fixincludes/configure b/fixincludes/configure
> index 662c94dc1120..7147c9a618aa 100755
> --- a/fixincludes/configure
> +++ b/fixincludes/configure
> @@ -4627,6 +4627,7 @@ $as_echo "$ac_cv_path_SED" >&6; }
>    rm -f conftest.sed
>
>
> +
>  # Figure out what compiler warnings we can enable.
>  # See config/warnings.m4 for details.
>
> diff --git a/fixincludes/configure.ac b/fixincludes/configure.ac
> index 4e78511d20fc..3d177699ebfa 100644
> --- a/fixincludes/configure.ac
> +++ b/fixincludes/configure.ac
> @@ -7,6 +7,7 @@ AC_CANONICAL_SYSTEM
>  AC_PROG_CC
>  AC_USE_SYSTEM_EXTENSIONS
>  AC_PROG_SED
> +AC_CONFIG_MACRO_DIRS([.. ../config])
>
>  # Figure out what compiler warnings we can enable.
>  # See config/warnings.m4 for details.
>
> base-commit: 22b20ac6c6aead2d3f36c413a77dd0b80adfec39
> --
> 2.44.0
>
Simon Marchi April 30, 2024, 3:47 p.m. UTC | #2 
On 4/30/24 4:54 AM, Christophe Lyon wrote:
> On Tue, 30 Apr 2024 at 04:25, Simon Marchi <simon.marchi@polymtl.ca> wrote:
>>
>> Add an "AC_CONFIG_MACRO_DIRS" call in configure.ac, with the same
>> directories as specified in "ACLOCAL_AMFLAGS", in Makefile.in.
>>
>> This makes it possible to re-generate aclocal.m4 using "autoreconf".
> 
> Thanks, this LGTM, although like in your other patch, we need a
> ChangeLog entry in the commit message.
> 
> Christophe

Here is the ChangeLog entry:

fixincludes/ChangeLog:

	* configure.ac: Add AC_CONFIG_MACRO_DIRS.
	* configure: Re-generate.

I don't have access to the gcc repo, so if/when this patch gets
approved, can you push it on my behalf?

Thanks,

Simon
Christophe Lyon May 2, 2024, 1:36 p.m. UTC | #3 
On Tue, 30 Apr 2024 at 17:47, Simon Marchi <simon.marchi@polymtl.ca> wrote:
>
> On 4/30/24 4:54 AM, Christophe Lyon wrote:
> > On Tue, 30 Apr 2024 at 04:25, Simon Marchi <simon.marchi@polymtl.ca> wrote:
> >>
> >> Add an "AC_CONFIG_MACRO_DIRS" call in configure.ac, with the same
> >> directories as specified in "ACLOCAL_AMFLAGS", in Makefile.in.
> >>
> >> This makes it possible to re-generate aclocal.m4 using "autoreconf".
> >
> > Thanks, this LGTM, although like in your other patch, we need a
> > ChangeLog entry in the commit message.
> >
> > Christophe
>
> Here is the ChangeLog entry:
>
> fixincludes/ChangeLog:
>
>         * configure.ac: Add AC_CONFIG_MACRO_DIRS.
>         * configure: Re-generate.
>
> I don't have access to the gcc repo, so if/when this patch gets
> approved, can you push it on my behalf?
Sure!

>
> Thanks,
>
> Simon
diff mbox series

Patch

diff --git a/fixincludes/configure b/fixincludes/configure
index 662c94dc1120..7147c9a618aa 100755
--- a/fixincludes/configure
+++ b/fixincludes/configure
@@ -4627,6 +4627,7 @@  $as_echo "$ac_cv_path_SED" >&6; }
   rm -f conftest.sed
 
 
+
 # Figure out what compiler warnings we can enable.
 # See config/warnings.m4 for details.
 
diff --git a/fixincludes/configure.ac b/fixincludes/configure.ac
index 4e78511d20fc..3d177699ebfa 100644
--- a/fixincludes/configure.ac
+++ b/fixincludes/configure.ac
@@ -7,6 +7,7 @@  AC_CANONICAL_SYSTEM
 AC_PROG_CC
 AC_USE_SYSTEM_EXTENSIONS
 AC_PROG_SED
+AC_CONFIG_MACRO_DIRS([.. ../config])
 
 # Figure out what compiler warnings we can enable.
 # See config/warnings.m4 for details.