diff mbox series

wwwdocs: contribute.html: Update consensus on patch content.

Message ID 20240425154313.1988229-1-carlos@redhat.com
State New
Headers
Series wwwdocs: contribute.html: Update consensus on patch content. |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_gcc_build--master-aarch64 fail Patch failed to apply
linaro-tcwg-bot/tcwg_gcc_build--master-arm fail Patch failed to apply

Commit Message

Carlos O'Donell April 25, 2024, 3:41 p.m. UTC 
  Discussion is here:
https://inbox.sourceware.org/gcc/CAPS5khZeWkAD=V8ka9g5eECDNK3BDHFNZJuMpVC+HeDmkVJMCg@mail.gmail.com/

Rough consensus from Jakub Jelinek, Richard Biener and others is
that maintainers are for the change.

This changes the contribution notes to allow it.
---
 htdocs/contribute.html | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Comments

Richard Biener April 25, 2024, 6:32 p.m. UTC | #1 
> Am 25.04.2024 um 17:44 schrieb Carlos O'Donell <carlos@redhat.com>:
> 
> Discussion is here:
> https://inbox.sourceware.org/gcc/CAPS5khZeWkAD=V8ka9g5eECDNK3BDHFNZJuMpVC+HeDmkVJMCg@mail.gmail.com/
> 
> Rough consensus from Jakub Jelinek, Richard Biener and others is
> that maintainers are for the change.

Ok

Richard 


> This changes the contribution notes to allow it.
> ---
> htdocs/contribute.html | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/htdocs/contribute.html b/htdocs/contribute.html
> index 7c1ae323..e8137edc 100644
> --- a/htdocs/contribute.html
> +++ b/htdocs/contribute.html
> @@ -195,8 +195,9 @@ of your testing.
> 
> <dt>The patch itself</dt>
> <dd>
> -Do not include generated files as part of the patch, just mention
> -them in the ChangeLog (e.g., "<code>* configure: Regenerate.</code>").
> +The patch should include everything you are changing (including
> +regenerated files which should be noted in the ChangeLog e.g.
> +"<code>* configure: Regenerate.</code>").
> </dd>
> 
> </dl>
> --
> 2.44.0
>
Christophe Lyon April 26, 2024, 8:25 a.m. UTC | #2 
On Thu, 25 Apr 2024 at 17:44, Carlos O'Donell <carlos@redhat.com> wrote:
>
> Discussion is here:
> https://inbox.sourceware.org/gcc/CAPS5khZeWkAD=V8ka9g5eECDNK3BDHFNZJuMpVC+HeDmkVJMCg@mail.gmail.com/
>
> Rough consensus from Jakub Jelinek, Richard Biener and others is
> that maintainers are for the change.
>
> This changes the contribution notes to allow it.

Thank you Carlos for the patch and helping with the discussions!

Christophe

> ---
>  htdocs/contribute.html | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/htdocs/contribute.html b/htdocs/contribute.html
> index 7c1ae323..e8137edc 100644
> --- a/htdocs/contribute.html
> +++ b/htdocs/contribute.html
> @@ -195,8 +195,9 @@ of your testing.
>
>  <dt>The patch itself</dt>
>  <dd>
> -Do not include generated files as part of the patch, just mention
> -them in the ChangeLog (e.g., "<code>* configure: Regenerate.</code>").
> +The patch should include everything you are changing (including
> +regenerated files which should be noted in the ChangeLog e.g.
> +"<code>* configure: Regenerate.</code>").
>  </dd>
>
>  </dl>
> --
> 2.44.0
>
Christophe Lyon April 26, 2024, 9:45 a.m. UTC | #3 
On Fri, 26 Apr 2024 at 10:25, Christophe Lyon
<christophe.lyon@linaro.org> wrote:
>
> On Thu, 25 Apr 2024 at 17:44, Carlos O'Donell <carlos@redhat.com> wrote:
> >
> > Discussion is here:
> > https://inbox.sourceware.org/gcc/CAPS5khZeWkAD=V8ka9g5eECDNK3BDHFNZJuMpVC+HeDmkVJMCg@mail.gmail.com/
> >
> > Rough consensus from Jakub Jelinek, Richard Biener and others is
> > that maintainers are for the change.
> >
> > This changes the contribution notes to allow it.
>
> Thank you Carlos for the patch and helping with the discussions!
>
> Christophe
>

And BTW sorry I wasn't able to attend the meeting yesterday, thanks
Thiago for raising the question.

I have a follow-up one: I think the same applies to binutils, but I
don't think any maintainer / contributor expressed an opinion, and
IIUC patch policy for binutils is (lightly) documented at
https://sourceware.org/binutils/wiki/HowToContribute
Maybe Nick can update it? (I don't have such rights)

Thanks,

Christophe

> > ---
> >  htdocs/contribute.html | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/htdocs/contribute.html b/htdocs/contribute.html
> > index 7c1ae323..e8137edc 100644
> > --- a/htdocs/contribute.html
> > +++ b/htdocs/contribute.html
> > @@ -195,8 +195,9 @@ of your testing.
> >
> >  <dt>The patch itself</dt>
> >  <dd>
> > -Do not include generated files as part of the patch, just mention
> > -them in the ChangeLog (e.g., "<code>* configure: Regenerate.</code>").
> > +The patch should include everything you are changing (including
> > +regenerated files which should be noted in the ChangeLog e.g.
> > +"<code>* configure: Regenerate.</code>").
> >  </dd>
> >
> >  </dl>
> > --
> > 2.44.0
> >
Carlos O'Donell May 1, 2024, 12:58 p.m. UTC | #4 
On 4/25/24 14:32, Richard Biener wrote:
> 
> 
>> Am 25.04.2024 um 17:44 schrieb Carlos O'Donell <carlos@redhat.com>:
>>
>> Discussion is here:
>> https://inbox.sourceware.org/gcc/CAPS5khZeWkAD=V8ka9g5eECDNK3BDHFNZJuMpVC+HeDmkVJMCg@mail.gmail.com/
>>
>> Rough consensus from Jakub Jelinek, Richard Biener and others is
>> that maintainers are for the change.
> 
> Ok

Pushed.

Thanks for helping me move this forward.

I look forward to pre-commit CI across all the projects.

Helping Linaro make forward progress here is my primary goal.
diff mbox series

Patch

diff --git a/htdocs/contribute.html b/htdocs/contribute.html
index 7c1ae323..e8137edc 100644
--- a/htdocs/contribute.html
+++ b/htdocs/contribute.html
@@ -195,8 +195,9 @@  of your testing.
 
 <dt>The patch itself</dt>
 <dd>
-Do not include generated files as part of the patch, just mention
-them in the ChangeLog (e.g., "<code>* configure: Regenerate.</code>"). 
+The patch should include everything you are changing (including
+regenerated files which should be noted in the ChangeLog e.g.
+"<code>* configure: Regenerate.</code>").
 </dd>
 
 </dl>