Message ID | 20240216190034.2684983-1-quic_apinski@quicinc.com |
---|---|
State | Committed |
Commit | 5f1438db419c9eb8901d1d1d7f98fb69082aec8e |
Headers |
Return-Path: <gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 21BDD3857837 for <patchwork@sourceware.org>; Fri, 16 Feb 2024 19:01:25 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by sourceware.org (Postfix) with ESMTPS id 44E17385803B for <gcc-patches@gcc.gnu.org>; Fri, 16 Feb 2024 19:00:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 44E17385803B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=quicinc.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 44E17385803B Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708110059; cv=none; b=OUdB26oMD8tjQ2fYi8jSL2apDADybONL+Kjm94uhLISFIRK92J6jwo7FJxps5tyKjJNRzyb4pXoPrCkLzXy7SnwwpUvIS4T2wCO2nXMSSGsTCDTZsExmJPInw8ROmCzNuSe0BnYdzBUA8apQi/U/gMzdgObPthD04CwzrVx5ud4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708110059; c=relaxed/simple; bh=Kp0YmVuAsps/iIzOeDQ5VLTicoXyd28emgEndQdNhLU=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=Oa73cVtrNyhUN6xzcJyw57E4jFNGTmRdYWwPuWStVVZwYILrcWReRJRMT1pl7yBb6L04XkpGuY97l/E4ccX/iIwKa86xwMHWBMINDRg3Y3d+jwGiX8ylDV+eSC49f3cnFMqB5TsqCyk8M31wj83f1VfhtpmjgZpaqNBwDEMwBFU= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 41GIdwnG019197 for <gcc-patches@gcc.gnu.org>; Fri, 16 Feb 2024 19:00:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding:content-type; s=qcppdkim1; bh=Nmg5qY0 iW6aN4NWWH9BZ8EFX4+KcFY7ymmFAwspnkpM=; b=jHqbEzNofT91m3FxEwTUeE1 38xwxSbQuaJiNlF8cuVgcT6rn6dQ9s0AjuMp9NCzno1WhZcSwIPhLM4+z9gS6yPj QN64TY+wsHU4u6NdwhQ51kmQZUFxqvuJf+ueHN/yyxsYxYaZ+xryo/m8sH3MbjM7 SPlEg0ocPvSL4S0g3I42z0LQjYuhjiSWxRF/p9dZZavdFdpg7E6HvYADwClWZsQn 6A6kgw4kqBz4nm4SFWh2R4qxiZaNv8O9j2GCEV1Kc93ewAuSkOFLReNYgAuQLyFo 1qST1tadrZYWqku1Rwm37X9ju057QeicIkfQCTo1AYIbCGAigc7PVUNA11U9/uw= = Received: from nasanppmta02.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3wa51xh3gv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for <gcc-patches@gcc.gnu.org>; Fri, 16 Feb 2024 19:00:55 +0000 (GMT) Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA02.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 41GJ0tZ7023074 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for <gcc-patches@gcc.gnu.org>; Fri, 16 Feb 2024 19:00:55 GMT Received: from hu-apinski-lv.qualcomm.com (10.49.16.6) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Fri, 16 Feb 2024 11:00:54 -0800 From: Andrew Pinski <quic_apinski@quicinc.com> To: <gcc-patches@gcc.gnu.org> CC: Andrew Pinski <quic_apinski@quicinc.com> Subject: [COMMITTED] c++: Add testcase for this PR [PR97990] Date: Fri, 16 Feb 2024 11:00:34 -0800 Message-ID: <20240216190034.2684983-1-quic_apinski@quicinc.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.49.16.6] X-ClientProxiedBy: nalasex01a.na.qualcomm.com (10.47.209.196) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: ZACM37y851ZEX7pkbKcjJwf2pOz4Ko9V X-Proofpoint-GUID: ZACM37y851ZEX7pkbKcjJwf2pOz4Ko9V X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-02-16_18,2024-02-16_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=0 impostorscore=0 mlxlogscore=921 priorityscore=1501 phishscore=0 spamscore=0 clxscore=1015 adultscore=0 lowpriorityscore=0 bulkscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2401310000 definitions=main-2402160149 X-Spam-Status: No, score=-13.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org> List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe> List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/> List-Post: <mailto:gcc-patches@gcc.gnu.org> List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help> List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe> Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org |
Series |
[COMMITTED] c++: Add testcase for this PR [PR97990]
|
|
Checks
Context | Check | Description |
---|---|---|
linaro-tcwg-bot/tcwg_gcc_build--master-arm | warning | Patch is already merged |
linaro-tcwg-bot/tcwg_gcc_build--master-aarch64 | warning | Patch is already merged |
Commit Message
Andrew Pinski
Feb. 16, 2024, 7 p.m. UTC
This testcase was fixed by r14-5934-gf26d68d5d128c8 but we should add
one to make sure it does not regress again.
Committed as obvious after a quick test on the testcase.
PR c++/97990
gcc/testsuite/ChangeLog:
* g++.dg/torture/vector-struct-1.C: New test.
Signed-off-by: Andrew Pinski <quic_apinski@quicinc.com>
---
gcc/testsuite/g++.dg/torture/vector-struct-1.C | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
create mode 100644 gcc/testsuite/g++.dg/torture/vector-struct-1.C
Comments
On Fri, Feb 16, 2024 at 11:00:34AM -0800, Andrew Pinski wrote: > This testcase was fixed by r14-5934-gf26d68d5d128c8 but we should add > one to make sure it does not regress again. > > Committed as obvious after a quick test on the testcase. > > PR c++/97990 > > gcc/testsuite/ChangeLog: > > * g++.dg/torture/vector-struct-1.C: New test. > > Signed-off-by: Andrew Pinski <quic_apinski@quicinc.com> > --- > gcc/testsuite/g++.dg/torture/vector-struct-1.C | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > create mode 100644 gcc/testsuite/g++.dg/torture/vector-struct-1.C > > diff --git a/gcc/testsuite/g++.dg/torture/vector-struct-1.C b/gcc/testsuite/g++.dg/torture/vector-struct-1.C > new file mode 100644 > index 00000000000..e2747417e2d > --- /dev/null > +++ b/gcc/testsuite/g++.dg/torture/vector-struct-1.C > @@ -0,0 +1,18 @@ > +/* PR c++/97990 */ > +/* This used to crash with lto and strict aliasing enabled as the > + vector type variant still had TYPE_ALIAS_SET set on it. */ You don't have -Wstrict-aliasing here without which the test didn't ICE. > +typedef __attribute__((__vector_size__(sizeof(short)))) short TSimd; > +TSimd hh(int); > +struct y6 > +{ > + TSimd VALUE; > + ~y6(); > +}; > +template <class T1,class T2> > +auto f2(T1 p1, T2){ > + return hh(p1) <= 0; > +} > +void f1(){ > + f2(0, y6{}); > +} > -- > 2.43.0 > Marek
> -----Original Message----- > From: Marek Polacek <polacek@redhat.com> > Sent: Friday, February 16, 2024 11:11 AM > To: Andrew Pinski (QUIC) <quic_apinski@quicinc.com> > Cc: gcc-patches@gcc.gnu.org > Subject: Re: [COMMITTED] c++: Add testcase for this PR [PR97990] > > On Fri, Feb 16, 2024 at 11:00:34AM -0800, Andrew Pinski wrote: > > This testcase was fixed by r14-5934-gf26d68d5d128c8 but we should add > > one to make sure it does not regress again. > > > > Committed as obvious after a quick test on the testcase. > > > > PR c++/97990 > > > > gcc/testsuite/ChangeLog: > > > > * g++.dg/torture/vector-struct-1.C: New test. > > > > Signed-off-by: Andrew Pinski <quic_apinski@quicinc.com> > > --- > > gcc/testsuite/g++.dg/torture/vector-struct-1.C | 18 > > ++++++++++++++++++ > > 1 file changed, 18 insertions(+) > > create mode 100644 gcc/testsuite/g++.dg/torture/vector-struct-1.C > > > > diff --git a/gcc/testsuite/g++.dg/torture/vector-struct-1.C > > b/gcc/testsuite/g++.dg/torture/vector-struct-1.C > > new file mode 100644 > > index 00000000000..e2747417e2d > > --- /dev/null > > +++ b/gcc/testsuite/g++.dg/torture/vector-struct-1.C > > @@ -0,0 +1,18 @@ > > +/* PR c++/97990 */ > > +/* This used to crash with lto and strict aliasing enabled as the > > + vector type variant still had TYPE_ALIAS_SET set on it. */ > > You don't have -Wstrict-aliasing here without which the test didn't ICE. Oh you are correct. This is what I committed after testing to make sure it even ICEd before the reference commit. Thanks, Andrew Pinski > > > +typedef __attribute__((__vector_size__(sizeof(short)))) short TSimd; > > +TSimd hh(int); struct y6 { > > + TSimd VALUE; > > + ~y6(); > > +}; > > +template <class T1,class T2> > > +auto f2(T1 p1, T2){ > > + return hh(p1) <= 0; > > +} > > +void f1(){ > > + f2(0, y6{}); > > +} > > -- > > 2.43.0 > > > > Marek
diff --git a/gcc/testsuite/g++.dg/torture/vector-struct-1.C b/gcc/testsuite/g++.dg/torture/vector-struct-1.C new file mode 100644 index 00000000000..e2747417e2d --- /dev/null +++ b/gcc/testsuite/g++.dg/torture/vector-struct-1.C @@ -0,0 +1,18 @@ +/* PR c++/97990 */ +/* This used to crash with lto and strict aliasing enabled as the + vector type variant still had TYPE_ALIAS_SET set on it. */ + +typedef __attribute__((__vector_size__(sizeof(short)))) short TSimd; +TSimd hh(int); +struct y6 +{ + TSimd VALUE; + ~y6(); +}; +template <class T1,class T2> +auto f2(T1 p1, T2){ + return hh(p1) <= 0; +} +void f1(){ + f2(0, y6{}); +}