[COMMITTED,081/101] gccrs: Generate error for `async` trait fucntions

Message ID 20240130121026.807464-84-arthur.cohen@embecosm.com
State Committed
Commit 81fcf1087ccaa83088aaed8b8be9777e66d2465d
Headers
Series [COMMITTED,001/101] gccrs: Add visibility to trait item |

Commit Message

Arthur Cohen Jan. 30, 2024, 12:07 p.m. UTC
  From: Kushal Pal <kushalpal109@gmail.com>

Fixes #2767

gcc/rust/ChangeLog:

	* checks/errors/rust-ast-validation.cc (ASTValidation::visit):
	Added check for `async` function inside trait.

gcc/testsuite/ChangeLog:

	* rust/compile/issue-2767.rs: New test.

Signed-off-by: Kushal Pal <kushalpal109@gmail.com>
---
 gcc/rust/checks/errors/rust-ast-validation.cc |  5 +++++
 gcc/testsuite/rust/compile/issue-2767.rs      | 13 +++++++++++++
 2 files changed, 18 insertions(+)
 create mode 100644 gcc/testsuite/rust/compile/issue-2767.rs
  

Patch

diff --git a/gcc/rust/checks/errors/rust-ast-validation.cc b/gcc/rust/checks/errors/rust-ast-validation.cc
index cd197fc1ea7..b50e9cdf858 100644
--- a/gcc/rust/checks/errors/rust-ast-validation.cc
+++ b/gcc/rust/checks/errors/rust-ast-validation.cc
@@ -107,6 +107,11 @@  ASTValidation::visit (AST::Function &function)
     rust_error_at (function.get_locus (), ErrorCode::E0379,
 		   "functions in traits cannot be declared const");
 
+  // may change soon
+  if (qualifiers.is_async () && context.back () == Context::TRAIT_IMPL)
+    rust_error_at (function.get_locus (), ErrorCode::E0706,
+		   "functions in traits cannot be declared %<async%>");
+
   if (valid_context.find (context.back ()) == valid_context.end ()
       && function.has_self_param ())
     rust_error_at (
diff --git a/gcc/testsuite/rust/compile/issue-2767.rs b/gcc/testsuite/rust/compile/issue-2767.rs
new file mode 100644
index 00000000000..9e7e0f983d2
--- /dev/null
+++ b/gcc/testsuite/rust/compile/issue-2767.rs
@@ -0,0 +1,13 @@ 
+// { dg-additional-options "-frust-edition=2018" }
+trait Foo {
+    fn f() -> u32;
+}
+
+impl Foo for u32 {
+    async fn f() -> u32 {
+        // { dg-error "functions in traits cannot be declared .async." "" { target *-*-* } .-1 }
+        22
+    }
+}
+
+fn main() {}