diff mbox series

middle-end/111591 - explain why TBAA doesn't need adjustment

Message ID 20231213080001.C1250385C408@sourceware.org
State Committed
Commit 97094d2ffd7d00261e6d7cc5d4a62dc7c2c89b64
Headers
Series middle-end/111591 - explain why TBAA doesn't need adjustment |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_gcc_build--master-arm fail Patch failed to apply
linaro-tcwg-bot/tcwg_gcc_build--master-aarch64 fail Patch failed to apply

Commit Message

Richard Biener Dec. 13, 2023, 7:58 a.m. UTC 
  While tidying the prototype patch I've done for the reduced testcase
in PR111591 and in that process trying to produce a testcase that
is miscompiled by stack slot coalescing and the TBAA info that
remains un-altered I've realized we do not need to adjust TBAA info.

The following documents this in the place we adjust points-to info
which we do need to adjust.

Pushed.  Feel free to poke holes into the argument.

Richard.

	PR middle-end/111591
	* cfgexpand.cc (update_alias_info_with_stack_vars): Document
	why not adjusting TBAA info on accesses is OK.
---
 gcc/cfgexpand.cc | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/gcc/cfgexpand.cc b/gcc/cfgexpand.cc
index 21ba84ab30b..8f6451e44ff 100644
--- a/gcc/cfgexpand.cc
+++ b/gcc/cfgexpand.cc
@@ -786,7 +786,13 @@  add_partitioned_vars_to_ptset (struct pt_solution *pt,
 /* Update points-to sets based on partition info, so we can use them on RTL.
    The bitmaps representing stack partitions will be saved until expand,
    where partitioned decls used as bases in memory expressions will be
-   rewritten.  */
+   rewritten.
+
+   It is not necessary to update TBAA info on accesses to the coalesced
+   storage since our memory model doesn't allow TBAA to be used for
+   WAW or WAR dependences.  For RAW when the write is to an old object
+   the new object would not have been initialized at the point of the
+   read, invoking undefined behavior.  */
 
 static void
 update_alias_info_with_stack_vars (void)