[COMMITTED] ada: Reject aspect Always_Terminates on functions and generic functions

Message ID 20230615080406.939322-1-poulhies@adacore.com
State Committed
Commit fa5aa5d942ace0bb935b88db53542d90b7d3a4cc
Headers
Series [COMMITTED] ada: Reject aspect Always_Terminates on functions and generic functions |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_gcc_build--master-arm success Testing passed

Commit Message

Marc Poulhiès June 15, 2023, 8:04 a.m. UTC
  From: Piotr Trojanek <trojanek@adacore.com>

The recently added aspect Always_Terminates is only allowed on
procedures.

gcc/ada/

	* sem_prag.adb (Analyze_Pragma): Reject pragma Always_Terminates when
	it applies to a function or generic function.

Tested on x86_64-pc-linux-gnu, committed on master.

---
 gcc/ada/sem_prag.adb | 13 +++++++++++++
 1 file changed, 13 insertions(+)
  

Patch

diff --git a/gcc/ada/sem_prag.adb b/gcc/ada/sem_prag.adb
index 1fa946439ee..0febc445b35 100644
--- a/gcc/ada/sem_prag.adb
+++ b/gcc/ada/sem_prag.adb
@@ -13376,6 +13376,19 @@  package body Sem_Prag is
 
             Spec_Id := Unique_Defining_Entity (Subp_Decl);
 
+            --  Pragma Always_Terminates is not allowed on functions
+
+            if Ekind (Spec_Id) = E_Function then
+               Error_Msg_N (Fix_Error
+                 ("pragma % cannot apply to function"), N);
+                  return;
+
+            elsif Ekind (Spec_Id) = E_Generic_Function then
+               Error_Msg_N (Fix_Error
+                 ("pragma % cannot apply to generic function"), N);
+               return;
+            end if;
+
             --  A pragma that applies to a Ghost entity becomes Ghost for the
             --  purposes of legality checks and removal of ignored Ghost code.