testsuite: Add filter for target socket support
Commit Message
The new analyzer tests for sockets are failing on embedded targets.
The newlib and avr-libc C libraries do not support sockets.
At first I considered a coarse filtering on the existing
effective_target_freestanding check. But seeing how lib/target-supports.exp
is slowly turning into a copy of autotools, I kept the tradition and added
a new fine grained "socket" filter.
I also considered adding effective_target_posix, but could not
figure out a reliable C code to perform the check.
Testing done:
- No changes in gcc.sum for x86_64-pc-linux-gnu, with or without this
patch.
- Filtered cases are now UNSUPPORTED instead of failing on AVR and PRU
backends.
Ok for trunk?
gcc/ChangeLog:
* doc/sourcebuild.texi (sockets): Document new check.
gcc/testsuite/ChangeLog:
* gcc.dg/analyzer/fd-accept.c: Require sockets.
* gcc.dg/analyzer/fd-bind.c: Ditto.
* gcc.dg/analyzer/fd-connect.c: Ditto.
* gcc.dg/analyzer/fd-datagram-socket.c: Ditto.
* gcc.dg/analyzer/fd-glibc-byte-stream-connection-server.c:
Ditto.
* gcc.dg/analyzer/fd-glibc-byte-stream-socket.c: Ditto.
* gcc.dg/analyzer/fd-glibc-datagram-client.c: Ditto.
* gcc.dg/analyzer/fd-glibc-datagram-socket.c: Ditto.
* gcc.dg/analyzer/fd-listen.c: Ditto.
* gcc.dg/analyzer/fd-manpage-getaddrinfo-client.c: Ditto.
* gcc.dg/analyzer/fd-mappage-getaddrinfo-server.c: Ditto.
* gcc.dg/analyzer/fd-meaning.c: Ditto.
* gcc.dg/analyzer/fd-socket-meaning.c: Ditto.
* gcc.dg/analyzer/fd-socket-misuse.c: Ditto.
* gcc.dg/analyzer/fd-stream-socket-active-open.c: Ditto.
* gcc.dg/analyzer/fd-stream-socket-passive-open.c: Ditto.
* gcc.dg/analyzer/fd-stream-socket.c: Ditto.
* gcc.dg/analyzer/fd-symbolic-socket.c: Ditto.
* lib/target-supports.exp (check_effective_target_sockets): New
check.
Signed-off-by: Dimitar Dimitrov <dimitar@dinux.eu>
---
gcc/doc/sourcebuild.texi | 3 +++
gcc/testsuite/gcc.dg/analyzer/fd-accept.c | 2 ++
gcc/testsuite/gcc.dg/analyzer/fd-bind.c | 2 ++
gcc/testsuite/gcc.dg/analyzer/fd-connect.c | 2 ++
gcc/testsuite/gcc.dg/analyzer/fd-datagram-socket.c | 2 ++
.../fd-glibc-byte-stream-connection-server.c | 1 +
.../gcc.dg/analyzer/fd-glibc-byte-stream-socket.c | 1 +
.../gcc.dg/analyzer/fd-glibc-datagram-client.c | 1 +
.../gcc.dg/analyzer/fd-glibc-datagram-socket.c | 1 +
gcc/testsuite/gcc.dg/analyzer/fd-listen.c | 2 ++
.../analyzer/fd-manpage-getaddrinfo-client.c | 1 +
.../analyzer/fd-mappage-getaddrinfo-server.c | 2 ++
gcc/testsuite/gcc.dg/analyzer/fd-meaning.c | 2 +-
gcc/testsuite/gcc.dg/analyzer/fd-socket-meaning.c | 1 +
gcc/testsuite/gcc.dg/analyzer/fd-socket-misuse.c | 2 ++
.../gcc.dg/analyzer/fd-stream-socket-active-open.c | 2 ++
.../analyzer/fd-stream-socket-passive-open.c | 2 ++
gcc/testsuite/gcc.dg/analyzer/fd-stream-socket.c | 2 ++
gcc/testsuite/gcc.dg/analyzer/fd-symbolic-socket.c | 2 ++
gcc/testsuite/lib/target-supports.exp | 14 ++++++++++++++
20 files changed, 46 insertions(+), 1 deletion(-)
Comments
On 11/20/22 03:02, Dimitar Dimitrov wrote:
> The new analyzer tests for sockets are failing on embedded targets.
> The newlib and avr-libc C libraries do not support sockets.
>
> At first I considered a coarse filtering on the existing
> effective_target_freestanding check. But seeing how lib/target-supports.exp
> is slowly turning into a copy of autotools, I kept the tradition and added
> a new fine grained "socket" filter.
>
> I also considered adding effective_target_posix, but could not
> figure out a reliable C code to perform the check.
>
> Testing done:
> - No changes in gcc.sum for x86_64-pc-linux-gnu, with or without this
> patch.
> - Filtered cases are now UNSUPPORTED instead of failing on AVR and PRU
> backends.
>
> Ok for trunk?
>
> gcc/ChangeLog:
>
> * doc/sourcebuild.texi (sockets): Document new check.
>
> gcc/testsuite/ChangeLog:
>
> * gcc.dg/analyzer/fd-accept.c: Require sockets.
> * gcc.dg/analyzer/fd-bind.c: Ditto.
> * gcc.dg/analyzer/fd-connect.c: Ditto.
> * gcc.dg/analyzer/fd-datagram-socket.c: Ditto.
> * gcc.dg/analyzer/fd-glibc-byte-stream-connection-server.c:
> Ditto.
> * gcc.dg/analyzer/fd-glibc-byte-stream-socket.c: Ditto.
> * gcc.dg/analyzer/fd-glibc-datagram-client.c: Ditto.
> * gcc.dg/analyzer/fd-glibc-datagram-socket.c: Ditto.
> * gcc.dg/analyzer/fd-listen.c: Ditto.
> * gcc.dg/analyzer/fd-manpage-getaddrinfo-client.c: Ditto.
> * gcc.dg/analyzer/fd-mappage-getaddrinfo-server.c: Ditto.
> * gcc.dg/analyzer/fd-meaning.c: Ditto.
> * gcc.dg/analyzer/fd-socket-meaning.c: Ditto.
> * gcc.dg/analyzer/fd-socket-misuse.c: Ditto.
> * gcc.dg/analyzer/fd-stream-socket-active-open.c: Ditto.
> * gcc.dg/analyzer/fd-stream-socket-passive-open.c: Ditto.
> * gcc.dg/analyzer/fd-stream-socket.c: Ditto.
> * gcc.dg/analyzer/fd-symbolic-socket.c: Ditto.
> * lib/target-supports.exp (check_effective_target_sockets): New
> check.
OK
jeff
@@ -2666,6 +2666,9 @@ Target can compile using @code{pthread.h} with no errors or warnings.
@item pthread_h
Target has @code{pthread.h}.
+@item sockets
+Target can compile using @code{sys/socket.h} with no errors or warnings.
+
@item run_expensive_tests
Expensive testcases (usually those that consume excessive amounts of CPU
time) should be run on this target. This can be enabled by setting the
@@ -1,3 +1,5 @@
+/* { dg-require-effective-target sockets } */
+
#include <sys/socket.h>
#include <sys/un.h>
#include <unistd.h>
@@ -1,3 +1,5 @@
+/* { dg-require-effective-target sockets } */
+
#include <sys/socket.h>
#include <sys/un.h>
#include <unistd.h>
@@ -1,3 +1,5 @@
+/* { dg-require-effective-target sockets } */
+
#include <sys/socket.h>
#include <sys/un.h>
#include <unistd.h>
@@ -1,3 +1,5 @@
+/* { dg-require-effective-target sockets } */
+
#include <sys/socket.h>
#include <sys/un.h>
#include <unistd.h>
@@ -1,4 +1,5 @@
/* Example from glibc manual (16.9.7). */
+/* { dg-require-effective-target sockets } */
/* { dg-additional-options "-Wno-analyzer-too-complex" } */
#include <stdio.h>
@@ -1,4 +1,5 @@
/* Example from glibc manual (16.9.6). */
+/* { dg-require-effective-target sockets } */
#include <stdio.h>
#include <string.h>
@@ -1,4 +1,5 @@
/* Example from the glibc manual (16.10.4). */
+/* { dg-require-effective-target sockets } */
#include <stdio.h>
#include <errno.h>
@@ -1,4 +1,5 @@
/* Example from glibc manual (16.10.3). */
+/* { dg-require-effective-target sockets } */
#include <stdio.h>
#include <errno.h>
@@ -1,3 +1,5 @@
+/* { dg-require-effective-target sockets } */
+
#include <sys/socket.h>
#include <sys/un.h>
#include <unistd.h>
@@ -26,6 +26,7 @@ Formatted or processed versions of this manual, if unaccompanied by
the source, must acknowledge the copyright and authors of this work.
*/
+/* { dg-require-effective-target sockets } */
/* { dg-additional-options "-Wno-analyzer-too-complex" } */
#include <sys/types.h>
@@ -26,6 +26,8 @@ Formatted or processed versions of this manual, if unaccompanied by
the source, must acknowledge the copyright and authors of this work.
*/
+/* { dg-require-effective-target sockets } */
+
#include <sys/types.h>
#include <stdio.h>
#include <stdlib.h>
@@ -34,4 +34,4 @@ void test_3 (const char* path)
close(fd); /* { dg-message "meaning: \\{verb: 'release', noun: 'resource'\\}" } */
close(fd); /* { dg-warning "double 'close' of file descriptor 'fd' \\\[CWE-1341\\\]" } */
}
-}
\ No newline at end of file
+}
@@ -1,3 +1,4 @@
+/* { dg-require-effective-target sockets } */
/* { dg-additional-options "-fanalyzer-verbose-state-changes" } */
#include <sys/socket.h>
@@ -1,5 +1,7 @@
/* Various operations done on sockets in the wrong phase. */
+/* { dg-require-effective-target sockets } */
+
#include <sys/types.h>
#include <sys/stat.h>
#include <fcntl.h>
@@ -1,3 +1,5 @@
+/* { dg-require-effective-target sockets } */
+
#include <sys/socket.h>
#include <sys/un.h>
#include <unistd.h>
@@ -2,6 +2,8 @@
either from scratch, or when various phases are assumed to already
be done. */
+/* { dg-require-effective-target sockets } */
+
#include <sys/socket.h>
#include <sys/un.h>
#include <unistd.h>
@@ -1,3 +1,5 @@
+/* { dg-require-effective-target sockets } */
+
#include <sys/socket.h>
#include <sys/un.h>
#include <unistd.h>
@@ -1,3 +1,5 @@
+/* { dg-require-effective-target sockets } */
+
#include <sys/socket.h>
#include <sys/un.h>
#include <unistd.h>
@@ -1176,6 +1176,20 @@ proc check_effective_target_pthread {} {
} "-pthread"]
}
+# Return 1 if the target supports both Unix and internet sockets, 0 otherwise.
+proc check_effective_target_sockets {} {
+ return [check_no_compiler_messages socket executable {
+#include <sys/socket.h>
+#include <sys/un.h>
+#include <netinet/in.h>
+int main (void) {
+ socket(AF_UNIX, SOCK_STREAM, 0);
+ socket(AF_INET, SOCK_DGRAM, 0);
+ return 0;
+}
+ } ""]
+}
+
# Return 1 if compilation with -mpe-aligned-commons is error-free
# for trivial code, 0 otherwise.