diff mbox series

i386: Fix *aes<aeswideklvariant>u8

Message ID 20220119014015.GP2646553@tucnak
State New
Headers
Series i386: Fix *aes<aeswideklvariant>u8 |

Commit Message

Jakub Jelinek Jan. 19, 2022, 1:40 a.m. UTC 
  Hi!

On Wed, Jan 19, 2022 at 09:09:41AM +0800, Hongtao Liu wrote:
> > Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk?
> Yes, thanks.

Thanks.  Committed.
grep '{[^|}]*}"' *.md

found another spot, though dunno if we have sufficient effective targets
etc. to add an -masm=intel test for it (and my installed binutils doesn't
support it anyway).
Binutils trunk testsuite shows the argument isn't omitted even in the Intel
syntax:
grep aesencwide *.s
keylocker.s:	aesencwide128kl	126(%edx)
keylocker.s:	aesencwide256kl	126(%edx)
keylocker.s:	aesencwide128kl	[edx+126]
keylocker.s:	aesencwide256kl	[edx+126]
property-10.s:	 aesencwide128kl (%eax)
x86-64-keylocker.s:	aesencwide128kl	126(%rdx)
x86-64-keylocker.s:	aesencwide256kl	126(%rdx)
x86-64-keylocker.s:	aesencwide128kl	[rdx+126]
x86-64-keylocker.s:	aesencwide256kl	[rdx+126]
and doesn't use any WHATEVER PTR.

Ok for trunk?

2022-01-19  Jakub Jelinek  <jakub@redhat.com>

	* config/i386/sse.md (*aes<aeswideklvariant>u*): Use %0 instead of
	{%0}.



	Jakub

Comments

Hongtao Liu Jan. 19, 2022, 1:47 a.m. UTC | #1 
On Wed, Jan 19, 2022 at 9:40 AM Jakub Jelinek <jakub@redhat.com> wrote:
>
> Hi!
>
> On Wed, Jan 19, 2022 at 09:09:41AM +0800, Hongtao Liu wrote:
> > > Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk?
> > Yes, thanks.
>
> Thanks.  Committed.
> grep '{[^|}]*}"' *.md
>
> found another spot, though dunno if we have sufficient effective targets
> etc. to add an -masm=intel test for it (and my installed binutils doesn't
> support it anyway).
> Binutils trunk testsuite shows the argument isn't omitted even in the Intel
> syntax:
> grep aesencwide *.s
> keylocker.s:    aesencwide128kl 126(%edx)
> keylocker.s:    aesencwide256kl 126(%edx)
> keylocker.s:    aesencwide128kl [edx+126]
> keylocker.s:    aesencwide256kl [edx+126]
> property-10.s:   aesencwide128kl (%eax)
> x86-64-keylocker.s:     aesencwide128kl 126(%rdx)
> x86-64-keylocker.s:     aesencwide256kl 126(%rdx)
> x86-64-keylocker.s:     aesencwide128kl [rdx+126]
> x86-64-keylocker.s:     aesencwide256kl [rdx+126]
> and doesn't use any WHATEVER PTR.
>
> Ok for trunk?
Yes, thanks again.
>
> 2022-01-19  Jakub Jelinek  <jakub@redhat.com>
>
>         * config/i386/sse.md (*aes<aeswideklvariant>u*): Use %0 instead of
>         {%0}.
>
> --- gcc/config/i386/sse.md.jj   2022-01-19 02:23:59.762022574 +0100
> +++ gcc/config/i386/sse.md      2022-01-19 02:32:07.953324150 +0100
> @@ -28437,7 +28437,7 @@ (define_insn "*aes<aeswideklvariant>u8"
>             [(match_operand:BLK 0 "memory_operand" "m")]
>             AESDECENCWIDEKL))])]
>    "TARGET_WIDEKL"
> -  "aes<aeswideklvariant>\t{%0}"
> +  "aes<aeswideklvariant>\t%0"
>    [(set_attr "type" "other")])
>
>  ;; Modes handled by broadcast patterns.  NB: Allow V64QI and V32HI with
>
>
>         Jakub
>
diff mbox series

Patch

--- gcc/config/i386/sse.md.jj	2022-01-19 02:23:59.762022574 +0100
+++ gcc/config/i386/sse.md	2022-01-19 02:32:07.953324150 +0100
@@ -28437,7 +28437,7 @@  (define_insn "*aes<aeswideklvariant>u8"
 	    [(match_operand:BLK 0 "memory_operand" "m")]
 	    AESDECENCWIDEKL))])]
   "TARGET_WIDEKL"
-  "aes<aeswideklvariant>\t{%0}"
+  "aes<aeswideklvariant>\t%0"
   [(set_attr "type" "other")])
 
 ;; Modes handled by broadcast patterns.  NB: Allow V64QI and V32HI with