diff mbox series

[pushed] Darwin : Make trampoline templates linker-visible.

Message ID 20211105210529.8817-1-iain@sandoe.co.uk
State Committed
Commit f1e2879ecfc8897df0e25a53e81d1868363c5e08
Headers
Series [pushed] Darwin : Make trampoline templates linker-visible. |

Commit Message

Iain Sandoe Nov. 5, 2021, 9:05 p.m. UTC 
  For aarch64, the alignment of the LTRAMPn symbols matters.

Actually, the LTRAMPn  symbols _are_ 8 byte aligned, but because
they are Local, the linker doesn't know that this guarantee can be met.
It assumes that they are not necessarily more aligned than the
containing section (ld64 atoms strike again).

The fix is to publish the trampoline symbol for the linker to access
directly - it can then see that the atom is suitably aligned.

Fixes issue #11 on the development branch.

Tested on x86_64-darwin, aarch64-darwin and x86_64-linux,
pushed to master, thanks
Iain

Signed-off-by: Iain Sandoe <iain@sandoe.co.uk>

gcc/ChangeLog:

	* config/darwin.h (ASM_GENERATE_INTERNAL_LABEL): Add LTRAMP
	to the list of symbol prefixes that must be made linker-
	visible.
---
 gcc/config/darwin.h | 2 ++
 1 file changed, 2 insertions(+)
diff mbox series

Patch

diff --git a/gcc/config/darwin.h b/gcc/config/darwin.h
index 27cb3e4bb30..e54cbb11cee 100644
--- a/gcc/config/darwin.h
+++ b/gcc/config/darwin.h
@@ -921,6 +921,8 @@  extern GTY(()) section * darwin_sections[NUM_DARWIN_SECTIONS];
       sprintf (LABEL, "*%s%ld", "lubsan_type", (long)(NUM));\
     else if (strcmp ("LASAN", PREFIX) == 0)	\
       sprintf (LABEL, "*%s%ld", "lASAN", (long)(NUM));\
+    else if (strcmp ("LTRAMP", PREFIX) == 0)	\
+      sprintf (LABEL, "*%s%ld", "lTRAMP", (long)(NUM));\
     else						\
       sprintf (LABEL, "*%s%ld", PREFIX, (long)(NUM));	\
   } while (0)