diff mbox series

[1/4] Add dump prints when execute_fixup_cfg removes a write only var store.

Message ID 1634619244-18969-2-git-send-email-apinski@marvell.com
State Committed
Commit 005ebe1c07843e6312cd70523945fa1d729e7253
Headers
Series Fix PR tree-opt/102703 |

Commit Message

Li, Pan2 via Gcc-patches Oct. 19, 2021, 4:54 a.m. UTC 
  From: Andrew Pinski <apinski@marvell.com>

While debugging PR 102703, I found it was hard to figure out where
the store was being removed as there was no pass which was outputting
why the store was removed.
This adds to execute_fixup_cfg the output.
Also note most of removals happen when execute_fixup_cfg is called
from the inliner.

gcc/ChangeLog:

	* tree-cfg.c (execute_fixup_cfg): Output when the statement
	is removed when it is a write only var.
---
 gcc/tree-cfg.c | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Jeff Law Oct. 19, 2021, 11:10 p.m. UTC | #1 
On 10/18/2021 10:54 PM, apinski--- via Gcc-patches wrote:
> From: Andrew Pinski <apinski@marvell.com>
>
> While debugging PR 102703, I found it was hard to figure out where
> the store was being removed as there was no pass which was outputting
> why the store was removed.
> This adds to execute_fixup_cfg the output.
> Also note most of removals happen when execute_fixup_cfg is called
> from the inliner.
>
> gcc/ChangeLog:
>
> 	* tree-cfg.c (execute_fixup_cfg): Output when the statement
> 	is removed when it is a write only var.
OK
jeff
diff mbox series

Patch

diff --git a/gcc/tree-cfg.c b/gcc/tree-cfg.c
index 4b4b0b52d9a..b78e4564e4d 100644
--- a/gcc/tree-cfg.c
+++ b/gcc/tree-cfg.c
@@ -9737,6 +9737,13 @@  execute_fixup_cfg (void)
 		  && (TREE_STATIC (lhs) || DECL_EXTERNAL (lhs))
 		  && varpool_node::get (lhs)->writeonly)
 		{
+		  if (dump_file && (dump_flags & TDF_DETAILS))
+		    {
+		      fprintf (dump_file, "Removing statement, writes"
+		               " to write only var:\n");
+		      print_gimple_stmt (dump_file, stmt, 0,
+					 TDF_VOPS|TDF_MEMSYMS);
+		    }
 		  unlink_stmt_vdef (stmt);
 		  gsi_remove (&gsi, true);
 		  release_defs (stmt);