diff mbox series

aarch64: Enable +cssc for armv8.9-a

Message ID fc4cd055-74fc-407c-e0f9-b9a8fd52aba4@e124511.cambridge.arm.com
State Changes Requested
Headers
Series aarch64: Enable +cssc for armv8.9-a |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_binutils_build--master-arm success Testing passed
linaro-tcwg-bot/tcwg_binutils_build--master-aarch64 success Testing passed
linaro-tcwg-bot/tcwg_binutils_check--master-aarch64 success Testing passed
linaro-tcwg-bot/tcwg_binutils_check--master-arm success Testing passed

Commit Message

Andrew Carlotti May 13, 2024, 2:01 p.m. UTC 
  FEAT_CSSC is mandatory in the architecture from Armv8.9.

---

OK for master and backport to 2.42 branch?

Comments

Richard Earnshaw (lists) May 20, 2024, 2:03 p.m. UTC | #1 
On 13/05/2024 15:01, Andrew Carlotti wrote:
> FEAT_CSSC is mandatory in the architecture from Armv8.9.
> 
> ---
> 
> OK for master and backport to 2.42 branch?

The Arm ARM says that CSSC is only mandatory if AdvSIMD is present.  So I think we need a test that this is
removed if we have -march=armv8.9-a+nosimd.

R.

> 
> 
> diff --git a/gas/testsuite/gas/aarch64/cssc.d b/gas/testsuite/gas/aarch64/cssc.d
> index d41df24b916d26b0c71ad0435f3e83090268e4e7..f6ff9d207a2fd876793ac3769e87b524201d8cbb 100644
> --- a/gas/testsuite/gas/aarch64/cssc.d
> +++ b/gas/testsuite/gas/aarch64/cssc.d
> @@ -1,5 +1,6 @@
>  #name: CSSC extension
>  #as: -march=armv8-a+cssc
> +#as: -march=armv8.9-a
>  #objdump: -dr
>  
>  .*:     file format .*
> diff --git a/include/opcode/aarch64.h b/include/opcode/aarch64.h
> index 2fca9528c2012be983c2414a30fa5930e57e5c92..2d327e830497945cd691754176e4130e30ede492 100644
> --- a/include/opcode/aarch64.h
> +++ b/include/opcode/aarch64.h
> @@ -291,6 +291,7 @@ enum aarch64_feature_bit {
>  					 | AARCH64_FEATBIT (X, MOPS)	\
>  					 | AARCH64_FEATBIT (X, HBC))
>  #define AARCH64_ARCH_V8_9A_FEATURES(X)	(AARCH64_FEATBIT (X, V8_9A)	\
> +					 | AARCH64_FEATBIT (X, CSSC) \
>  					 | AARCH64_FEATBIT (X, SPEv1p4) \
>  					 | AARCH64_FEATBIT (X, SPE_CRR)	\
>  					 | AARCH64_FEATBIT (X, SPE_FDS) \
Andrew Carlotti May 20, 2024, 3 p.m. UTC | #2 
On Mon, May 20, 2024 at 03:03:46PM +0100, Richard Earnshaw (lists) wrote:
> On 13/05/2024 15:01, Andrew Carlotti wrote:
> > FEAT_CSSC is mandatory in the architecture from Armv8.9.
> > 
> > ---
> > 
> > OK for master and backport to 2.42 branch?
> 
> The Arm ARM says that CSSC is only mandatory if AdvSIMD is present.  So I think we need a test that this is
> removed if we have -march=armv8.9-a+nosimd.
> 
> R.

FEAT_CSSC does not depend upon FEAT_AdvSIMD, so `+cssc` does not enable
`+simd`, and conversely `+nosimd` does not disable `+cssc`.

Our `-march=armv8.x` flags are based upon which features are mandatory in an
Armv8.x system with FEAT_AdvSIMD present, but are subsequently treated as
equivalent to having specified these features as a set of independent feature
flags.  `+nosimd` will disable anything that explicitly depends on
FEAT_AdvSIMD, but does not disable any additional features that were included
in the base architecture, even if they were only included in the base
architecture as a consquence of the assumed presence of FEAT_AdvSIMD.

Incidentally, our `march=armv9.y` flags are similarly based upon which features
are mandatory in an Armv9.y system with FEAT_SVE2 present.

> > 
> > 
> > diff --git a/gas/testsuite/gas/aarch64/cssc.d b/gas/testsuite/gas/aarch64/cssc.d
> > index d41df24b916d26b0c71ad0435f3e83090268e4e7..f6ff9d207a2fd876793ac3769e87b524201d8cbb 100644
> > --- a/gas/testsuite/gas/aarch64/cssc.d
> > +++ b/gas/testsuite/gas/aarch64/cssc.d
> > @@ -1,5 +1,6 @@
> >  #name: CSSC extension
> >  #as: -march=armv8-a+cssc
> > +#as: -march=armv8.9-a
> >  #objdump: -dr
> >  
> >  .*:     file format .*
> > diff --git a/include/opcode/aarch64.h b/include/opcode/aarch64.h
> > index 2fca9528c2012be983c2414a30fa5930e57e5c92..2d327e830497945cd691754176e4130e30ede492 100644
> > --- a/include/opcode/aarch64.h
> > +++ b/include/opcode/aarch64.h
> > @@ -291,6 +291,7 @@ enum aarch64_feature_bit {
> >  					 | AARCH64_FEATBIT (X, MOPS)	\
> >  					 | AARCH64_FEATBIT (X, HBC))
> >  #define AARCH64_ARCH_V8_9A_FEATURES(X)	(AARCH64_FEATBIT (X, V8_9A)	\
> > +					 | AARCH64_FEATBIT (X, CSSC) \
> >  					 | AARCH64_FEATBIT (X, SPEv1p4) \
> >  					 | AARCH64_FEATBIT (X, SPE_CRR)	\
> >  					 | AARCH64_FEATBIT (X, SPE_FDS) \
>
Nick Clifton May 28, 2024, 3:15 p.m. UTC | #3 
Hi Andrew,

> FEAT_CSSC is mandatory in the architecture from Armv8.9.
> 
> ---
> 
> OK for master and backport to 2.42 branch?

Approved - please apply.

Cheers
   Nick
diff mbox series

Patch

diff --git a/gas/testsuite/gas/aarch64/cssc.d b/gas/testsuite/gas/aarch64/cssc.d
index d41df24b916d26b0c71ad0435f3e83090268e4e7..f6ff9d207a2fd876793ac3769e87b524201d8cbb 100644
--- a/gas/testsuite/gas/aarch64/cssc.d
+++ b/gas/testsuite/gas/aarch64/cssc.d
@@ -1,5 +1,6 @@ 
 #name: CSSC extension
 #as: -march=armv8-a+cssc
+#as: -march=armv8.9-a
 #objdump: -dr
 
 .*:     file format .*
diff --git a/include/opcode/aarch64.h b/include/opcode/aarch64.h
index 2fca9528c2012be983c2414a30fa5930e57e5c92..2d327e830497945cd691754176e4130e30ede492 100644
--- a/include/opcode/aarch64.h
+++ b/include/opcode/aarch64.h
@@ -291,6 +291,7 @@  enum aarch64_feature_bit {
 					 | AARCH64_FEATBIT (X, MOPS)	\
 					 | AARCH64_FEATBIT (X, HBC))
 #define AARCH64_ARCH_V8_9A_FEATURES(X)	(AARCH64_FEATBIT (X, V8_9A)	\
+					 | AARCH64_FEATBIT (X, CSSC) \
 					 | AARCH64_FEATBIT (X, SPEv1p4) \
 					 | AARCH64_FEATBIT (X, SPE_CRR)	\
 					 | AARCH64_FEATBIT (X, SPE_FDS) \