diff mbox series

[1/4] readline: Fix examples/rlfe/configure.ac

Message ID 20240606201145.1747021-2-lukeshu@lukeshu.com
State New
Headers
Series Add a ./bootstrap script to automate bundling and generating files |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_binutils_build--master-arm fail Patch failed to apply
linaro-tcwg-bot/tcwg_binutils_build--master-aarch64 fail Patch failed to apply

Commit Message

Luke T. Shumaker June 6, 2024, 8:11 p.m. UTC 
  It has been impossible to run `autoconf` in
`readline/readline/examples/rlfe/` ever since it was moved there from
`readline/readline/examples/rlfe/` in 6999161a2a3 (Move readline to
the readline/readline subdirectory, Tom Tromey, 2019-10-05).  The
confure.ac uses a "../"* sequence to get to the top-directory's
config/override.m4, but another "../" wasn't added when it was moved a
directory deeper.

Fix that; add another "../".  This allows `autoconf` to once again
generate the verbatim `configure` file that is already checked in.
---
 readline/readline/examples/rlfe/configure.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Maciej W. Rozycki June 8, 2024, 6:25 p.m. UTC | #1 
On Thu, 6 Jun 2024, Luke T. Shumaker wrote:

> It has been impossible to run `autoconf` in
> `readline/readline/examples/rlfe/` ever since it was moved there from
> `readline/readline/examples/rlfe/` in 6999161a2a3 (Move readline to

`readline/examples/rlfe/`, presumably?

> the readline/readline subdirectory, Tom Tromey, 2019-10-05).  The
> confure.ac uses a "../"* sequence to get to the top-directory's

configure.in

> config/override.m4, but another "../" wasn't added when it was moved a
> directory deeper.
> 
> Fix that; add another "../".  This allows `autoconf` to once again
> generate the verbatim `configure` file that is already checked in.

 I can't approve this change, but barring the nits pointed out above it 
seems good if not obvious to me.

  Maciej
Maciej W. Rozycki June 8, 2024, 6:28 p.m. UTC | #2 
On Sat, 8 Jun 2024, Maciej W. Rozycki wrote:

> > the readline/readline subdirectory, Tom Tromey, 2019-10-05).  The
> > confure.ac uses a "../"* sequence to get to the top-directory's
> 
> configure.in

 And FAOD ditto in the change heading.

  Maciej
Luke T. Shumaker June 10, 2024, 3:01 a.m. UTC | #3 
On Sat, 08 Jun 2024 12:28:58 -0600,
Maciej W. Rozycki wrote:
> 
> On Sat, 8 Jun 2024, Maciej W. Rozycki wrote:
> 
> > > the readline/readline subdirectory, Tom Tromey, 2019-10-05).  The
> > > confure.ac uses a "../"* sequence to get to the top-directory's
> > 
> > configure.in
> 
>  And FAOD ditto in the change heading.

Thanks for the corrections, I'm including it in v2 (which I'm about to
submit).

What does "FAOD" stand for?
Simon Marchi June 10, 2024, 4:51 p.m. UTC | #4 
On 2024-06-09 23:01, Luke T. Shumaker wrote:
> On Sat, 08 Jun 2024 12:28:58 -0600,
> Maciej W. Rozycki wrote:
>>
>> On Sat, 8 Jun 2024, Maciej W. Rozycki wrote:
>>
>>>> the readline/readline subdirectory, Tom Tromey, 2019-10-05).  The
>>>> confure.ac uses a "../"* sequence to get to the top-directory's
>>>
>>> configure.in
>>
>>  And FAOD ditto in the change heading.
> 
> Thanks for the corrections, I'm including it in v2 (which I'm about to
> submit).
> 
> What does "FAOD" stand for?

According to chatgpt:

  In a discussion, "FAOD" stands for "For Avoidance of Doubt." It's used
  to clarify a point or detail, ensuring there's no misunderstanding
  about what's being communicated. This term is particularly common in
  written communication, such as emails or formal documents, where
  precision in language is crucial to avoid any ambiguity.

Simon
diff mbox series

Patch

diff --git a/readline/readline/examples/rlfe/configure.in b/readline/readline/examples/rlfe/configure.in
index 5c0678ab4d8..4ef9c721a06 100644
--- a/readline/readline/examples/rlfe/configure.in
+++ b/readline/readline/examples/rlfe/configure.in
@@ -1,6 +1,6 @@ 
 dnl Process this file with autoconf to produce a configure script.
 
-m4_include([../../../config/override.m4])
+m4_include([../../../../config/override.m4])
 
 AC_INIT(rlfe.c)
 AC_CONFIG_HEADER(config.h)