diff mbox series

gprofng: 30889 can't compile without large file support

Message ID 20240111040236.1482061-1-vladimir.mezentsev@oracle.com
State New
Headers
Series gprofng: 30889 can't compile without large file support |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_binutils_build--master-arm success Testing passed
linaro-tcwg-bot/tcwg_binutils_build--master-aarch64 success Testing passed
linaro-tcwg-bot/tcwg_binutils_check--master-aarch64 success Testing passed
linaro-tcwg-bot/tcwg_binutils_check--master-arm success Testing passed

Commit Message

Vladimir Mezentsev Jan. 11, 2024, 4:02 a.m. UTC 
  From: Vladimir Mezentsev <vladimir.mezentsev@oracle.com>

gprofng/ChangeLog
2024-01-10  Vladimir Mezentsev  <vladimir.mezentsev@oracle.com>

	PR 30889
	* src/DbeJarFile.cc (O_LARGEFILE): Define to 0, if not defined.
	* src/Module.cc (O_LARGEFILE): Likewise.
	* src/gp-display-src.cc (O_LARGEFILE): Likewise.
---
 gprofng/src/DbeJarFile.cc     | 4 ++++
 gprofng/src/Module.cc         | 4 ++++
 gprofng/src/gp-display-src.cc | 4 ++++
 3 files changed, 12 insertions(+)

Comments

Mike Frysinger Jan. 11, 2024, 5:53 a.m. UTC | #1 
On 10 Jan 2024 20:02, vladimir.mezentsev@oracle.com wrote:
> gprofng/ChangeLog
> 2024-01-10  Vladimir Mezentsev  <vladimir.mezentsev@oracle.com>
> 
> 	PR 30889
> 	* src/DbeJarFile.cc (O_LARGEFILE): Define to 0, if not defined.
> 	* src/Module.cc (O_LARGEFILE): Likewise.
> 	* src/gp-display-src.cc (O_LARGEFILE): Likewise.

can't you put this in a single header file (gprof.h?) instead of duplicating
the boilerplate in a bunch of files ?
-mike
Vladimir Mezentsev Jan. 11, 2024, 8:09 a.m. UTC | #2 
On 1/10/24 21:53, Mike Frysinger wrote:
> On 10 Jan 2024 20:02, vladimir.mezentsev@oracle.com wrote:
>> gprofng/ChangeLog
>> 2024-01-10  Vladimir Mezentsev  <vladimir.mezentsev@oracle.com>
>>
>> 	PR 30889
>> 	* src/DbeJarFile.cc (O_LARGEFILE): Define to 0, if not defined.
>> 	* src/Module.cc (O_LARGEFILE): Likewise.
>> 	* src/gp-display-src.cc (O_LARGEFILE): Likewise.
> can't you put this in a single header file (gprof.h?) instead of duplicating
> the boilerplate in a bunch of files ?
Mike,  thank you for suggestion.
I will try this tomorrow.
Maybe this can be done in gprofng/configure.ac and 
gprofng/common/config.h.in

-Vladimir
> -mike
diff mbox series

Patch

diff --git a/gprofng/src/DbeJarFile.cc b/gprofng/src/DbeJarFile.cc
index fe3427f0b54..d14fd3bb0a6 100644
--- a/gprofng/src/DbeJarFile.cc
+++ b/gprofng/src/DbeJarFile.cc
@@ -30,6 +30,10 @@ 
 #include "Data_window.h"
 #include "vec.h"
 
+#ifndef O_LARGEFILE
+#define O_LARGEFILE 0
+#endif
+
 static uint32_t
 get_u1 (unsigned char *b)
 {
diff --git a/gprofng/src/Module.cc b/gprofng/src/Module.cc
index d5255dcd05f..f59dea1b595 100644
--- a/gprofng/src/Module.cc
+++ b/gprofng/src/Module.cc
@@ -41,6 +41,10 @@ 
 #include "PathTree.h"
 #include "Elf.h"
 
+#ifndef O_LARGEFILE
+#define O_LARGEFILE 0
+#endif
+
 Module::Module ()
 {
   lang_code = Sp_lang_unknown;
diff --git a/gprofng/src/gp-display-src.cc b/gprofng/src/gp-display-src.cc
index 200e6080d2e..78560d49e52 100644
--- a/gprofng/src/gp-display-src.cc
+++ b/gprofng/src/gp-display-src.cc
@@ -33,6 +33,10 @@ 
 #include "DbeFile.h"
 #include "Command.h"
 
+#ifndef O_LARGEFILE
+#define O_LARGEFILE 0
+#endif
+
 class er_src : public DbeApplication
 {
 public: