diff mbox series

[1/2] x86: Don't use .insn with '/'

Message ID 20231229235033.338761-1-hjl.tools@gmail.com
State New
Headers
Series [1/2] x86: Don't use .insn with '/' |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_binutils_build--master-arm warning Patch is already merged
linaro-tcwg-bot/tcwg_binutils_build--master-aarch64 warning Patch is already merged

Commit Message

H.J. Lu Dec. 29, 2023, 11:50 p.m. UTC 
  '/' starts a comment for some targets.  Use .byte instead of .insn with
'/'.

	* testsuite/gas/i386/x86-64-apx-evex-promoted-bad.s: Use .byte
	instead of .insn with '/'.
---
 gas/testsuite/gas/i386/x86-64-apx-evex-promoted-bad.s | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Jan Beulich Jan. 4, 2024, 9:33 a.m. UTC | #1 
On 30.12.2023 00:50, H.J. Lu wrote:
> '/' starts a comment for some targets.  Use .byte instead of .insn with
> '/'.
> 
> 	* testsuite/gas/i386/x86-64-apx-evex-promoted-bad.s: Use .byte
> 	instead of .insn with '/'.

Nack. The proper approach is to pass --divide to gas for such tests. I've
made very clear during review of the APX series that _wherever possible_
the more descriptive .insn should be used in preference to .byte.

Jan

> --- a/gas/testsuite/gas/i386/x86-64-apx-evex-promoted-bad.s
> +++ b/gas/testsuite/gas/i386/x86-64-apx-evex-promoted-bad.s
> @@ -39,11 +39,11 @@ _start:
>  	.insn EVEX.L0.NP.0f38.W1 0xf5, %rax, (%rax,%rbx){1to8}, %rcx
>  
>  	#{evex} inc %rax %rbx EVEX.vvvv != 1111 && EVEX.ND = 0.
> -	.insn EVEX.L0.NP.M4.W1 0xff/0, (%rax,%rcx), %rbx
> +	.byte 0x62, 0xf4, 0xe4, 0x08, 0xff, 0x04, 0x08
>  	# pop2 %rax, %r8 set EVEX.ND=0.
> -	.insn EVEX.L0.M4.W0 0x8f/0,  %rax, %r8
> +	.byte 0x62, 0xf4, 0x3c, 0x08, 0x8f, 0xc0
>  	.byte 0xff, 0xff, 0xff
>  	# pop2 %rax, %r8 set EVEX.vvvv = 1111.
>  	.insn EVEX.L0.M4.W0 0x8f,  %rax, {rn-sae},%r8
>  	# pop2 %r8, %r8.
> -	.insn EVEX.L0.M4.W0 0x8f/0,  %r8,{rn-sae}, %r8
> +	.byte 0x62, 0xd4, 0x3c, 0x18, 0x8f, 0xc0
diff mbox series

Patch

diff --git a/gas/testsuite/gas/i386/x86-64-apx-evex-promoted-bad.s b/gas/testsuite/gas/i386/x86-64-apx-evex-promoted-bad.s
index fde6736e9b2..61ed8824428 100644
--- a/gas/testsuite/gas/i386/x86-64-apx-evex-promoted-bad.s
+++ b/gas/testsuite/gas/i386/x86-64-apx-evex-promoted-bad.s
@@ -39,11 +39,11 @@  _start:
 	.insn EVEX.L0.NP.0f38.W1 0xf5, %rax, (%rax,%rbx){1to8}, %rcx
 
 	#{evex} inc %rax %rbx EVEX.vvvv != 1111 && EVEX.ND = 0.
-	.insn EVEX.L0.NP.M4.W1 0xff/0, (%rax,%rcx), %rbx
+	.byte 0x62, 0xf4, 0xe4, 0x08, 0xff, 0x04, 0x08
 	# pop2 %rax, %r8 set EVEX.ND=0.
-	.insn EVEX.L0.M4.W0 0x8f/0,  %rax, %r8
+	.byte 0x62, 0xf4, 0x3c, 0x08, 0x8f, 0xc0
 	.byte 0xff, 0xff, 0xff
 	# pop2 %rax, %r8 set EVEX.vvvv = 1111.
 	.insn EVEX.L0.M4.W0 0x8f,  %rax, {rn-sae},%r8
 	# pop2 %r8, %r8.
-	.insn EVEX.L0.M4.W0 0x8f/0,  %r8,{rn-sae}, %r8
+	.byte 0x62, 0xd4, 0x3c, 0x18, 0x8f, 0xc0