diff mbox series

gprofng: 31169 Source code locations can not be found in a C++ application

Message ID 20231219175959.3837374-1-vladimir.mezentsev@oracle.com
State New
Headers
Series gprofng: 31169 Source code locations can not be found in a C++ application |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_binutils_build--master-arm success Testing passed
linaro-tcwg-bot/tcwg_binutils_build--master-aarch64 success Testing passed
linaro-tcwg-bot/tcwg_binutils_check--master-aarch64 success Testing passed
linaro-tcwg-bot/tcwg_binutils_check--master-arm success Testing passed

Commit Message

Vladimir Mezentsev Dec. 19, 2023, 5:59 p.m. UTC 
  From: Vladimir Mezentsev <vladimir.mezentsev@oracle.com>

gprofng incorrectly reads the form of the DW_FORM_ref_addr attribute for DWARF
Version 3 or later.
From DWARF specification:
  References that use the attribute form DW_FORM_ref_addr are specified to
  be four bytes in the DWARF 32-bit format and eight bytes in the DWARF
  64-bit format, while DWARF Version 2 specifies that such references have
  the same size as an address on the target system.

2023-12-18  Vladimir Mezentsev  <vladimir.mezentsev@oracle.com>

	PR gprofng/31169
	* src/DwarfLib.cc: Fix the reader for DW_FORM_ref_addr.
---
 gprofng/src/DwarfLib.cc | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/gprofng/src/DwarfLib.cc b/gprofng/src/DwarfLib.cc
index 90c3e6e95a2..62732829517 100644
--- a/gprofng/src/DwarfLib.cc
+++ b/gprofng/src/DwarfLib.cc
@@ -2034,7 +2034,10 @@  DwrCU::set_die (Dwarf_Die die)
 	  atf->u.offset = debug_infoSec->GetULEB128 ();
 	  break;
 	case DW_FORM_ref_addr:
-	  atf->u.offset = debug_infoSec->GetADDR ();
+	  if (version > 2)
+	    atf->u.offset = debug_infoSec->GetRef ();
+	  else
+	    atf->u.offset = debug_infoSec->GetADDR ();
 	  break;
 	case DW_FORM_sec_offset:
 	  atf->u.offset = debug_infoSec->GetRef ();