[13/22] visium: drop .bss and .skip overrides

Message ID 197fe193-abf7-45e1-8db2-2343da226309@suse.com
State New
Headers
Series ELF: correct handling of simplified section directives |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_binutils_build--master-arm success Testing passed
linaro-tcwg-bot/tcwg_binutils_build--master-aarch64 success Testing passed
linaro-tcwg-bot/tcwg_binutils_check--master-aarch64 success Testing passed
linaro-tcwg-bot/tcwg_binutils_check--master-arm success Testing passed

Commit Message

Jan Beulich Dec. 15, 2023, 12:15 p.m. UTC
  The comment in s_bss() looks bogus (perhaps simply stale, or wrongly
copied from another target). It also doesn't look to be a good idea to
override the custom handler that ELF has (afaict doing so broke
.previous as well as sub-section specification).

The override for .skip is simply pointless, for read.c having exactly
the same.

While there also drop two adjacent redundant (with read.h) declarations
(which would be outright dangerous if read.h wasn't included anyway).
  

Patch

--- a/gas/config/tc-visium.c
+++ b/gas/config/tc-visium.c
@@ -163,40 +163,19 @@  tc_gen_reloc (asection *section ATTRIBUT
   return reloc;
 }
 
-extern char *input_line_pointer;
-
-
-static void s_bss (int);
 static void visium_rdata (int);
 
 static void visium_update_parity_bit (char *);
 static char *parse_exp (char *, expressionS *);
 
-/* These are the back-ends for the various machine dependent pseudo-ops.  */
-void demand_empty_rest_of_line (void);
-
-
-static void
-s_bss (int ignore ATTRIBUTE_UNUSED)
-{
-  /* We don't support putting frags in the BSS segment, we fake it
-     by marking in_bss, then looking at s_skip for clues.  */
-
-  subseg_set (bss_section, 0);
-  demand_empty_rest_of_line ();
-}
-
-
 /* This table describes all the machine specific pseudo-ops the assembler
-   has to support. The fields are:
+   has to support, and that aren't handled elsewhere. The fields are:
 
    1: Pseudo-op name without dot.
    2: Function to call to execute this pseudo-op.
    3: Integer arg to pass to the function.  */
 const pseudo_typeS md_pseudo_table[] =
 {
-  {"bss", s_bss, 0},
-  {"skip", s_space, 0},
   {"align", s_align_bytes, 0},
   {"noopt", s_ignore, 0},
   {"optim", s_ignore, 0},