mbox series

[v4,0/2] gas: add command line option to inhibit info messages

Message ID 20241120182444.284872-1-matthieu.longo@arm.com
Headers
Series gas: add command line option to inhibit info messages |

Message

Matthieu Longo Nov. 20, 2024, 6:24 p.m. UTC 
  Hi,

GAS currently emits information messages for context information along warnings. These extra messages might sometimes pollute the test expectations when checking for error message patterns in stderr output.

This patch aims at providing two new flags while preserving the existing behavior if none of the options is provided.
  * --info, similar to the existing --warn flag to enable diagnostic information messages (default behavior).
  * --no-info, similar to the existing --no-warn flag to disable diagnostic information messages.

It also adds the flags to the existing documentation, and command manual.

As an example of its benefit, I used the new flag for the system register tests under gas/testsuite/gas/aarch64/sysreg testsuite, and the info message for macro expansion were removed inside the tests expectations.

Regression tested on aarch64-none-elf, and no regression found.

Ok for binutils-master?

Regards,
Matthieu.

Changes from v0:
- reorder warning options
  https://sourceware.org/pipermail/binutils/2024-June/135232.html
- rename flag_no_infos to flag_no_information.
- documentation: move --no-info and --info flags after warnings flags.
- remove from this patch's scope the tests relying on the line number.
  add a check in output_info() in AArch64 backend.
  check flag_no_information flag and quickly return if enabled, as requested in the previous revision's review.
  https://sourceware.org/pipermail/binutils/2024-June/135231.html

Changes from v1:
- move the '--info' section up to respect alphabetical order.

Changes from v2:
- reorder '--no-info' sections to respect alphabetical order.

Changes from v3:
* patch 1: move '--info' documentation to the letter 'i' as recommended in https://sourceware.org/pipermail/binutils/2024-July/135972.html
* patch 2: no change.


Matthieu Longo (2):
  gas: add new command line options to control diagnostic information
    messages
  aarch64: testsuite: remove macro expansion messages from expected
    error output

 gas/as.c                                      |  18 +-
 gas/as.h                                      |   3 +
 gas/config/tc-aarch64.c                       |   3 +
 gas/doc/as.texi                               |  34 +++
 gas/messages.c                                |   3 +
 gas/testsuite/gas/aarch64/sve-movprfx_26.d    |   2 +-
 gas/testsuite/gas/aarch64/sve-movprfx_26.l    |  13 -
 .../aarch64/sysreg/armv8_9-a-sysregs-bad.d    |   2 +-
 .../aarch64/sysreg/armv8_9-a-sysregs-bad.l    | 250 +-----------------
 .../gas/aarch64/sysreg/illegal-sysreg-3.d     |   2 +-
 .../gas/aarch64/sysreg/illegal-sysreg-3.l     |  20 --
 .../gas/aarch64/sysreg/illegal-sysreg-8.d     |   1 +
 .../gas/aarch64/sysreg/illegal-sysreg-8.l     | 188 -------------
 .../gas/aarch64/sysreg/illegal-sysreg-8b.d    |   1 +
 .../gas/aarch64/sysreg/illegal-sysreg-8b.l    |  29 --
 15 files changed, 66 insertions(+), 503 deletions(-)