[V2,0/7] Add SCFI support for aarch64

Message ID	20240601073456.2715287-1-indu.bhagat@oracle.com
Headers	DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 14D953875DD4 From: Indu Bhagat <indu.bhagat@oracle.com> To: binutils@sourceware.org Cc: Richard.Earnshaw@arm.com, Indu Bhagat <indu.bhagat@oracle.com> Subject: [PATCH,V2 0/7] Add SCFI support for aarch64 Date: Sat, 1 Jun 2024 00:34:49 -0700 Message-ID: <20240601073456.2715287-1-indu.bhagat@oracle.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain MIME-Version: 1.0 Precedence: list Errors-To: binutils-bounces+patchwork=sourceware.org@sourceware.org
Series	Add SCFI support for aarch64 \| [V2,0/7] Add SCFI support for aarch64 [V2,1/7] gas: scfi: make scfi_state_restore_reg function more precise [V2,2/7] opcodes: aarch64: flags to denote subclasses of ldst insns [V2,3/7] opcodes: aarch64: allow FLAGS in CPA_INSN, CPA_SVE_INSNC [V2,4/7] opcodes: aarch64: flags to denote subclasses of arithmetic insns [V2,5/7] opcodes: aarch64: flags to denote subclasses of uncond branches [V2,6/7] gas: aarch64: add experimental support for SCFI [V2,7/7] gas: aarch64: testsuite: add new tests for SCFI

Message ID

20240601073456.2715287-1-indu.bhagat@oracle.com

Headers

DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 14D953875DD4
From: Indu Bhagat <indu.bhagat@oracle.com>
To: binutils@sourceware.org
Cc: Richard.Earnshaw@arm.com, Indu Bhagat <indu.bhagat@oracle.com>
Subject: [PATCH,V2 0/7] Add SCFI support for aarch64
Date: Sat,  1 Jun 2024 00:34:49 -0700
Message-ID: <20240601073456.2715287-1-indu.bhagat@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
 869jvtxu3FYq3cvOoaidUXtIZsvhTU0itaXmiQBDgXFruSiHrig83o4V+m32wlVw0nEyQFaLV0NPmQF3BD5Z2Yh/Kc+T3WDj1lXrbeGJYhgcBw0ayWZsqp0j+rxZFxxSp8kecmJ17v0VPixcJVDdaL05ce5HZg9ck0j0U5eAkd6vy6YSDyFVGCJIzs93GarJ516bfyhxvh0riLXsDAJFhxmOx7bVHauGpx2lR9PqC5/1QTpkiSYgCuTE8V3PXbso3Fg86nKTKWS5/C0h9Rk5yMRqoEHwVD+t0d9dpNX0g6F4fXRgqFSj5HbJ4HXQshG1Jctl7eU0Ik/2wvruguNjso1Sq1wfXhrWZQXT3H10Tsv4jx3sSQRaDHTNxVtnNQmQ9FZOsGyt0EaOBvL4wfwBAi4cYCEyHCvCMhfT388EzNgc1Xr35WBJ+p3003go6KJHpxljsoeTd4j7hLmn8rIm39eyg7Cu8ul4dmn+Yod0+AZ0yLNIgS8CMCD8jqs3j8WhaVjBZmE2996tBgWr3AKrRraZ1iheswoXrYNZzicIsY2+N/duGqut7RMoY3jLUCCsZ19BZjSmfqIngAOI0IH+IYmXnCeJuFrrWXKsZqZGyzacnRL6bbhAI5iFTJYpmsnFT+yqq2yj08yqmk1uC+wChJ7OEz/D+FARuGTmWfKmp0SzbA4TsVpLeXbDrdI5Kvk1zYv6H7MqKZaU3er5hLAncGwiD7JtVDCDLnA0f65iCofZutfgtIot2hDQkwmQUvrNmFjMxFmeEu6AWRKalJxdmk1pJi/ZbZbLZtbpQOVzezLdDWHs40gzDmvEhrZmiimF84i9cBqM3r5WrzDxd9b0BuVZ27mI6w5aXxpRNW6t+KnWaAmNaKOP2cf6MxNwVgfdlrDgw4L3gDl9cYwlVPBzXDBn+beJm6CrrSB/F4QIdT7coksH3pt5yP6OXPS/MarxI1J4ONME5gGVvIfAkt0SyA3/DaX6xCo60CKWb0rE3+HLmQIfy5njjYkRb/rsTSUVVtu/iDMSzjMz6s3WSkfZKFDip0UfAXzXzrRl6iG3WM4WnBmrsyNrcX4zw4iG836/osY9mXcblVW6TM6D7Y+zTQ1fT5sODDJM9j6a3rJSczKFJ7PBSn0oy7X4TdU5WA1BvQzidUI8YWsQU7eAhnlquwHvl5VuUEFEKYCDroY0RxK95hRZ80VLslc4AcgYYA25NagZd55rTjVFOXdeJ0AMeW9eH4tQ6ZDxTxNvxRWR3Raa3TAKBzC9bco1rTZISI99XactEnqo4H3Pb52teD6INMcbneHNVSu+PNTmLkhWmzkGkySBRDMGUPTh5tuxWCHdlTHcTS0hH8+5XKB9dXozgbO8haDCC4ntPU7nB3JJluaBedRy0T62oaLfIcLKWgncGfp2zoxEvATsIE25dP/r4AiVc+v0XA90VDp4qglZwSi0mRknI40YgebZ1/EO3TnQQ733uPun1hawdOtb4XUSVGDSHhdZV1MdUI2GDgtiZejgu7k/zv7UIa1mrv/GTeU5wnPscY7B3kfmrlq0DFwz4H+hRpNaOIEzSEzSgp8mSrtkjNg2S8usyWT4hy4J8DMDsK1gnrqIE3ED/voQep7bokBanOO2gn/HwbCh7rFSjtU=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
 VWLJfO+6bpqErCBqvNPZVhgcCphXHA8ILhJOu0AUmcTD7kUxjgeDx79JpeswDajGyQ71QHeMDNsIOCFTLULexshu3QX14i0Wu+Wg02kGDFNmfEhqeYzuu7GFIgJCNnqIGUunmjbYNtL9y+I65RTpbsatabonQTx6BXupYOpGAVpfdkibjdZszv3nfYiZY95AkGM/dsuP2bYlNXNTV1++rmz6r33GOycs/PWIC7WKX2SYyJIRD8QZBH5L+IAVit1sF1cdx2MD9Y4bR1nUEDHaVgqYG9/BmGQTGtxXJ896RCUW8PxEdb/2lffHxOd/hgsk2x03J26+nO297LbxbtJ753nLAwoT65A3D9eXmyNHYBRt3OolIXO6fmvkGmkRk4wm9XrbH1LrPIYGklVxnX41wgu/+gINczSjP0eEdJZjKgZERBHjEs5PROKK+UxAzMb/qPgHuaEVLZEtFua/WWJVLjMk3Q42iEormluHttfpuefFsOEIpbB+/5bwXIjxj5IVgrCdjPE8lMcfAFUEa5og6SgZnbN1WFoMOWQyxTmEC0jgF1uBJ0EB6ZsUl7Ow2WG/nHxCLv7PQY41/sFTsIkr5Zr3jeCCCtUdXPgweTBUxiU=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 
 1e8feb58-4adc-4872-f72c-08dc820d8b2f
X-MS-Exchange-CrossTenant-AuthSource: 
 MWHPR1001MB2158.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jun 2024 07:36:26.2849 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 
 wgR2PSp3a0xuALuJ/9dv6GrMmaGDSSdPb2ttY/JxrIeR0COmprO13xBxiCjHHd3p5l+E60ohXRfas6//0ujpaA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR10MB7653
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.12.28.16
 definitions=2024-06-01_05,2024-05-30_01,2024-05-17_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=738
 bulkscore=0 spamscore=0
 phishscore=0 adultscore=0 malwarescore=0 suspectscore=0 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2405010000
 definitions=main-2406010057
X-Proofpoint-GUID: vHXPv8ko3dFJZYiq0-7nfRm9JOEBmuJF
X-Proofpoint-ORIG-GUID: vHXPv8ko3dFJZYiq0-7nfRm9JOEBmuJF
X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, KAM_DMARC_QUARANTINE, KAM_NUMSUBJECT, RCVD_IN_DNSWL_LOW,
 RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: binutils@sourceware.org
X-Mailman-Version: 2.1.30
Precedence: list
List-Id: Binutils mailing list <binutils.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/binutils>,
 <mailto:binutils-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/binutils/>
List-Post: <mailto:binutils@sourceware.org>
List-Help: <mailto:binutils-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/binutils>,
 <mailto:binutils-request@sourceware.org?subject=subscribe>
Errors-To: binutils-bounces+patchwork=sourceware.org@sourceware.org

Series

Add SCFI support for aarch64 |

Message

Indu Bhagat June 1, 2024, 7:34 a.m. UTC

  Hi,

This patch series extends GAS support for SCFI to aarch64.

For more details on background, motivation and short notes on design,
please see the link to V1 posting:
https://sourceware.org/pipermail/binutils/2024-April/133557.html

This patch series is V2 where the following review comments have been
addressed:
  - Carve out the ginsn creation functionality in a separate file.
  - Add additional flags in aarch64 insn definition to indicate
    subclasses.

Although self-explanatory, here is the outline of the patches:
  - Patch 1 fixes a bug I ran into while testing the series.
  - Patch 2-5 are new in V2. These patches add new flags for indicating
    subclasses of instructions.
  - Patch 6 and 7 implement the aarch64 ginsn creation and SCFI
    testsuite respectively.

Thanks,
Indu Bhagat (7):
  gas: scfi: make scfi_state_restore_reg function more precise
  opcodes: aarch64: flags to denote subclasses of ldst insns
  opcodes: aarch64: allow FLAGS in CPA_INSN, CPA_SVE_INSNC
  opcodes: aarch64: flags to denote subclasses of arithmetic insns
  opcodes: aarch64: flags to denote subclasses of uncond branches
  gas: aarch64: add experimental support for SCFI
  gas: aarch64: testsuite: add new tests for SCFI

 gas/config/tc-aarch64-ginsn.c                 |  744 ++++++
 gas/config/tc-aarch64.c                       |   15 +
 gas/config/tc-aarch64.h                       |   20 +
 gas/scfi.c                                    |    9 +-
 gas/testsuite/gas/scfi/README                 |    2 +-
 .../gas/scfi/aarch64/ginsn-arith-1.l          |   35 +
 .../gas/scfi/aarch64/ginsn-arith-1.s          |   16 +
 gas/testsuite/gas/scfi/aarch64/ginsn-cofi-1.l |   30 +
 gas/testsuite/gas/scfi/aarch64/ginsn-cofi-1.s |   16 +
 gas/testsuite/gas/scfi/aarch64/ginsn-ldst-1.l |   46 +
 gas/testsuite/gas/scfi/aarch64/ginsn-ldst-1.s |   26 +
 gas/testsuite/gas/scfi/aarch64/ginsn-misc-1.l |   24 +
 gas/testsuite/gas/scfi/aarch64/ginsn-misc-1.s |   11 +
 .../gas/scfi/aarch64/scfi-aarch64.exp         |   64 +
 gas/testsuite/gas/scfi/aarch64/scfi-cb-1.d    |   20 +
 gas/testsuite/gas/scfi/aarch64/scfi-cb-1.l    |    2 +
 gas/testsuite/gas/scfi/aarch64/scfi-cb-1.s    |   14 +
 gas/testsuite/gas/scfi/aarch64/scfi-cfg-1.d   |   31 +
 gas/testsuite/gas/scfi/aarch64/scfi-cfg-1.l   |    2 +
 gas/testsuite/gas/scfi/aarch64/scfi-cfg-1.s   |   46 +
 gas/testsuite/gas/scfi/aarch64/scfi-cfg-2.d   |   40 +
 gas/testsuite/gas/scfi/aarch64/scfi-cfg-2.l   |    2 +
 gas/testsuite/gas/scfi/aarch64/scfi-cfg-2.s   |   42 +
 gas/testsuite/gas/scfi/aarch64/scfi-cfg-3.d   |   32 +
 gas/testsuite/gas/scfi/aarch64/scfi-cfg-3.l   |    2 +
 gas/testsuite/gas/scfi/aarch64/scfi-cfg-3.s   |   34 +
 gas/testsuite/gas/scfi/aarch64/scfi-cfg-4.d   |   41 +
 gas/testsuite/gas/scfi/aarch64/scfi-cfg-4.l   |    2 +
 gas/testsuite/gas/scfi/aarch64/scfi-cfg-4.s   |   41 +
 .../gas/scfi/aarch64/scfi-cond-br-1.d         |   20 +
 .../gas/scfi/aarch64/scfi-cond-br-1.l         |    2 +
 .../gas/scfi/aarch64/scfi-cond-br-1.s         |   13 +
 gas/testsuite/gas/scfi/aarch64/scfi-diag-1.l  |    2 +
 gas/testsuite/gas/scfi/aarch64/scfi-diag-1.s  |    6 +
 gas/testsuite/gas/scfi/aarch64/scfi-diag-2.l  |    3 +
 gas/testsuite/gas/scfi/aarch64/scfi-diag-2.s  |   25 +
 gas/testsuite/gas/scfi/aarch64/scfi-ldrp-1.d  |   59 +
 gas/testsuite/gas/scfi/aarch64/scfi-ldrp-1.l  |    2 +
 gas/testsuite/gas/scfi/aarch64/scfi-ldrp-1.s  |   52 +
 gas/testsuite/gas/scfi/aarch64/scfi-ldrp-2.d  |   33 +
 gas/testsuite/gas/scfi/aarch64/scfi-ldrp-2.l  |    2 +
 gas/testsuite/gas/scfi/aarch64/scfi-ldrp-2.s  |   26 +
 gas/testsuite/gas/scfi/aarch64/scfi-strp-1.d  |   39 +
 gas/testsuite/gas/scfi/aarch64/scfi-strp-1.l  |    2 +
 gas/testsuite/gas/scfi/aarch64/scfi-strp-1.s  |   37 +
 gas/testsuite/gas/scfi/aarch64/scfi-strp-2.d  |   35 +
 gas/testsuite/gas/scfi/aarch64/scfi-strp-2.l  |    2 +
 gas/testsuite/gas/scfi/aarch64/scfi-strp-2.s  |   30 +
 .../gas/scfi/aarch64/scfi-unsupported-1.l     |    4 +
 .../gas/scfi/aarch64/scfi-unsupported-1.s     |   31 +
 include/opcode/aarch64.h                      |   16 +-
 opcodes/aarch64-tbl.h                         | 2190 ++++++++---------
 52 files changed, 2939 insertions(+), 1101 deletions(-)
 create mode 100644 gas/config/tc-aarch64-ginsn.c
 create mode 100644 gas/testsuite/gas/scfi/aarch64/ginsn-arith-1.l
 create mode 100644 gas/testsuite/gas/scfi/aarch64/ginsn-arith-1.s
 create mode 100644 gas/testsuite/gas/scfi/aarch64/ginsn-cofi-1.l
 create mode 100644 gas/testsuite/gas/scfi/aarch64/ginsn-cofi-1.s
 create mode 100644 gas/testsuite/gas/scfi/aarch64/ginsn-ldst-1.l
 create mode 100644 gas/testsuite/gas/scfi/aarch64/ginsn-ldst-1.s
 create mode 100644 gas/testsuite/gas/scfi/aarch64/ginsn-misc-1.l
 create mode 100644 gas/testsuite/gas/scfi/aarch64/ginsn-misc-1.s
 create mode 100644 gas/testsuite/gas/scfi/aarch64/scfi-aarch64.exp
 create mode 100644 gas/testsuite/gas/scfi/aarch64/scfi-cb-1.d
 create mode 100644 gas/testsuite/gas/scfi/aarch64/scfi-cb-1.l
 create mode 100644 gas/testsuite/gas/scfi/aarch64/scfi-cb-1.s
 create mode 100644 gas/testsuite/gas/scfi/aarch64/scfi-cfg-1.d
 create mode 100644 gas/testsuite/gas/scfi/aarch64/scfi-cfg-1.l
 create mode 100644 gas/testsuite/gas/scfi/aarch64/scfi-cfg-1.s
 create mode 100644 gas/testsuite/gas/scfi/aarch64/scfi-cfg-2.d
 create mode 100644 gas/testsuite/gas/scfi/aarch64/scfi-cfg-2.l
 create mode 100644 gas/testsuite/gas/scfi/aarch64/scfi-cfg-2.s
 create mode 100644 gas/testsuite/gas/scfi/aarch64/scfi-cfg-3.d
 create mode 100644 gas/testsuite/gas/scfi/aarch64/scfi-cfg-3.l
 create mode 100644 gas/testsuite/gas/scfi/aarch64/scfi-cfg-3.s
 create mode 100644 gas/testsuite/gas/scfi/aarch64/scfi-cfg-4.d
 create mode 100644 gas/testsuite/gas/scfi/aarch64/scfi-cfg-4.l
 create mode 100644 gas/testsuite/gas/scfi/aarch64/scfi-cfg-4.s
 create mode 100644 gas/testsuite/gas/scfi/aarch64/scfi-cond-br-1.d
 create mode 100644 gas/testsuite/gas/scfi/aarch64/scfi-cond-br-1.l
 create mode 100644 gas/testsuite/gas/scfi/aarch64/scfi-cond-br-1.s
 create mode 100644 gas/testsuite/gas/scfi/aarch64/scfi-diag-1.l
 create mode 100644 gas/testsuite/gas/scfi/aarch64/scfi-diag-1.s
 create mode 100644 gas/testsuite/gas/scfi/aarch64/scfi-diag-2.l
 create mode 100644 gas/testsuite/gas/scfi/aarch64/scfi-diag-2.s
 create mode 100644 gas/testsuite/gas/scfi/aarch64/scfi-ldrp-1.d
 create mode 100644 gas/testsuite/gas/scfi/aarch64/scfi-ldrp-1.l
 create mode 100644 gas/testsuite/gas/scfi/aarch64/scfi-ldrp-1.s
 create mode 100644 gas/testsuite/gas/scfi/aarch64/scfi-ldrp-2.d
 create mode 100644 gas/testsuite/gas/scfi/aarch64/scfi-ldrp-2.l
 create mode 100644 gas/testsuite/gas/scfi/aarch64/scfi-ldrp-2.s
 create mode 100644 gas/testsuite/gas/scfi/aarch64/scfi-strp-1.d
 create mode 100644 gas/testsuite/gas/scfi/aarch64/scfi-strp-1.l
 create mode 100644 gas/testsuite/gas/scfi/aarch64/scfi-strp-1.s
 create mode 100644 gas/testsuite/gas/scfi/aarch64/scfi-strp-2.d
 create mode 100644 gas/testsuite/gas/scfi/aarch64/scfi-strp-2.l
 create mode 100644 gas/testsuite/gas/scfi/aarch64/scfi-strp-2.s
 create mode 100644 gas/testsuite/gas/scfi/aarch64/scfi-unsupported-1.l
 create mode 100644 gas/testsuite/gas/scfi/aarch64/scfi-unsupported-1.s