mbox series

[v0,00/10] Fix obsolescence warnings when regenerating build scripts with autoreconf-2.72

Message ID 20240528094949.1299120-1-matthieu.longo@arm.com
Headers
Series Fix obsolescence warnings when regenerating build scripts with autoreconf-2.72 |

Message

Matthieu Longo May 28, 2024, 9:49 a.m. UTC 
  This patch series replaces obsolete macros that are warned on by autoreconf-2.72.
It aims at removing noise from a future upgrade to autoreconf-2.72 or later.
This is in no way a complete patch set allowing the upgrade to autoreconf-2.72.

Please find here below the list of changes along the doc links.
- AC_HELP_STRING by AS_HELP_STRING
  https://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.72/autoconf.html#index-AC_005fHELP_005fSTRING-1
- AC_AIX, AC_MINIX, and AC_GNU_SOURCE by AC_USE_SYSTEM_EXTENSIONS
  https://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.72/autoconf.html#index-AC_005fAIX
  https://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.72/autoconf.html#index-AC_005fMINIX-1
  https://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.72/autoconf.html#index-AC_005fGNU_005fSOURCE-1
- AC_PROG_LIBTOOL by LT_INIT
  https://www.gnu.org/software/libtool/manual/html_node/LT_005fINIT.html#index-LT_005fINIT
- AC_CANONICAL_SYSTEM by AC_CANONICAL_TARGET
  https://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.72/autoconf.html#index-AC_005fCANONICAL_005fTARGET-1
- AC_CONFIG_HEADER by AC_CONFIG_HEADERS
  https://www.gnu.org/software/automake/manual/1.12.2/html_node/Obsolete-Macros.html#index-AM_005fCONFIG_005fHEADER
- old AC_INIT by AC_INIT + AC_CONFIG_SRC_DIR
  https://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.72/autoconf.html#index-AC_005fINIT-3
- add square brackets around argument of AC_PREREQ
  https://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.72/autoconf.html#index-AC_005fPREREQ-1
- add square brackets around arguments of AC_INIT
  https://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.72/autoconf.html#index-AC_005fINIT-2
- delete obsolete unused m4 file config/uintmax_t.m4

I splitted the diff of the generated files in the last commit of the patch series so that it is easier to review.

I regenerated the build files using the contrib/autoregen.py script mentioned in https://sourceware.org/pipermail/binutils/2024-April/133731.html with the following configuration:
+ autoconf --version
autoconf (GNU Autoconf) 2.69
+ automake --version
automake (GNU automake) 1.15.1
+ aclocal --version
aclocal (GNU automake) 1.15.1
+ autoheader --version
autoheader (GNU Autoconf) 2.69


Ok for binutils-master? I don't have commit access so I need someone to commit on my behalf.

Regards,
Matthieu


Matthieu Longo (10):
  autoupdate: replace obsolete macros AC_HELP_STRING
  autoupdate: replace obsolete macros AC_AIX, AC_MINIX, and AC_GNU_SOURCE
  autoupdate: replace obsolete macros AC_PROG_LIBTOOL
  autoupdate: replace obsolete macros AC_CANONICAL_SYSTEM
  autoupdate: replace obsolete macros AC_CONFIG_HEADER
  autoupdate: replace old version of AC_INIT by the new one
  autoupdate: add square brackets around argument of AC_PREREQ
  autoupdate: add square brackets around arguments of AC_INIT
  autoconf: delete obsolete unused m4 file
  autoupdate: diff after replacing obsolete macros with previous patches

 bfd/configure                     |  6 ++----
 bfd/configure.ac                  |  3 +--
 binutils/configure                |  6 ++----
 binutils/configure.ac             |  5 ++---
 config/acx.m4                     |  4 ++--
 config/debuginfod.m4              |  2 +-
 config/enable.m4                  |  2 +-
 config/lib-prefix.m4              |  2 +-
 config/lthostflags.m4             |  2 +-
 config/uintmax_t.m4               | 32 -------------------------------
 configure                         |  2 +-
 configure.ac                      |  7 ++++---
 gas/configure                     |  6 ++----
 gas/configure.ac                  |  3 +--
 gdbsupport/configure.ac           |  4 ++--
 gnulib/configure.ac               |  4 ++--
 gold/configure                    |  2 --
 gold/configure.ac                 |  4 +---
 gprof/configure                   |  6 ++----
 gprof/configure.ac                |  3 +--
 gprofng/configure.ac              |  2 +-
 gprofng/libcollector/configure.ac |  2 +-
 ld/configure                      |  6 ++----
 ld/configure.ac                   |  5 ++---
 libbacktrace/configure            |  5 ++---
 libbacktrace/configure.ac         |  7 ++++---
 libctf/configure.ac               |  4 ++--
 libiberty/configure               |  1 -
 libiberty/configure.ac            |  4 ++--
 libsframe/configure.ac            |  2 +-
 opcodes/configure                 |  6 ++----
 opcodes/configure.ac              |  3 +--
 readline/readline/configure.ac    | 19 +++++++++---------
 sim/configure.ac                  |  2 +-
 zlib/configure                    |  5 ++---
 zlib/configure.ac                 |  4 ++--
 36 files changed, 63 insertions(+), 119 deletions(-)
 delete mode 100644 config/uintmax_t.m4

Comments

Alan Modra June 7, 2024, 1:48 a.m. UTC | #1 
On Tue, May 28, 2024 at 10:49:39AM +0100, Matthieu Longo wrote:
> This patch series replaces obsolete macros that are warned on by autoreconf-2.72.
> It aims at removing noise from a future upgrade to autoreconf-2.72 or later.
> This is in no way a complete patch set allowing the upgrade to autoreconf-2.72.

I'm going to commit this for you with two changes, unless I hear a NACK
from gdb developers:
- The ifdef on AC_HELP_STRING in lib-prefix.m4 does not get replaced
  with AS_HELP_STRING, instead the idfef disappears.
- No changes are made to gnulib/ since this is an imported directory
  with a check in update-gnulib.sh that no one has been tweaking the
  source.

I'll note that your patches to other imported dirs will likely
disappear unless you also submit them to the upstream projects.
Alan Modra June 7, 2024, 10:42 p.m. UTC | #2 
On Fri, Jun 07, 2024 at 09:58:50AM -0600, Tom Tromey wrote:
> >>>>> Alan Modra <amodra@gmail.com> writes:
> 
> > - No changes are made to gnulib/ since this is an imported directory
> >   with a check in update-gnulib.sh that no one has been tweaking the
> >   source.
> 
> I think changes to gnulib itself (e.g., gnulib/configure.ac) are ok but
> subdirs of gnulib come direct from upstream.

I completely misunderstood update-gnulib.sh.  (I think I have it
figured out now, not that it matters.)  I'll put back the
gnulib/configure.ac changes.

> > I'll note that your patches to other imported dirs will likely
> > disappear unless you also submit them to the upstream projects.
> 
> There were a bunch of these in the series: readline, gnulib, several
> from gcc...
> 
> Tom