diff mbox

[review] gdb/testsuite: Fix minor bug in skip_btrace*tests procs

Message ID gerrit.1574100765000.I6dfc04b4adcf5b9424fb542ece7ddbe751bee301@gnutoolchain-gerrit.osci.io
State New, archived
Headers

Commit Message

Simon Marchi (Code Review) Nov. 18, 2019, 6:12 p.m. UTC 
  Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/685
......................................................................

gdb/testsuite: Fix minor bug in skip_btrace*tests procs

The two guard functions skip_btrace_tests and skip_btrace_pt_tests
have a minor bug, if the check function fails to compile then surely
we should skip the btrace tests - currently we return 0 to indicate
don't skip.

gdb/testsuite/ChangeLog:

	* lib/gdb.exp (skip_btrace_tests): Return 1 if the test fails to
	compile.
	(skip_btrace_pt_tests): Likewise.

Change-Id: I6dfc04b4adcf5b9424fb542ece7ddbe751bee301
---
M gdb/testsuite/ChangeLog
M gdb/testsuite/lib/gdb.exp
2 files changed, 8 insertions(+), 2 deletions(-)

Comments

Metzger, Markus T Nov. 19, 2019, 8:04 a.m. UTC | #1 
Hello Andrew,

> gdb/testsuite: Fix minor bug in skip_btrace*tests procs

> 

> The two guard functions skip_btrace_tests and skip_btrace_pt_tests have a minor

> bug, if the check function fails to compile then surely we should skip the btrace tests

> - currently we return 0 to indicate don't skip.

> 

> gdb/testsuite/ChangeLog:

> 

> 	* lib/gdb.exp (skip_btrace_tests): Return 1 if the test fails to

> 	compile.

> 	(skip_btrace_pt_tests): Likewise.

> 

> Change-Id: I6dfc04b4adcf5b9424fb542ece7ddbe751bee301

> ---

> M gdb/testsuite/ChangeLog

> M gdb/testsuite/lib/gdb.exp

> 2 files changed, 8 insertions(+), 2 deletions(-)


LGTM.

Markus.
Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Gary Kershaw
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
Simon Marchi (Code Review) Nov. 28, 2019, 12:44 a.m. UTC | #2 
Andrew Burgess has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/685
......................................................................


Patch Set 1:

I went ahead and merged this fix as obvious.
diff mbox

Patch

diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 3a4d229..a598b23 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,9 @@ 
+2019-11-18  Andrew Burgess  <andrew.burgess@embecosm.com>
+
+	* lib/gdb.exp (skip_btrace_tests): Return 1 if the test fails to
+	compile.
+	(skip_btrace_pt_tests): Likewise.
+
 2019-11-14  Tom Tromey  <tromey@adacore.com>
 
 	* gdb.base/gdbvars.exp (test_convenience_variables): Add
diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
index 2d395ef..3662a61 100644
--- a/gdb/testsuite/lib/gdb.exp
+++ b/gdb/testsuite/lib/gdb.exp
@@ -2942,7 +2942,7 @@ 
     # Compile a test program.
     set src { int main() { return 0; } }
     if {![gdb_simple_compile $me $src executable]} {
-        return 0
+        return 1
     }
 
     # No error message, compilation succeeded so now run it via gdb.
@@ -2993,7 +2993,7 @@ 
     # Compile a test program.
     set src { int main() { return 0; } }
     if {![gdb_simple_compile $me $src executable]} {
-        return 0
+        return 1
     }
 
     # No error message, compilation succeeded so now run it via gdb.