testsuite: stdlib/isomac.c: add missing include
Commit Message
When running the testsuite, building stdlib/isomac.c outputs the
following warning:
gcc -O -D_GNU_SOURCE -DIS_IN_build -include /home/aurel32/glibc-build/config.h isomac.c -o /home/aurel32/glibc-build/stdlib/isomac
isomac.c: In function ‘get_null_defines’:
isomac.c:260:3: warning: implicit declaration of function ‘close’; did you mean ‘pclose’? [-Wimplicit-function-declaration]
close (fd);
^~~~~
pclose
Fix that by adding the <unistd.h> include.
Changelog:
* stdlib/isomac.c: Include <unistd.h>.
---
ChangeLog | 4 ++++
stdlib/isomac.c | 1 +
2 files changed, 5 insertions(+)
Comments
Aurelien Jarno wrote:
> When running the testsuite, building stdlib/isomac.c outputs the
> following warning:
>
> gcc -O -D_GNU_SOURCE -DIS_IN_build -include /home/aurel32/glibc-build/config.h isomac.c -o /home/aurel32/glibc-build/stdlib/isomac
> isomac.c: In function ‘get_null_defines’:
> isomac.c:260:3: warning: implicit declaration of function ‘close’; did you mean ‘pclose’? [-Wimplicit-function-declaration]
> close (fd);
> ^~~~~
> pclose
>
> Fix that by adding the <unistd.h> include.
>
> Changelog:
> * stdlib/isomac.c: Include <unistd.h>.
> ---
> ChangeLog | 4 ++++
> stdlib/isomac.c | 1 +
> 2 files changed, 5 insertions(+)
Indeed, in POSIX close() requires unistd.h[*].
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
[*] pubs.opengroup.org/onlinepubs/9699919799/functions/close.html
On 2019-01-08 21:10, Aurelien Jarno wrote:
> When running the testsuite, building stdlib/isomac.c outputs the
> following warning:
>
> gcc -O -D_GNU_SOURCE -DIS_IN_build -include /home/aurel32/glibc-build/config.h isomac.c -o /home/aurel32/glibc-build/stdlib/isomac
> isomac.c: In function ‘get_null_defines’:
> isomac.c:260:3: warning: implicit declaration of function ‘close’; did you mean ‘pclose’? [-Wimplicit-function-declaration]
> close (fd);
> ^~~~~
> pclose
>
> Fix that by adding the <unistd.h> include.
>
Ping, now that master is opened again for development, is this patch
fine to be committed?
* Aurelien Jarno:
> On 2019-01-08 21:10, Aurelien Jarno wrote:
>> When running the testsuite, building stdlib/isomac.c outputs the
>> following warning:
>>
>> gcc -O -D_GNU_SOURCE -DIS_IN_build -include /home/aurel32/glibc-build/config.h isomac.c -o /home/aurel32/glibc-build/stdlib/isomac
>> isomac.c: In function ‘get_null_defines’:
>> isomac.c:260:3: warning: implicit declaration of function ‘close’; did you mean ‘pclose’? [-Wimplicit-function-declaration]
>> close (fd);
>> ^~~~~
>> pclose
>>
>> Fix that by adding the <unistd.h> include.
>>
>
> Ping, now that master is opened again for development, is this patch
> fine to be committed?
Yes, please. Patch looks good to me.
Thanks,
Florian
@@ -1,3 +1,7 @@
+2019-01-08 Aurelien Jarno <aurelien@aurel32.net>
+
+ * stdlib/isomac.c: Include <unistd.h>.
+
2019-01-07 H.J. Lu <hongjiu.lu@intel.com>
[BZ #24066]
@@ -74,6 +74,7 @@
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
+#include <unistd.h>
#define HEADER_MAX 256