Use sysdep.o from libc.a in libpthread.a on more architectures [BZ #20452]
Commit Message
This changes microblaze, powerpc, sparc, tile, in addition to x86, which
was changed in commit e67330ab57bfd0f964539576ae7dcc658c456724.
2016-08-11 Florian Weimer <fweimer@redhat.com>
[BZ #20452]
Use sysdep.o from libc.a in static libraries.
* sysdeps/unix/sysv/linux/microblaze/Makefile
(libpthread-shared-only-routines): Add sysdep.
* sysdeps/unix/sysv/linux/powerpc/Makefile
(libpthread-shared-only-routines): Likewise.
* sysdeps/unix/sysv/linux/sparc/Makefile
(libpthread-shared-only-routines): Likewise.
* sysdeps/unix/sysv/linux/tole/Makefile
(libpthread-shared-only-routines): Likewise.
Comments
On 08/11/2016 08:40 AM, Florian Weimer wrote:
> This changes microblaze, powerpc, sparc, tile, in addition to x86, which
> was changed in commit e67330ab57bfd0f964539576ae7dcc658c456724.
>
> 2016-08-11 Florian Weimer <fweimer@redhat.com>
>
> [BZ #20452]
> Use sysdep.o from libc.a in static libraries.
> * sysdeps/unix/sysv/linux/microblaze/Makefile
> (libpthread-shared-only-routines): Add sysdep.
> * sysdeps/unix/sysv/linux/powerpc/Makefile
> (libpthread-shared-only-routines): Likewise.
> * sysdeps/unix/sysv/linux/sparc/Makefile
> (libpthread-shared-only-routines): Likewise.
> * sysdeps/unix/sysv/linux/tole/Makefile
> (libpthread-shared-only-routines): Likewise.
This looks good to me granted you verified the resulting libpthread
in at least one architecture has the symbols removed.
Cheers,
Carlos.
On Thu, 11 Aug 2016 14:40:19 +0200
fweimer@redhat.com (Florian Weimer) wrote:
> This changes microblaze, powerpc, sparc, tile, in addition to x86,
> which was changed in commit e67330ab57bfd0f964539576ae7dcc658c456724.
How about s390(x)? The original qemu issue is also there - see
https://bugzilla.redhat.com/show_bug.cgi?id=1352625#c6 (and the closed
duplicate above)
Dan
@@ -5,4 +5,5 @@ endif
ifeq ($(subdir),nptl)
# pull in __syscall_error routine
libpthread-routines += sysdep
-endif
\ No newline at end of file
+libpthread-shared-only-routines += sysdep
+endif
@@ -34,4 +34,5 @@ ifeq ($(subdir),nptl)
libpthread-routines += sysdep
libpthread-sysdep_routines += elision-lock elision-unlock elision-timed \
elision-trylock
+libpthread-shared-only-routines += sysdep
endif
@@ -15,4 +15,5 @@ endif
ifeq ($(subdir),nptl)
# pull in __syscall_error routine
libpthread-routines += sysdep
+libpthread-shared-only-routines += sysdep
endif
@@ -25,4 +25,5 @@ endif
ifeq ($(subdir),nptl)
# pull in __syscall_error routine
libpthread-routines += sysdep
+libpthread-shared-only-routines += sysdep
endif